View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003208 | The Dark Mod | TDM Installer | public | 24.08.2012 06:44 | 24.08.2012 15:36 |
Reporter | tels | Assigned To | grayman | ||
Priority | normal | Severity | normal | Reproducibility | sometimes |
Status | resolved | Resolution | fixed | ||
Target Version | TDM 1.08 | Fixed in Version | TDM 1.08 | ||
Summary | 0003208: tdm_updater builds wrong paths, fails to download from bloodgate.com | ||||
Description | If you enter bloodgate.com as the only mirror in tdm_mirrors.txt and start tdm_updater.linux --keep-mirrors, the result is this: TDM Updater v0.58 (c) 2009-2012 by tels & greebo. Part of The Dark Mod (http://www.thedarkmod.com). ---------------------------------------------------------------------------- Initialising... Done. ---------------------------------------------------------------------------- Cleaning up previous update session... Done. ---------------------------------------------------------------------------- Downloading mirror information... Skipped downloading mirrors. Found 1 mirror. ---------------------------------------------------------------------------- Downloading CRC file... Downloading from Mirror bloodgate.com: crc_info.txt [=========================] 100.0% at 0 bytes/sec ---------------------------------------------------------------------------- Downloading version info file... Downloading from Mirror bloodgate.com: tdm_version_info.txt [=========================] 100.0% at 0 bytes/sec Done downloading versions. ---------------------------------------------------------------------------- Trying to match local files to version definitions... [=========================] 100.0% File: Done comparing local files: no luck, PK4 files do not match. ---------------------------------------------------------------------------- Comparing local files to server definitions... [=========================] 100.0% File: Done comparing local files to server definitions. Your TDM installation is up to date Afterwards, there are not real files. | ||||
Additional Information | The log says this: Picking mirror bloodgate.com Downloading to temporary file /home/te/test/darkmod/__crc_info.txt Initiating Download from http://bloodgate.com/mirrors/tdm/pub/pk4/ /crc_info.txt Download successful: http://bloodgate.com/mirrors/tdm/pub/pk4/ /crc_info.txt Downloaded file passed the integrity checks. Moved /home/te/test/darkmod/__crc_info.txt to /home/te/test/darkmod/crc_info.txt Could not fully parse the INI file. Step thread finished: 3 Step thread started: 4 Looking at the paths, trying to retrieve "http://bloodgate.com/mirrors/tdm/pub/pk4/ /crc_info.txt" will fail, as this file is non-existant. It seems the updater somehow ends up with a space in the URL, and then appends "/" and then the file it wants. The fix consists of deleting the additional space in the URL in mirrors.txt, but it would be good if the updater could remove any spaces before/after the URL automatically. Otherwise, some of the mirrors might fail, which only some users see. | ||||
Tags | No tags attached. | ||||
Was the tdm_mirrors.txt version with the extra bloodgate space already distributed? | |
Yes, I think the current file has the space already in it (I just edited it and commented everything except bloodgate.com out). There was a thread where someone reported that all mirrors work except bloodgate.com. Even if not yet distributed, users might modify their file locally for testing and run into this issue and the solution is not apparent from the error occuring at all. |
|
I added a line in tdm_update to remove all spaces in the url. I used it to update an empty folder to 1.07 using a mirrors file with bloodgate being the only entry, and with that entry having a trailing space. It worked fine. I checked in a new tdm_mirrors.txt with the space removed. Any 1.08 update attempt will first get the list of mirrors from thedarkmod.com, which will bring in the corrected bloodgate entry, so even w/o the fix to this issue, it would work okay. The issue fix becomes important if someone asks tdm_update to NOT update the list of mirrors, which allows the bad bloodgate entry to be read. |
|
Added a line to remove all spaces from a tdm_mirrors.txt entry that accidently has one (i.e. bloodgate). rev. 5534: tdm_update\libtdm_update\Http\MirrorList.h |
|
Date Modified | Username | Field | Change |
---|---|---|---|
24.08.2012 06:44 | tels | New Issue | |
24.08.2012 14:18 | grayman | Note Added: 0004779 | |
24.08.2012 14:48 | tels | Note Added: 0004780 | |
24.08.2012 15:27 | grayman | Note Added: 0004781 | |
24.08.2012 15:27 | grayman | Assigned To | => grayman |
24.08.2012 15:27 | grayman | Status | new => assigned |
24.08.2012 15:36 | grayman | Note Added: 0004782 | |
24.08.2012 15:36 | grayman | Status | assigned => resolved |
24.08.2012 15:36 | grayman | Resolution | open => fixed |
24.08.2012 15:36 | grayman | Fixed in Version | => TDM 1.08 |
24.08.2012 15:36 | grayman | Target Version | => TDM 1.08 |
19.05.2021 05:34 | stgatilov | Category | TDM Updater => TDM Installer |