View Issue Details

IDProjectCategoryView StatusLast Update
0003238The Dark ModCodingpublic15.09.2014 09:57
Reportertels Assigned ToSteveL  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 1.08 
Fixed in VersionTDM 2.03 
Summary0003238: Lights are still rendered, even when hidden or off
DescriptionIf you call Hide() on a light, it does this:

            Hide();
            smoking = false; // grayman 0002603
            PresentModelDefChange();
            Off();

The call to Hide() is on the idEntity class and hides visual model the light has (if it has any).

The call to PresentModelDefChange(); makes the renderer know about this change, so the next frame the light model will be gone.

The call to Off() sets the light color to black. This means the lightDef is still presented to the renderer, which still renderes the light, except that normal lights have now a color of black and are thus invisible. The only lights affected by this bug are blend lights, fog lights etc.
Steps To Reproduce* Create a fog light
* call hide() via script on the light
* the fog is still there, just black
Additional Informationhttp://forums.thedarkmod.com/topic/14116-hide-on-idlights-especially-fogs/page__view__findpost__p__295639

Two solutions are here that either hide() does hide the lighDef, too (and show() recreates it), or that Off() hides the lightDef, too.

The second way (in Off()) has the advantage that any light that is off will also be completely skipped in the renderer, not just being "not rendered".
TagsNo tags attached.

Relationships

related to 0003752 resolvedSteveL Let entity lights use shadowlights and blendlights 

Activities

SteveL

SteveL

14.09.2014 21:31

reporter   ~0007002

Fixed in 0003752. Shadowlights and blendlights now respond to Off()

Issue History

Date Modified Username Field Change
21.09.2012 14:59 tels New Issue
13.07.2013 02:23 Springheel Target Version TDM 2.00 =>
14.09.2014 21:31 SteveL Note Added: 0007002
14.09.2014 21:31 SteveL Status new => resolved
14.09.2014 21:31 SteveL Fixed in Version => TDM 2.03
14.09.2014 21:31 SteveL Resolution open => fixed
14.09.2014 21:31 SteveL Assigned To => SteveL
15.09.2014 09:57 tels Relationship added related to 0003752