 |
Look for physicsObj.IsCrouching() in idPlayer::Move(). The lantern is attached to the player's hip, whose height is not affected by crouching. The lantern origin should be adjusted according to the eye height, so that height of lantern when crouched / height of lantern when standing equals height of eye when crouched / height of eye when standing |
 |
Me thinks it would be much better to fix the problem with the animation (that the hip is not moved when you crouch indicates that the player is not using a "crouch animation", but instead is still standing?) instead of mucking with the lantern. If the lantern is bound to the hip, and the hip does not move, then anything else bound to the hip will also not move. Also, fixing the origin of the attached lantern from the SDK code is not easy (one would first need to find out if a lantern is attached, but how to reliable detect the lantern while not missing other attached items that could also be probematic), nor is it that easy from the script side (because the script side has atm no way to find out wether an actor is crouched/kneeling except by peeking at the current animation). |
 |
"Me thinks it would be much better to fix the problem with the animation " If you know anyone who can fix the animations, let me know. |
|
|
I've tried to look up the animations in game, but didn't remember how to enable the thief-model rendering. Enabling the shadow shows that the shadow "ducks" when crouched, so it seems the animations are ok. So, how do we find out if the hip "is not affected by crouching" as grayman says? Shouldn't it be affected, because when you crouch, your head goes down too? Or is the camera position "faked" independently from the crouch-animation? Also, a testmap would be nice. "if the headroom goes below a certain value" is a bit unspecific. What is this value and what would be the one we want it to work for? |
|
|
I attached a test map. Turn on the lantern. Crouch down at either end of the duct. Mantle up into the duct and walk to the other end. Light goes out while inside the duct, but it might flash occasionally. |
|
|
"Enabling the shadow shows that the shadow "ducks" when crouched, so it seems the animations are ok." The player animations are terrible hacks. When the player crouches, the animation actually just translates the knee joints (and possibly hips) downwards, sinking them into the legs. It doesn't attempt to simulate crouching at all. I haven't looked at them for years, but the last time I did there was some hurdle to just replacing them with better animations. I forget what it was. |
|
|
If the hips are going down into the legs, then is it possible that the lantern's light source is embedded in the legs, which is why it goes dark? |
|
|
I don't know for sure that they do. But if they did, the going dark should happen all the time when you crouch. I've only experienced this issue in very tight spaces like vents. This sounds more like it's clipping into world geometry. |
|
|
Ah, ok, if the "animation" is just some fake translation, then it might well be that "hip position while standing + 10 units offset for light" is not translated down enough for "hip position while crouch-faked + 10 units" so the lantern clips into the ceiling. (We had a similiar case that it clipped into walls while you crouched through ducts because it was too far out from the player hip). I'm a bit unsure if we really should just postpone this until someone can fix the animations (which might well be never) or do some other faking on top of the current fake to fix this issue in the meantime. I don't really like to pile special case on special case, only to have it fail for the next special case again. Oh well. One quick fix would be to see if attaching the light with an offset of say "+5" instead of "+10" will fix it, while not making the light to low while standing. That would be quick and easy. |
 |
This still happens in 2.06. That said, you can barely enter this vent in 2.06. Grayman's original solution sounds the best though. |
 |
IMO binding the lantern to the head origin is a good idea. It might not be super realistic, but it should be transparent for players. Also the lantern seems to go through walls when you're very close. It looks like it's bound to left hip, there is a difference when you're turning around standing nearby such wall. Head level + slight offset to the back should do the trick. |
 |
I've uploaded an alternative lantern binding in the other tracker entry linked above (0004977). As far as my tests concern (with the above linked testmap, too) there doesn't seem to be anymore clipping issues. Maybe someone else could test it and second the observation. |
- Anonymous
