View Issue Details

IDProjectCategoryView StatusLast Update
0003586The Dark ModCodingpublic30.11.2013 02:23
ReporterAluminumHaste Assigned Tograyman  
PriorityhighSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 2.00 
Target VersionTDM 2.01Fixed in VersionTDM 2.01 
Summary0003586: Closing a book/readable with USE button frobs item in inventory
DescriptionWhen reading items that you don't pick up, such as posters on walls, books that you can only read etc, if you close it using the USE key, while having a frobbable item selected, uses that item.
For example, if you have the lantern selected, closing the readable with USE causes the lantern to turn on.
Also if you have health potion selected or holy water, it will consume that item.
TagsNo tags attached.

Activities

grayman

grayman

28.10.2013 00:48

viewer   ~0006219

Last edited: 23.11.2013 17:08

The following problem might be related, so I'm adding it to this issue.

When reading a multi-page book, and using the scroll wheel to scroll through it, the inventory system is also receiving the scroll event, and the weapons start scrolling in the background. When you leave the book, the chosen weapon readies itself (blackjack, bow, or sword pops up).

Edit: Now I can't reproduce this problem.

Springheel

Springheel

19.11.2013 00:44

administrator   ~0006241

Just wanted to confirm that the original issue happens to me as well.
grayman

grayman

23.11.2013 20:25

viewer   ~0006270

I found this comment in the readables gui:

"// greebo: Close this readable, when (other) inventory items get used"

This tells me the observed behavior is intended. The active inventory item can be used even when a readable is open. The readable just gets closed as a side effect.

Comments?
AluminumHaste

AluminumHaste

27.11.2013 05:06

developer   ~0006278

I suppose that the original behaviour was that perhaps if you had a flashbomb selected and a guard came upon you while reading, you could drop a flashbomb and close the readable at the same time.
Will try and test this tonight when I get home. But regardless, no one ever expects that behaviour so it's kinda not wanted.
Springheel

Springheel

27.11.2013 22:26

administrator   ~0006284

I don't think it makes sense to use inventory items while reading.
AluminumHaste

AluminumHaste

27.11.2013 22:44

developer   ~0006285

Yeah I tried it a few times, I don't like it.
grayman

grayman

28.11.2013 00:40

viewer   ~0006286

This is a behavior change, not a bug fix.

Disallow using inventory items while a readable is on the screen.

Delay releasing the immobilization lock (which prevents the USE key from using inventory items) until the readable is off the screen.

Rev. 13727:

tdm_readables.script
grayman

grayman

29.11.2013 03:55

viewer   ~0006296

I just noticed that I can't close a readable with the USE key when no inventory icons are showing.

I went back to 1.08 to see what the behavior was there, and it's the same.

Are you guys expecting to be able to use the USE key to close an immobile readable when no inventory icon is displayed?

I suspect that we aren't supposed to be using the USE key to close immobile readables; it just happened to close them when we USEd whatever inventory item was active.

The USE key closes a mobile readable because it's toggling that inventory item on and off.

The "Dark Mod Gameplay" wiki talks about using USE to open and close readables in inventory, but says nothing about opening or closing immobile readables.

The first book in the Training Missions says a readable can be closed using the ATTACK or USE keys, but doesn't differentiate between mobile and immobile readables. The statement is true for mobiles but false for immobiles.
AluminumHaste

AluminumHaste

29.11.2013 17:33

developer   ~0006298

Yes it should be consistent across readables, static or moveable, using USE to open the readable should also work to close it regardless of what's selected in the inventory.
If that can be done without breaking inventory somehow, I guess that's my vote.

Either allow USE button to close across all readables regardless of type, or disallow it completely, just to make it consistent.
Springheel

Springheel

29.11.2013 19:01

administrator   ~0006299

Last edited: 29.11.2013 19:02

I'm fine with "use" closing static readables.

grayman

grayman

30.11.2013 02:23

viewer   ~0006300

Also needed a change so that immobile readables will close when the USE key is pressed and no inventory items are showing. This is also a behavior change, not a bug fix.

Rev. 5908:

Player.cpp

Rev. 13734:

tdm_readables.script

Issue History

Date Modified Username Field Change
24.10.2013 22:48 AluminumHaste New Issue
28.10.2013 00:48 grayman Note Added: 0006219
19.11.2013 00:44 Springheel Note Added: 0006241
23.11.2013 16:30 grayman Assigned To => grayman
23.11.2013 16:30 grayman Status new => assigned
23.11.2013 17:08 grayman Note Edited: 0006219
23.11.2013 20:25 grayman Note Added: 0006270
27.11.2013 03:40 grayman Assigned To grayman => AluminumHaste
27.11.2013 03:40 grayman Status assigned => feedback
27.11.2013 05:06 AluminumHaste Note Added: 0006278
27.11.2013 05:06 AluminumHaste Status feedback => assigned
27.11.2013 22:26 Springheel Note Added: 0006284
27.11.2013 22:44 AluminumHaste Note Added: 0006285
28.11.2013 00:40 grayman Note Added: 0006286
28.11.2013 00:40 grayman Severity major => feature
28.11.2013 00:40 grayman Status assigned => resolved
28.11.2013 00:40 grayman Resolution open => fixed
28.11.2013 00:40 grayman Fixed in Version => TDM 2.01
28.11.2013 00:42 grayman Assigned To AluminumHaste => grayman
28.11.2013 00:42 grayman Status resolved => assigned
28.11.2013 15:21 grayman Status assigned => resolved
29.11.2013 03:55 grayman Note Added: 0006296
29.11.2013 03:55 grayman Status resolved => assigned
29.11.2013 17:33 AluminumHaste Note Added: 0006298
29.11.2013 19:01 Springheel Note Added: 0006299
29.11.2013 19:02 Springheel Note Edited: 0006299
30.11.2013 02:23 grayman Note Added: 0006300
30.11.2013 02:23 grayman Status assigned => resolved