 |
Also idVec3::ToString() And idMat3::ToString() And probably lots more These are all creating idStr objects on the heap anyway so they should be returning those objects instead of a pointer to the heap data, which they immediately release back to the pool. |
 |
I've tried to see what other "ToString()" functions do, they too need to solve the same problem. But looking at idStr::FloatArrayToString, we see it used an array of four values, so if you call it in a nested function more than four times, it starts overwriting it's own data. The 16K fixed buffer does not help, either. This smells like buffer-overflows. Ugh. /* ============= idStr::FloatArrayToString ============= */ const char *idStr::FloatArrayToString( const float *array, const int length, const int precision ) { static int index = 0; static char str[4][16384]; // in case called by nested functions int i, n; char format[16], *s; // use an array of string so that multiple calls won't collide s = str[ index ]; index = (index + 1) & 3; ... |
|
|
Yep, that's a different but equally dodgy pattern. These should all be returning a const idStr by value. I checked Str.h and it seems idStr doesn't implement lazy copying, but I expect the compiler will do that for itself if the return value is const, and anyway, there's no need to care about it even if the string gets copied on the heap. These functions are for debugging and occasional console output, they're not going to be called thousands of times per frame. Need to check for any ToString() calls embedded in Printf()s, va()s and the like before making changes, because they'd need to use c_str(). I don't expect there'll be many. |
 |
Only idBounds::ToString is dangerous, the other two return pointer to a static char[] (array overflow and thread safety are separate issues). |
|
|
idBounds::ToString deleted as unused |
 |
I use idBounds::ToString for debugging. Please put it back. |
|
|
1 - revert rev. 7219 so that idBounds.ToString() becomes available again. 2 - Open AI.cpp and look for idAI::Think(). 3 - Near the beginning of that method, just before this line: SetNextThinkFrame(); add this line: if (idStr(GetName()) == "atdm_ai_citywatch_1") DM_LOG(LC_AAS, LT_DEBUG)LOGSTRING("%s absolute bounds = [%s]\r",GetName(),GetPhysics()->GetAbsBounds().ToString()); 4 - Open darkmod/darkmod.ini and set these two values: LogDebug=1 LogClass_AAS=1 5 - Build TheDarkMod.exe. Run TheDarkMod.exe and start the mission "Thiefs' Den". There's a character in there named atdm_ai_citywatch_1 and every time he thinks, a debug line gets printed to Darkmod.log. 6 - Quit the game after 10s or so. 7 - Open Darkmod.log and notice the debug lines showing the name of the character and his current absolute bounds. |
|
|
Svn rev 7231 |
- Anonymous
