 |
Good find! This has long been a pet peeve of mine. |
 |
I can confirm this happens for me and is quite annoying visually. |
 |
testing.... |
|
|
I didn't assign this to myself originally because I couldn't/can't rep it in a test map with several giants' stairways with steps 48, 96, and 103 units high. But I did think I'd seen it in an old map I was working on last winter, when climbing out of water in a certain spot, but wasn't certain enough to mark it confirmed. I've now dug that map out of my backups, and I can rep the skybox greying out with most mantles out of the water. Confirmed that during the skyblink the player origin is in visleaf -1, i.e. outside the bsp like when noclipping. And that the function mentioned above short-circuits to "no skybox" during those frames, till the player moves again. Also that the code in that function makes *much* more sense if it's using the player's eye position instead of his or her origin. Also tried a manual test: current code: skybox vanished 12 times out of 20 mantles. With fix, using eye position instead of origin: 0 out of 50 mantles. Removing fix again: 17 out of 20 mantles. I learned to make it happen more often by looking horizontally instead if up. There's no way to be sure that this is the *only* cause, but it's a likely one. I'll commit the change. |
|
|
at rev 6085 |
|
|
And at rev 6086. Found one more place that needed the same fix. That's all of them. |
 |
Sweet. I've found a few places in the code where the Actor's (player and AI) origin was used when they should have used the Actor's eye position. So I suspect that we'll root a few more out as time goes by. Some coder must've thought Actors see with their feet. |
|
|
Evidently :-) Cheers, I'll be on the lookout for them too then. |
- Anonymous
