View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003844 | The Dark Mod | Coding | public | 07.09.2014 20:22 | 08.09.2014 17:53 |
Reporter | SteveL | Assigned To | SteveL | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | TDM 2.02 | ||||
Target Version | TDM 2.03 | Fixed in Version | TDM 2.03 | ||
Summary | 0003844: Renderer ignores reskinning of animated meshes when applying an overlay | ||||
Description | Some materials can't support overlays -- translucent materials, plus any that have "noOverlays" specified in their material definition. The job of blocking the overlay for these is done by CreateOverlay in ModelOverlay.cpp. But that routine isn't aware of any reskinning that might have happened, so can make the wrong decision for a reskinned model. Most places in the renderer that need to test shaders use a routine called R_RemapShaderBySkin to find out the right shader before they go any further. ModelOverlay should do that too. | ||||
Additional Information | Discovered and tested while discussing 0003816 | ||||
Tags | No tags attached. | ||||
related to | 0003816 | resolved | Springheel | citywatch tunic doesn't spawn wound decals |
I'm going to need to add a couple of parameters to CreatOverlay() in ModelOverlay.cpp. Currently the function receives only the base mesh def to work on, without skinning info. That base mesh has been extracted by the calling code using a function that has side-effects, so we don't want to call it a second time in CreateOverlay. Therefore better to pass the extra info as separate parameters rather than pass the parent render entity, which would entail CreateOverlay having to extract the info a second time. This approach also has the happy side effect of documenting CreateOverlay's new dependency on skins. | |
Committed at rv6098 (code), rv13986 (binaries) | |
Date Modified | Username | Field | Change |
---|---|---|---|
07.09.2014 20:22 | SteveL | New Issue | |
07.09.2014 20:22 | SteveL | Status | new => assigned |
07.09.2014 20:22 | SteveL | Assigned To | => SteveL |
07.09.2014 20:23 | SteveL | Relationship added | related to 0003816 |
08.09.2014 17:16 | SteveL | Note Added: 0006967 | |
08.09.2014 17:53 | SteveL | Note Added: 0006969 | |
08.09.2014 17:53 | SteveL | Status | assigned => resolved |
08.09.2014 17:53 | SteveL | Fixed in Version | => TDM 2.03 |
08.09.2014 17:53 | SteveL | Resolution | open => fixed |