View Issue Details

IDProjectCategoryView StatusLast Update
0003844The Dark ModCodingpublic08.09.2014 17:53
ReporterSteveL Assigned ToSteveL  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 2.02 
Target VersionTDM 2.03Fixed in VersionTDM 2.03 
Summary0003844: Renderer ignores reskinning of animated meshes when applying an overlay
DescriptionSome materials can't support overlays -- translucent materials, plus any that have "noOverlays" specified in their material definition. The job of blocking the overlay for these is done by CreateOverlay in ModelOverlay.cpp. But that routine isn't aware of any reskinning that might have happened, so can make the wrong decision for a reskinned model. Most places in the renderer that need to test shaders use a routine called R_RemapShaderBySkin to find out the right shader before they go any further. ModelOverlay should do that too.
Additional InformationDiscovered and tested while discussing 0003816
TagsNo tags attached.

Relationships

related to 0003816 resolvedSpringheel citywatch tunic doesn't spawn wound decals 

Activities

SteveL

SteveL

08.09.2014 17:16

reporter   ~0006967

I'm going to need to add a couple of parameters to CreatOverlay() in ModelOverlay.cpp. Currently the function receives only the base mesh def to work on, without skinning info. That base mesh has been extracted by the calling code using a function that has side-effects, so we don't want to call it a second time in CreateOverlay. Therefore better to pass the extra info as separate parameters rather than pass the parent render entity, which would entail CreateOverlay having to extract the info a second time. This approach also has the happy side effect of documenting CreateOverlay's new dependency on skins.
SteveL

SteveL

08.09.2014 17:53

reporter   ~0006969

Committed at rv6098 (code), rv13986 (binaries)

Issue History

Date Modified Username Field Change
07.09.2014 20:22 SteveL New Issue
07.09.2014 20:22 SteveL Status new => assigned
07.09.2014 20:22 SteveL Assigned To => SteveL
07.09.2014 20:23 SteveL Relationship added related to 0003816
08.09.2014 17:16 SteveL Note Added: 0006967
08.09.2014 17:53 SteveL Note Added: 0006969
08.09.2014 17:53 SteveL Status assigned => resolved
08.09.2014 17:53 SteveL Fixed in Version => TDM 2.03
08.09.2014 17:53 SteveL Resolution open => fixed