 |
renderLights already have suppressLightInViewID. It's just not hooked up to a spawnarg. |
|
|
Committed at rv 6487 (code), rv 14274 (new spawnarg). game/Light.cpp defs/misc.def New spawnarg is "lightgem" which defaults to 1. It's available under inherited spawnargs. |
 |
If a light with this spawnarg set to '0' doesn't contribute to the lightgem, is it reasonable to say that it will also not contribute to illumination of other objects? I.e. bodies on the floor, missing items, etc. Might want to bring this up on the thread where this change was discussed. |
|
|
I only just spotted this question. The way it's coded right now, they are independent. The lightgem calculation is done by the renderer / GPU and it's a rendering step that's been switched off. Visibility of ropes and the like is calculated in a different way. I'll see what people think in the thread. |
|
|
What I meant is, conceptually, if a light has this turned off so as not to affect the lightgem, wouldn't the light also be expected to not illuminate objects? I know the code paths are different, but the object illumination path could use the same spawnarg to ignore lights in _its_ calculation. The discussion for the thread is whether people share this view or whether they think the spawnarg should only be used by the lightgem calc. |
|
|
Understood. I've posted the question. I've since spotted the code you added to the LAS system (new one to me) to inhibit blend lights from affecting entity visibility, so I assume that'd be the place to put the fix. |
|
|
Yes, it would. |
|
|
Reopened pending outcome of forum discussion linked above. |
|
|
Unanimous votes in favour of consistent behaviour: either AI can see both the player and bodies using a given light, or they can see neither. Spawnarg changed to the more generic "ai_see", which still defaults to 1. I added a new method "IsSeenByAI()" to idLight so that the light awareness code can use the same flag that the renderer does. That'll be better for performance than checking the spawnargs every time a visibility check is done. |
|
|
rv 14284: /trunk/def/misc.def rv 6493: /trunk/game/Light.cpp /trunk/game/Light.h /trunk/game/darkModLAS.cpp |
|
|
Can you add some documentation for "ai_see" to the Light wiki? Thanks. |
|
|
Best place I could find was the Light Properties article http://wiki.thedarkmod.com/index.php?title=Light_Properties I also added noFogBoundary. |
|
|
Looks good, thanx. |
- Anonymous
