View Issue Details

IDProjectCategoryView StatusLast Update
0004332DarkRadiantDesign/Codingpublic01.01.2017 18:09
ReporterhNID Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
PlatformPCOSLinuxOS VersionManjaro 16.06
Product Version2.0.4 
Target Version2.0.4Fixed in Version2.0.4 
Summary0004332: Failure to compile recent git commits in Linux.
DescriptionCompilation fails in gcc with recent commits to git:

commit 027c141613f16c111f56ad64e5c81a2326d82c8f
commit fa8ff44edb0a68810f5a264dc36cdf73c6ca324e

In file included from /usr/include/X11/Xlib.h:44:0,
                 from /usr/include/GL/glx.h:30,
                 from /usr/include/wx-3.0/wx/unix/glx11.h:13,
                 from /usr/include/wx-3.0/wx/gtk/glcanvas.h:14,
                 from /usr/include/wx-3.0/wx/glcanvas.h:192,
                 from ../libs/wxutil/GLWidget.h:6,
                 from ./ui/common/ShaderSelector.h:6,
                 from ui/lightinspector/LightInspector.h:7,
                 from RadiantModule.cpp:41:
../include/imousetool.h:103:13: error: expected identifier before numeric constant
             None = 0, // don't refresh anything
             ^
../include/imousetool.h:103:13: error: expected ‘}’ before numeric constant
../include/imousetool.h:103:13: error: expected unqualified-id before numeric constant
In file included from ../include/imousetoolmanager.h:3:0,
                 from ui/mousetool/ToolMappingDialog.h:4,
                 from RadiantModule.cpp:50:
../include/imousetool.h:111:5: error: ‘virtual’ outside class declaration
     virtual unsigned int getRefreshMode()
     ^~~~~~~
../include/imousetool.h: In function ‘unsigned int ui::getRefreshMode()’:
../include/imousetool.h:114:16: error: ‘RefreshMode’ has not been declared
         return RefreshMode::Force | RefreshMode::ActiveView;
                ^~~~~~~~~~~
../include/imousetool.h:114:37: error: ‘RefreshMode’ has not been declared
         return RefreshMode::Force | RefreshMode::ActiveView;
                                     ^~~~~~~~~~~
../include/imousetool.h: At global scope:
../include/imousetool.h:121:5: error: ‘virtual’ outside class declaration
     virtual void renderOverlay()
     ^~~~~~~
../include/imousetool.h:124:25: error: ‘MouseTool’ was not declared in this scope
 typedef std::shared_ptr<MouseTool> MouseToolPtr;
                         ^~~~~~~~~
../include/imousetool.h:124:25: note: suggested alternative:
../include/imousetool.h:15:7: note: ‘ui::MouseTool’
 class MouseTool
       ^~~~~~~~~
../include/imousetool.h:124:34: error: template argument 1 is invalid
 typedef std::shared_ptr<MouseTool> MouseToolPtr;
                                  ^
../include/imousetool.h:126:1: error: expected declaration before ‘}’ token
 } // namespace
 ^
Makefile:2380: recipe for target 'darkradiant-RadiantModule.o' failed
make[2]: *** [darkradiant-RadiantModule.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from brush/Face.h:11:0,
                 from brush/Brush.h:6,
                 from brush/BrushNode.h:8,
                 from brush/BrushNode.cpp:1:
../libs/SurfaceShader.h: In member function ‘void SurfaceShader::attachObserver(SurfaceShader::Observer&)’:
../libs/SurfaceShader.h:151:46: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
         std::pair<Observers::iterator, bool> result = _observers.insert(&observer);
                                              ^~~~~~
In file included from brush/Face.h:11:0,
                 from brush/SelectableComponents.h:5,
                 from brush/FaceInstance.h:9,
                 from brush/FaceInstance.cpp:1:
../libs/SurfaceShader.h: In member function ‘void SurfaceShader::attachObserver(SurfaceShader::Observer&)’:
../libs/SurfaceShader.h:151:46: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
         std::pair<Observers::iterator, bool> result = _observers.insert(&observer);
                                              ^~~~~~
In file included from brush/FaceInstance.cpp:1:0:
brush/FaceInstance.h: In constructor ‘FaceInstance::FaceInstance(Face&, const SelectionChangedSlot&)’:
brush/FaceInstance.h:28:32: warning: ‘FaceInstance::m_selectableEdges’ will be initialized after [-Wreorder]
  selection::ObservedSelectable m_selectableEdges;
                                ^~~~~~~~~~~~~~~~~
brush/FaceInstance.h:25:26: warning: ‘SelectionChangedSlot FaceInstance::m_selectionChanged’ [-Wreorder]
     SelectionChangedSlot m_selectionChanged;
                          ^~~~~~~~~~~~~~~~~~
brush/FaceInstance.cpp:30:1: warning: when initialized here [-Wreorder]
 FaceInstance::FaceInstance(Face& face, const SelectionChangedSlot& observer) :
 ^~~~~~~~~~~~
In file included from brush/FaceInstance.cpp:1:0:
brush/FaceInstance.h: In copy constructor ‘FaceInstance::FaceInstance(const FaceInstance&)’:
brush/FaceInstance.h:28:32: warning: ‘FaceInstance::m_selectableEdges’ will be initialized after [-Wreorder]
  selection::ObservedSelectable m_selectableEdges;
                                ^~~~~~~~~~~~~~~~~
brush/FaceInstance.h:25:26: warning: ‘SelectionChangedSlot FaceInstance::m_selectionChanged’ [-Wreorder]
     SelectionChangedSlot m_selectionChanged;
                          ^~~~~~~~~~~~~~~~~~
brush/FaceInstance.cpp:38:1: warning: when initialized here [-Wreorder]
 FaceInstance::FaceInstance(const FaceInstance& other) :
 ^~~~~~~~~~~~
make[2]: Leaving directory '/home/harry/Builds/darkmod-build/darkradiant2-git/src/DarkRadiant-build/radiant'
Makefile:752: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/harry/Builds/darkmod-build/darkradiant2-git/src/DarkRadiant-build'
Makefile:493: recipe for target 'all' failed
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
Steps To ReproduceTry to compile from source. Always fails in the same spot.
TagsNo tags attached.

Activities

hNID

hNID

03.06.2016 14:17

reporter   ~0008194

Last edited: 03.06.2016 14:17

View 2 revisions

Just a note to let you know compilation is working again. Thanks, bug can be closed.

Issue History

Date Modified Username Field Change
03.06.2016 08:25 hNID New Issue
03.06.2016 12:11 greebo Priority high => normal
03.06.2016 12:11 greebo Severity block => normal
03.06.2016 12:11 greebo Status new => acknowledged
03.06.2016 12:11 greebo Product Version 2.0.3 => 2.0.4
03.06.2016 14:17 hNID Note Added: 0008194
03.06.2016 14:17 hNID Note Edited: 0008194 View Revisions
03.06.2016 16:19 greebo Assigned To => greebo
03.06.2016 16:19 greebo Status acknowledged => assigned
03.06.2016 16:20 greebo Target Version => 2.0.4
03.06.2016 16:20 greebo Status assigned => resolved
03.06.2016 16:20 greebo Fixed in Version => 2.0.4
03.06.2016 16:20 greebo Resolution open => fixed
01.01.2017 18:09 greebo Status resolved => closed