0004365: llvm/clang static source code analysis - The Dark Mod Bugtracker

ID	Project	Category	View Status	Date Submitted	Last Update

0004365	DarkRadiant	Design/Coding	public	25.08.2016 17:31	07.07.2017 18:51

Reporter	mhoes	Assigned To	greebo
Priority	normal	Severity	normal	Reproducibility	always
Status	closed	Resolution	fixed
Platform	PC	OS	Linux
Product Version	2.0.4
Target Version	2.1.0	Fixed in Version	2.1.0

Summary	0004365: llvm/clang static source code analysis
Description	Ive ran the clang [1] static source code analyzer [2] on the darkradiant codebase, and ran into a few issues. Besides the issues found that may possibly point in bugs in the code, I also got some failures. One of them is this error : error: invalid argument '-std=c++0x' not allowed with 'C/ObjC' Another one is the same thing that already was reported in bug 0003175 (which currently is closed) : 'boost::python::object' can actually refer to two different things, either namespace boost { namespace python { class object; } } or namespace boost { namespace python { namespace api { class object; } using api::object } } But there are more failures (and potential bugs) which might need to be investigated. For the time being, the full results can be found at my homepage [3]. Under the heading 'Results' somewhat at the top of the page the possible bugs are reported, and under the heading 'Analyzer Failures' are failures like the ones described above. I downloaded the latest code from the git repo [4] as described at the site [5]. [1] http://clang.llvm.org/ [2] http://clang-analyzer.llvm.org/ [3] https://home.kpn.nl/m.hoes73/scan-build/darkradiant/ [4] https://github.com/codereader/DarkRadiant.git [5] http://darkradiant.sourceforge.net/source.php
Tags	No tags attached.

greebo 22.09.2016 16:24 administrator ~0008340	Thanks!

greebo 29.10.2016 18:53 administrator ~0008403	I resolved most of the warnings in the report. Some of them were false positives though.

mhoes 30.10.2016 08:43 reporter ~0008407	Thanks ! I've moved the report over to this url, in order to make a comparison with a yet to generate new report to see the differences : https://home.kpn.nl/m.hoes73/scan-build/darkradiant-2016-08-16/ (for now however, Im prevented from doing so because Im running into a build error as I reported in bug 0004407 )

mhoes 06.11.2016 14:41 reporter ~0008445	Thanks again for looking into this ! I created a new report (located at the original location), and noticed that indeed most of the bug reports are gone now, and the remaining ones must be the false positives you mentioned. Great ! [Not sure if the 'analyzer failures' that are still present might still need to be looked into though, but Ill leave that up to the developers].

Date Modified	Username	Field	Change
25.08.2016 17:31	mhoes	New Issue
22.09.2016 16:24	greebo	Note Added: 0008340
22.09.2016 16:24	greebo	Status	new => acknowledged
29.10.2016 18:50	greebo	Assigned To	=> greebo
29.10.2016 18:50	greebo	Status	acknowledged => assigned
29.10.2016 18:52	greebo	Target Version	=> 2.1.0
29.10.2016 18:53	greebo	Note Added: 0008403
29.10.2016 18:53	greebo	Status	assigned => resolved
29.10.2016 18:53	greebo	Fixed in Version	=> 2.1.0
29.10.2016 18:53	greebo	Resolution	open => fixed
30.10.2016 08:43	mhoes	Note Added: 0008407
06.11.2016 14:41	mhoes	Note Added: 0008445
07.07.2017 18:51	greebo	Status	resolved => closed