View Issue Details

IDProjectCategoryView StatusLast Update
0004398The Dark ModSaving/Loadingpublic21.10.2016 19:51
Reportergrayman Assigned Tograyman  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionTDM 2.04 
Target VersionTDM 2.05Fixed in VersionTDM 2.05 
Summary0004398: Problem using multiple quicksaves and I18N
DescriptionFrom Woodsie69 ...

"I've just upgraded TDM v2-03 to v2-04 and I'm playing "PD 3: Erasing the Trail".
 
I've got f7 as "quicksave" and f9 as "quickload".
 
I can't figure out how the new system works, because when I press f7 the game is saved, and in the load/save menu the quicksave is saved as "hurtig gemning_0" (quick save in Danish), but when quickload is pressed nothing happens - because the game is trying to load "hurtig gemning", which doesn't exist. I know that because I renamed the quicksave from the in game menu and it loads fine without the underscore and zero in the very end of the quicksave file.
 
So the problem as I can see it is that TDM saves quicksaves as "hurtig gemning_0" and loads them as "hurtig gemning" (if it exists)
 
I've got the following entry in "Darkmod.cfg": seta com_numQuickSaves "2"
 
I'm using Linux Mint 17.3 64 bit (Ubuntu 14.04 under the hood), and it runs from the "darkmod" folder in my "/home" folder, which means no restriction in read/write."
Additional InformationMy test does this:

1 - Switch to Danish

2 - Save using quicksave

3 - Move somewhere else and save using quicksave

4 - Look at savegames in-game and the save/load menu only shows one quicksave: "Hurtig gemning_0". This is the second of my two quicksaves, so the second overwrote the first.

5 - Look at the savegame folder and it only contains "Hurtig gemning_0.save"

If I repeat the above steps in English, I get "Quicksave_0.save" and "Quicksave_1.save". No overwriting.

So it appears there's a problem saving multiple quicksaves under I18N

Also, switching languages mid-game is going to create a problem, because a quicksave is a quicksave is a quicksave, regardless of the language in use. If I do two quicksaves in Danish, and then two quicksaves in English, then I end up with 4 quicksaves in the savegames folder. What should happen is that the save/load code should look for savegame files that have language-independent filenames, so that if I save a game in Danish and switch to English, I can still load my Danish-saved savegame. That won't happen with the current code.
TagsNo tags attached.

Activities

grayman

grayman

21.10.2016 19:51

viewer   ~0008384

The issue was that "Quicksave" is a single word, but many translations change that to two words, i.e. in Danish it's "Hurtig gemning".

The quickload code wasn't accounting for the quicksave code having replaced the space in a multi-word string with "_". So the load code couldn't match "Hurtig gemning" with "Hurting_gemning".

Once it's all made consistent (always replace " " with "_" when dealing with quicksaves), it all works correctly.

Rev. 6636:

Session.cpp

------------------

I'm not dealing with the "Why are we translating 'Quicksave' issue for now. If it crops up in the future, we'll deal with it then. That's a bigger solution than we have time for atm.

  

Issue History

Date Modified Username Field Change
21.10.2016 00:22 grayman New Issue
21.10.2016 19:51 grayman Note Added: 0008384
21.10.2016 19:51 grayman Assigned To => grayman
21.10.2016 19:51 grayman Status new => resolved
21.10.2016 19:51 grayman Resolution open => fixed
21.10.2016 19:51 grayman Fixed in Version => TDM 2.05