View Issue Details

IDProjectCategoryView StatusLast Update
0004410DarkRadiantGeneralpublic07.07.2017 18:51
ReporterVanishedOne Assigned Togreebo  
Status closedResolutionfixed 
Product Version2.1.0 
Target Version2.1.0Fixed in Version2.1.0 
Summary0004410: Ring size being reset in particle editor
DescriptionIf I set a Ring Size of more than zero:

- it doesn't seem to be saved to the file (the in-game editParticles editor also fails to do this)
- if I switch to another particle definition after making the change, I'm not prompted to save
- when I switch back it's been reset to 0
Additional InformationThis is the particle def. (obviously it assumes you have a material called textures/particles/bubble):

particle bubbles_many_wide {
        count 100
        material textures/particles/bubble
        time 1.500
        cycles 0.000
        timeOffset 0.000
        bunching 1.000
        distribution sphere 8.000 8.000 8.000
        direction cone 10.000
        orientation view
        speed "100.000" to "150.000"
        size "2.000" to "4.000"
        aspect "1.000"
        rotation "0.000"
        randomDistribution 1
        boundsExpansion 0.000
        fadeIn 0.100
        fadeOut 0.250
        fadeIndex 0.000
        color 0.150 0.150 0.150 1.000
        fadeColor 0.000 0.000 0.000 0.000
        offset 0.000 0.000 0.000
        gravity 1.000
        entityColor 1
TagsNo tags attached.




01.11.2016 06:11

administrator   ~0008429

I've fixed the problem with the particle ring size getting lost when changing the particle def, and DR can detect now whether a particle has changed due to the ring size.

Though the ring size is not written to the .prt file if the distribution type is set to "sphere". I need to check the game code what's up with this.


01.11.2016 06:41

administrator   ~0008430

Ok, after checking the game sources, I can see that the particle def writer doesn't save the fourth "sphere" parameter to the .prt file, therefore the ring parameter is actually lost by the particle editor on saving.

On the other hand it's possible to define the fourth parameter by editing the .prt file manually, the game particle parser is able to deal with a variable number of parameters without throwing errors.

So the plan here is to add that flexibility to DR's particle def parser, and to write that fourth parameter to the .prt file.


01.11.2016 06:52

administrator   ~0008431

Ok, the parser was already prepared for the 4th parameter, so I merely had to make sure DarkRadiant is saving that ring size value to the .prt file.

Fixed in ecaaf5b481abd16f9c70448d43f2846da78c30ad

Issue History

Date Modified Username Field Change
01.11.2016 02:24 VanishedOne New Issue
01.11.2016 02:24 VanishedOne Status new => assigned
01.11.2016 02:24 VanishedOne Assigned To => greebo
01.11.2016 06:11 greebo Note Added: 0008429
01.11.2016 06:41 greebo Note Added: 0008430
01.11.2016 06:52 greebo Note Added: 0008431
01.11.2016 06:52 greebo Status assigned => resolved
01.11.2016 06:52 greebo Fixed in Version => 2.1.0
01.11.2016 06:52 greebo Resolution open => fixed
01.11.2016 06:52 greebo Target Version => 2.1.0
07.07.2017 18:51 greebo Status resolved => closed