View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004562 | DarkRadiant | Compilation/Build | public | 11.07.2017 13:11 | 23.07.2017 15:01 |
| Reporter | mhoes | Assigned To | |||
| Priority | normal | Severity | normal | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Platform | PC | OS | Linux | OS Version | Fedora 26 |
| Product Version | 2.2.1 | ||||
| Summary | 0004562: Autotools generated files tracked by git ? | ||||
| Description | Hi, I am not 100% sure but it looks like (at least) the following files are created automatically by autogen.sh and configure (which gets created by autogen.sh itself), and therefore should not be tracked by git, and added to '.gitignore' instead ? aclocal.m4 configure ltmain.sh Makefile.in Because I now get the following error when running 'git pull' (and I didn't edit any of these files myself explicitly/manually) : error: Your local changes to the following files would be overwritten by merge: Makefile.in aclocal.m4 configure libs/Makefile.in libs/ddslib/Makefile.in libs/math/Makefile.in libs/picomodel/Makefile.in libs/scene/Makefile.in libs/wxutil/Makefile.in libs/xmlutil/Makefile.in ltmain.sh plugins/Makefile.in plugins/archivezip/Makefile.in plugins/commandsystem/Makefile.in plugins/dm.conversation/Makefile.in plugins/dm.difficulty/Makefile.in plugins/dm.editing/Makefile.in plugins/dm.gui/Makefile.in plugins/dm.objectives/Makefile.in plugins/dm.stimresponse/Makefile.in plugins/eclassmgr/Makefile.in plugins/eclasstree/Makefile.in plugins/entity/Makefile.in plugins/entitylist/Makefile.in plugins/eventmanager/Makefile.in plugins/filetypes/Makefile.in plugins/filters/Makefile.in plugins/fonts/Makefile.in plugins/image/Makefile.in plugins/mapdoom3/Makefile.in plugins/md5model/Makefile.in plugins/model/Makefile.in plugins/particles/Makefile.in plugins/scenegraph/Makefile.in plugins/script/Makefile.in plugins/shaders/Makefile.in plugins/skins/Makefile.in plugins/sound/Makefile.in plugins/uimanager/Makefile.in plugins/undo/Makefile.in plugins/vfspk3/Makefile.in plugins/xmlregistry/Makefile.in radiant/Makefile.in | ||||
| Steps To Reproduce | $ ./autogen.sh $ ./configure - wait for new commit in the git repo - $ git pull | ||||
| Additional Information | There may be more autotools generated files that also should also not be tracked by git, but am not as sure of these as the ones listed above in the error message (and there may still be more) : compile config.guess config.h config.h.in config.log config.status config.cache config.sub depcomp install-sh libtool m4/ missing | ||||
| Tags | No tags attached. | ||||
|
Incidentally, I've removed most of those autotools-generated file from Git (as of 5d4b8d). I might be wrong, but I think the git pull error is due to the fact that these files are now on the .gitignore list. Can you clean your working copy and try pulling again? I don't think that the error will popup again, once you have pulled in the new .gitignore list. |
|
|
I removed my old cloned repo, and did a fresh 'git clone'. commit 2f8a5732ee4ed3c89281341bded3c15cbcc548ee. I did a 'autogen.sh/configure/make', and when the next commit comes I will try a new 'git pull' to see if the error is now gone. I checked out the .gitignore in the freshly cloned repo, but not all the files I mentioned seem to be in there ? In fact, the .gitignore seems to be exactly the same as before ? And I may be wrong, but I thought that the whole purpose of the .gitignore file was that the files that are listed in there are *not* tracked/watched by git anymore, so it doesnt matter if these are in your repo and what version (modified or not) they are when you 'pull' (or 'commit', for that matter) ? Oh, well. I'm not an expert here. I will let you know how it goes the next time I do a 'git pull'. |
|
|
Your .gitignore file looking unchanged appears strange to me, I definitely added stuff to the ignore list, see this commit: https://github.com/codereader/DarkRadiant/commit/5d4b8d87ceb465eea03b0af356237d63ea6a9f36 |
|
|
With respect to my '.gitignore' file, I seem to have made a mistake; it appears exactly the same as the one in the git repo. Sorry for that. Anyway, I did an 'autogen.sh/configure/make', followed by a 'git pull' to get the latest commits, and do not receive the error any more. Which means that this issue can be closed. Thanks for looking into it, and fixing the issue. |
|
| Ok, thanks | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 11.07.2017 13:11 | mhoes | New Issue | |
| 12.07.2017 13:51 | greebo | Note Added: 0008981 | |
| 12.07.2017 13:51 | greebo | Status | new => feedback |
| 12.07.2017 14:12 | mhoes | Note Added: 0008982 | |
| 12.07.2017 14:12 | mhoes | Status | feedback => new |
| 12.07.2017 14:14 | greebo | Note Added: 0008983 | |
| 12.07.2017 14:15 | greebo | Status | new => feedback |
| 23.07.2017 11:56 | mhoes | Note Added: 0009030 | |
| 23.07.2017 11:56 | mhoes | Status | feedback => new |
| 23.07.2017 15:01 | greebo | Note Added: 0009031 | |
| 23.07.2017 15:01 | greebo | Status | new => closed |
| 23.07.2017 15:01 | greebo | Resolution | open => no change required |