View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004733DarkRadiantCompilation/Buildpublic16.01.2018 21:5228.12.2019 11:00
Reportercoldtobi Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
Product Version2.5.0 
Fixed in Version2.6.0 
Summary0004733: linking of testsuite with boost unit test framework fails
DescriptionWhen building the new version 2.5.0 for Debian, the testsuite fails to link:

Making check in math
make[2]: Entering directory '/home/tobi/workspace/deb/packages/darkradiant/darkradiant/libs/math'
make vectorTest matrixTest quaternionTest planeTest
make[3]: Entering directory '/home/tobi/workspace/deb/packages/darkradiant/darkradiant/libs/math'
/bin/bash ../../libtool --tag=CXX --mode=link g++ -fPIC -g -O2 -DNDEBUG -g -O2 -fdebug-prefix-map=/home/tobi/workspace/deb/packages/darkradiant/darkradiant=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -Wall -Wno-unused-variable -Werror=return-type -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -lsigc-2.0 -o vectorTest test/vectorTest.o
libtool: link: g++ -fPIC -g -O2 -DNDEBUG -g -O2 -fdebug-prefix-map=/home/tobi/workspace/deb/packages/darkradiant/darkradiant=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -Wall -Wno-unused-variable -Werror=return-type -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o vectorTest test/vectorTest.o -lsigc-2.0
test/vectorTest.o: In function `init_unit_test()':
/usr/include/boost/test/unit_test_suite.hpp:346: undefined reference to `boost::unit_test::framework::master_test_suite()'
test/vectorTest.o: In function `constructVector3::test_method()':

Looking into it, $(BOOST_UNIT_TEST_FRAMEWORK_LIBS) is empty.

Fix is to add
BOOST_TEST
to configure.ac, as per attached patch
(note that the patch does do that uncoditionally)
TagsNo tags attached.
Attached Files
01_autoconf_boost_test_framework.patch (566 bytes)    
Description: determeine boost's testframework library
 The tests needs to link to the boost's testframework library, so we need to
 look for them in configure.ac and set the resp. macros
Author: Tobias Frost <tobi@debian.org>
Forwarded: <URL|no|not-needed, useless if you have a Bug field, optional>
Last-Update: 2018-01-16
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/configure.ac
+++ b/configure.ac
@@ -198,6 +198,8 @@
 
 AC_SUBST([FILESYSTEM_LIBS])
 
+BOOST_TEST
+
 # PyBind11 if required
 if test "$python_scripting" = 'yes'
 then
01_autoconf_boost_test_framework.patch (566 bytes)   

Activities

greebo

greebo

18.04.2018 09:31

administrator   ~0010381

I must admit I've been unaware of the "make check" command up until now. I only ever ran "make" and "make install" which doesn't fail.

I'm unsure about what to do with these math test routines. Since boost is not used as dependency anymore, I'm hesitant to add that back just for the few tests we have. Migrating to another testing framework is not what triggering my motivation, so at the moment I'd rather disable the test setup in libs/math/Makefile.am.
greebo

greebo

18.04.2018 10:02

administrator   ~0010384

Took out the math tests in 1fbc36618200d7d9fa5dabc0fb482250801d2ec1

Issue History

Date Modified Username Field Change
16.01.2018 21:52 coldtobi New Issue
16.01.2018 21:52 coldtobi File Added: 01_autoconf_boost_test_framework.patch
17.01.2018 15:55 greebo Status new => acknowledged
18.04.2018 09:31 greebo Note Added: 0010381
18.04.2018 09:31 greebo Status acknowledged => confirmed
18.04.2018 10:02 greebo Note Added: 0010384
18.04.2018 10:02 greebo Status confirmed => resolved
18.04.2018 10:02 greebo Fixed in Version => 2.6.0
18.04.2018 10:02 greebo Resolution open => fixed
18.04.2018 10:02 greebo Assigned To => greebo
28.12.2019 11:00 greebo Status resolved => closed