| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004747 | DarkRadiant | Map Editing | public | 05.03.2018 22:25 | 09.01.2020 19:25 |
| Reporter | illwieckz | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86_64 | OS | Ubuntu | OS Version | 17.4 |
| Product Version | 2.3.0 | ||||
| Target Version | 2.6.0 | Fixed in Version | 2.6.0 | ||
| Summary | 0004747: CSG Make Room operator does not fill the room on 3-edge prism case | ||||
| Description | When applying the CSG Make Room operation on a 3-sided prism, the inner faces of the generated brushes are too small. And with other prism, it's just very ugly because brushes are intersecting themselves. In fact current code only works correctly with cubes. | ||||
| Steps To Reproduce | - create a Brush and keep it selected - menu Brush → Prism - enter 3 Sides - apply the CSG Make Room operation You can now move your camera within the prism to see the room is not closed Reproduce the step with a number of side greater than 4 and you'll see how the brush are mixing themselves. | ||||
| Additional Information | GtkRadiant similar operation (named “CSG Hollow Touch”) produces very nice brushes, but their code looks less abstracted an more low level and I don't understand what they do though: https://github.com/TTimo/GtkRadiant/blob/c968f9c87a4026a35d4fa1dc6b680394f6aea477/radiant/csg.cpp#L45-L84 I guess a possible solution would be to resize after operation the inner face of each side-brush to the original size of the initial face of the initial brush to ensure the inner volume is always closed. If I understand things right, It must be enough to do that resize after transformation just there: https://github.com/codereader/DarkRadiant/blob/53428a2b446acd537f8173491c9df00533088943/radiant/brush/csg/CSG.cpp#L71-L76 By the way this kind of geometric compute seems to be beyond my knowledge. | ||||
| Tags | No tags attached. | ||||
 |
I joined two ready-to-reproduce maps with quake3 and quake4 format: just select a prism and apply “CSG Make Room” operation on it. I joined 2 screenshots, one showing a correct result after operation on GtkRadiant, one showing wrong result after operation on DarkRadiant. |
|
|
See https://github.com/codereader/DarkRadiant/pull/6 for a PR implementing a better algorithm. |
 |
Thank you for the fix! |
