View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004754 | The Dark Mod | GUI | public | 19.03.2018 16:10 | 28.06.2018 08:18 |
Reporter | Assigned To | stgatilov | |||
Priority | normal | Severity | crash | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | PC, Windows, x64 | OS | Win 7/8 | OS Version | Sp2/8.1 |
Product Version | TDM 2.06 | ||||
Target Version | TDM 2.06 | Fixed in Version | TDM 2.06 | ||
Summary | 0004754: Minimizing Windows TDM: causes a crash | ||||
Description | Run TDM in a window, then minimize and maximise and it crashes, see attached. | ||||
Tags | No tags attached. | ||||
Attached Files | RenderSystem.cpp (26,486 bytes)
/***************************************************************************** The Dark Mod GPL Source Code This file is part of the The Dark Mod Source Code, originally based on the Doom 3 GPL Source Code as published in 2011. The Dark Mod Source Code is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. For details, see LICENSE.TXT. Project: The Dark Mod (http://www.thedarkmod.com/) ******************************************************************************/ #include "precompiled.h" #pragma hdrstop #include "tr_local.h" idRenderSystemLocal tr; idRenderSystem *renderSystem = &tr; /* ===================== R_PerformanceCounters This prints both front and back end counters, so it should only be called when the back end thread is idle. ===================== */ static void R_PerformanceCounters( void ) { if ( r_showPrimitives.GetInteger() != 0 ) { float megaBytes = globalImages->SumOfUsedImages() / ( 1024*1024.0 ); if ( r_showPrimitives.GetInteger() > 1 ) { common->Printf( "v:%i ds:%i t:%i/%i v:%i/%i st:%i sv:%i image:%5.1f MB\n", tr.pc.c_numViews, backEnd.pc.c_drawElements + backEnd.pc.c_shadowElements, backEnd.pc.c_drawIndexes / 3, ( backEnd.pc.c_drawIndexes - backEnd.pc.c_drawRefIndexes ) / 3, backEnd.pc.c_drawVertexes, ( backEnd.pc.c_drawVertexes - backEnd.pc.c_drawRefVertexes ), backEnd.pc.c_shadowIndexes / 3, backEnd.pc.c_shadowVertexes, megaBytes ); } else { common->Printf( "views:%i draws:%i tris:%i (shdw:%i) (vbo:%i) image:%5.1f MB\n", tr.pc.c_numViews, backEnd.pc.c_drawElements + backEnd.pc.c_shadowElements, ( backEnd.pc.c_drawIndexes + backEnd.pc.c_shadowIndexes ) / 3, backEnd.pc.c_shadowIndexes / 3, backEnd.pc.c_vboIndexes / 3, megaBytes ); } } if ( r_showDynamic.GetBool() ) { common->Printf( "callback:%i md5:%i dfrmVerts:%i dfrmTris:%i tangTris:%i guis:%i\n", tr.pc.c_entityDefCallbacks, tr.pc.c_generateMd5, tr.pc.c_deformedVerts, tr.pc.c_deformedIndexes/3, tr.pc.c_tangentIndexes/3, tr.pc.c_guiSurfs ); } if ( r_showCull.GetBool() ) { common->Printf( "%i sin %i sclip %i sout %i bin %i bout\n", tr.pc.c_sphere_cull_in, tr.pc.c_sphere_cull_clip, tr.pc.c_sphere_cull_out, tr.pc.c_box_cull_in, tr.pc.c_box_cull_out ); } if ( r_showAlloc.GetBool() ) { common->Printf( "alloc:%i free:%i\n", tr.pc.c_alloc, tr.pc.c_free ); } if ( r_showInteractions.GetBool() ) { common->Printf( "createInteractions:%i createLightTris:%i createShadowVolumes:%i\n", tr.pc.c_createInteractions, tr.pc.c_createLightTris, tr.pc.c_createShadowVolumes ); } if ( r_showDefs.GetBool() ) { common->Printf( "viewEntities:%i shadowEntities:%i viewLights:%i\n", tr.pc.c_visibleViewEntities, tr.pc.c_shadowViewEntities, tr.pc.c_viewLights ); } if ( r_showUpdates.GetBool() ) { common->Printf( "entityUpdates:%i entityRefs:%i lightUpdates:%i lightRefs:%i\n", tr.pc.c_entityUpdates, tr.pc.c_entityReferences, tr.pc.c_lightUpdates, tr.pc.c_lightReferences ); } if ( r_showMemory.GetBool() ) { int m0 = frameData ? frameData->frameMemoryAllocated.load() : 0; int m1 = frameData ? frameData->memoryHighwater : 0; common->Printf( "frameData: %i (%i)\n", m0, m1 ); } memset( &tr.pc, 0, sizeof( tr.pc ) ); memset( &backEnd.pc, 0, sizeof( backEnd.pc ) ); } /* ==================== R_IssueRenderCommands Called by R_EndFrame each frame ==================== */ static void R_IssueRenderCommands( frameData_t *frameData ) { emptyCommand_t *cmds = frameData->cmdHead; if ( cmds->commandId == RC_NOP && !cmds->next ) { // nothing to issue return; } // r_skipBackEnd allows the entire time of the back end // to be removed from performance measurements, although // nothing will be drawn to the screen. If the prints // are going to a file, or r_skipBackEnd is later disabled, // usefull data can be received. // r_skipRender is usually more usefull, because it will still // draw 2D graphics if ( !r_skipBackEnd.GetBool() ) { RB_ExecuteBackEndCommands( cmds ); } R_ClearCommandChain( frameData ); } /* ============ R_GetCommandBuffer Returns memory for a command buffer (stretchPicCommand_t, drawSurfsCommand_t, etc) and links it to the end of the current command chain. ============ */ void *R_GetCommandBuffer( int bytes ) { emptyCommand_t *cmd; cmd = (emptyCommand_t *)R_FrameAlloc( bytes ); cmd->next = NULL; frameData->cmdTail->next = &cmd->commandId; frameData->cmdTail = cmd; return (void *)cmd; } /* ==================== R_ClearCommandChain Called after every buffer submission and by R_ToggleSmpFrame ==================== */ void R_ClearCommandChain( frameData_t *frameData ) { // clear the command chain frameData->cmdHead = frameData->cmdTail = (emptyCommand_t *)R_FrameAlloc( sizeof( *frameData->cmdHead ) ); frameData->cmdHead->commandId = RC_NOP; frameData->cmdHead->next = NULL; } /* ================= R_ViewStatistics ================= */ static void R_ViewStatistics( viewDef_t &parms ) { // report statistics about this view if ( !r_showSurfaces.GetBool() ) { return; } common->Printf( "view:%p surfs:%i\n", parms, parms.numDrawSurfs ); } /* ============= R_AddDrawViewCmd This is the main 3D rendering command. A single scene may have multiple views if a mirror, portal, or dynamic texture is present. ============= */ void R_AddDrawViewCmd( viewDef_t &parms ) { drawSurfsCommand_t *cmd; cmd = (drawSurfsCommand_t *)R_GetCommandBuffer( sizeof( *cmd ) ); cmd->commandId = RC_DRAW_VIEW; cmd->viewDef = &parms; if ( parms.viewEntitys ) { // save the command for r_lockSurfaces debugging tr.lockSurfacesCmd = *cmd; } tr.pc.c_numViews++; R_ViewStatistics( parms ); } //================================================================================= /* ====================== R_LockSurfaceScene r_lockSurfaces allows a developer to move around without changing the composition of the scene, including culling. The only thing that is modified is the view position and axis, no front end work is done at all Add the stored off command again, so the new rendering will use EXACTLY the same surfaces, including all the culling, even though the transformation matricies have been changed. This allow the culling tightness to be evaluated interactively. ====================== */ void R_LockSurfaceScene( viewDef_t &parms ) { drawSurfsCommand_t *cmd; viewEntity_t *vModel; // set the matrix for world space to eye space R_SetViewMatrix( parms ); tr.lockSurfacesCmd.viewDef->worldSpace = parms.worldSpace; // update the view origin and axis, and all // the entity matricies for( vModel = tr.lockSurfacesCmd.viewDef->viewEntitys ; vModel ; vModel = vModel->next ) { myGlMultMatrix( vModel->modelMatrix, tr.lockSurfacesCmd.viewDef->worldSpace.modelViewMatrix, vModel->modelViewMatrix ); } // add the stored off surface commands again cmd = (drawSurfsCommand_t *)R_GetCommandBuffer( sizeof( *cmd ) ); *cmd = tr.lockSurfacesCmd; } /* ============= R_CheckCvars See if some cvars that we watch have changed ============= */ static void R_CheckCvars( void ) { globalImages->CheckCvars(); // gamma stuff if ( r_gamma.IsModified() || r_brightness.IsModified() ) { r_gamma.ClearModified(); r_brightness.ClearModified(); R_SetColorMappings(); } // check for changes to logging state GLimp_EnableLogging( r_logFile.GetInteger() != 0 ); } /* ============= idRenderSystemLocal::idRenderSystemLocal ============= */ idRenderSystemLocal::idRenderSystemLocal( void ) { Clear(); } /* ============= idRenderSystemLocal::~idRenderSystemLocal ============= */ idRenderSystemLocal::~idRenderSystemLocal( void ) { // #4395: Duzenko lightem pixel pack buffer optimization /*if (pbo && qglDeleteBuffersARB) // crashes on linux, never called on windows, needs to be moved to a better place or removed at all qglDeleteBuffersARB(1, &pbo);*/ } /* ============= SetColor This can be used to pass general information to the current material, not just colors ============= */ void idRenderSystemLocal::SetColor( const idVec4 &rgba ) { guiModel->SetColor( rgba[0], rgba[1], rgba[2], rgba[3] ); } /* ============= SetColor4 ============= */ void idRenderSystemLocal::SetColor4( float r, float g, float b, float a ) { guiModel->SetColor( r, g, b, a ); } /* ============= DrawStretchPic ============= */ void idRenderSystemLocal::DrawStretchPic( const idDrawVert *verts, const glIndex_t *indexes, int vertCount, int indexCount, const idMaterial *material, bool clip, float min_x, float min_y, float max_x, float max_y ) { guiModel->DrawStretchPic( verts, indexes, vertCount, indexCount, material, clip, min_x, min_y, max_x, max_y ); } /* ============= DrawStretchPic x/y/w/h are in the 0,0 to 640,480 range ============= */ void idRenderSystemLocal::DrawStretchPic( float x, float y, float w, float h, float s1, float t1, float s2, float t2, const idMaterial *material ) { guiModel->DrawStretchPic( x, y, w, h, s1, t1, s2, t2, material ); } /* ============= DrawStretchTri x/y/w/h are in the 0,0 to 640,480 range ============= */ void idRenderSystemLocal::DrawStretchTri( idVec2 p1, idVec2 p2, idVec2 p3, idVec2 t1, idVec2 t2, idVec2 t3, const idMaterial *material ) { tr.guiModel->DrawStretchTri( p1, p2, p3, t1, t2, t3, material ); } /* ============= GlobalToNormalizedDeviceCoordinates ============= */ void idRenderSystemLocal::GlobalToNormalizedDeviceCoordinates( const idVec3 &global, idVec3 &ndc ) { R_GlobalToNormalizedDeviceCoordinates( global, ndc ); } /* ============= GlobalToNormalizedDeviceCoordinates ============= */ void idRenderSystemLocal::GetGLSettings( int& width, int& height ) { width = glConfig.vidWidth; height = glConfig.vidHeight; } /* ===================== idRenderSystemLocal::DrawSmallChar small chars are drawn at native screen resolution ===================== */ void idRenderSystemLocal::DrawSmallChar( int x, int y, int ch, const idMaterial *material ) { int row, col; float frow, fcol; float size; ch &= 255; if ( ch == ' ' ) { return; } if ( y < -SMALLCHAR_HEIGHT ) { return; } row = ch >> 4; col = ch & 15; frow = row * 0.0625f; fcol = col * 0.0625f; size = 0.0625f; DrawStretchPic( x, y, SMALLCHAR_WIDTH, SMALLCHAR_HEIGHT, fcol, frow, fcol + size, frow + size, material ); } /* ================== idRenderSystemLocal::DrawSmallString[Color] Draws a multi-colored string with a drop shadow, optionally forcing to a fixed color. Coordinates are at 640 by 480 virtual resolution ================== */ void idRenderSystemLocal::DrawSmallStringExt( int x, int y, const char *string, const idVec4 &setColor, bool forceColor, const idMaterial *material ) { idVec4 color; const unsigned char *s; int xx; // draw the colored text s = (const unsigned char*)string; xx = x; SetColor( setColor ); while ( *s ) { if ( idStr::IsColor( (const char*)s ) ) { if ( !forceColor ) { if ( *(s+1) == C_COLOR_DEFAULT ) { SetColor( setColor ); } else { color = idStr::ColorForIndex( *(s+1) ); color[3] = setColor[3]; SetColor( color ); } } s += 2; continue; } DrawSmallChar( xx, y, *s, material ); xx += SMALLCHAR_WIDTH; s++; } SetColor( colorWhite ); } /* ===================== idRenderSystemLocal::DrawBigChar ===================== */ void idRenderSystemLocal::DrawBigChar( int x, int y, int ch, const idMaterial *material ) { int row, col; float frow, fcol; float size; ch &= 255; if ( ch == ' ' ) { return; } if ( y < -BIGCHAR_HEIGHT ) { return; } row = ch >> 4; col = ch & 15; frow = row * 0.0625f; fcol = col * 0.0625f; size = 0.0625f; DrawStretchPic( x, y, BIGCHAR_WIDTH, BIGCHAR_HEIGHT, fcol, frow, fcol + size, frow + size, material ); } /* ================== idRenderSystemLocal::DrawBigString[Color] Draws a multi-colored string with a drop shadow, optionally forcing to a fixed color. Coordinates are at 640 by 480 virtual resolution ================== */ void idRenderSystemLocal::DrawBigStringExt( int x, int y, const char *string, const idVec4 &setColor, bool forceColor, const idMaterial *material ) { idVec4 color; const char *s; int xx; // draw the colored text s = string; xx = x; SetColor( setColor ); while ( *s ) { if ( idStr::IsColor( s ) ) { if ( !forceColor ) { if ( *(s+1) == C_COLOR_DEFAULT ) { SetColor( setColor ); } else { color = idStr::ColorForIndex( *(s+1) ); color[3] = setColor[3]; SetColor( color ); } } s += 2; continue; } DrawBigChar( xx, y, *s, material ); xx += BIGCHAR_WIDTH; s++; } SetColor( colorWhite ); } //====================================================================================== /* ==================== BeginFrame ==================== */ void idRenderSystemLocal::BeginFrame( int windowWidth, int windowHeight ) { setBufferCommand_t *cmd; if ( !glConfig.isInitialized ) { return; } // determine which back end we will use //SetBackEndRenderer(); guiModel->Clear(); // for the larger-than-window tiled rendering screenshots if ( tiledViewport[0] ) { windowWidth = tiledViewport[0]; windowHeight = tiledViewport[1]; } glConfig.vidWidth = windowWidth; glConfig.vidHeight = windowHeight; renderCrops[0].x = 0; renderCrops[0].y = 0; if (r_useFbo.GetBool()) { // duzenko #4425: allow virtual resolution renderCrops[0].width = windowWidth*r_fboResolution.GetFloat(); renderCrops[0].height = windowHeight*r_fboResolution.GetFloat(); } else { renderCrops[0].width = windowWidth; renderCrops[0].height = windowHeight; } currentRenderCrop = 0; // screenFraction is just for quickly testing fill rate limitations if ( r_screenFraction.GetInteger() != 100 ) { int w = SCREEN_WIDTH * r_screenFraction.GetInteger() / 100.0f; int h = SCREEN_HEIGHT * r_screenFraction.GetInteger() / 100.0f; CropRenderSize( w, h ); } // this is the ONLY place this is modified frameCount++; // just in case we did a common->Error while this // was set guiRecursionLevel = 0; // the first rendering will be used for commands like // screenshot, rather than a possible subsequent remote // or mirror render // primaryWorld = NULL; // set the time for shader effects in 2D rendering frameShaderTime = eventLoop->Milliseconds() * 0.001; // // draw buffer stuff // cmd = (setBufferCommand_t *)R_GetCommandBuffer( sizeof( *cmd ) ); cmd->commandId = RC_SET_BUFFER; cmd->frameCount = frameCount; if ( r_frontBuffer.GetBool() ) { cmd->buffer = (int)GL_FRONT; } else { cmd->buffer = (int)GL_BACK; } } void idRenderSystemLocal::WriteDemoPics() { session->writeDemo->WriteInt( DS_RENDER ); session->writeDemo->WriteInt( DC_GUI_MODEL ); guiModel->WriteToDemo( session->writeDemo ); } void idRenderSystemLocal::DrawDemoPics() { demoGuiModel->EmitFullScreen(); } /* ============= EndFrame Returns the number of msec spent in the back end ============= */ void idRenderSystemLocal::EndFrame( int *frontEndMsec, int *backEndMsec ) { static idFile* logFile = nullptr; if ( !glConfig.isInitialized ) { return; } int startLoop = Sys_Milliseconds(); session->ActivateFrontend(); int endSignal = Sys_Milliseconds(); // start the back end up again with the new command list R_IssueRenderCommands( backendFrameData ); int endRender = Sys_Milliseconds(); session->WaitForFrontendCompletion(); int endWait = Sys_Milliseconds(); if( r_logSmpTimings.GetBool() ) { if( !logFile ) { logFile = fileSystem->OpenFileWrite( "backend_timings.txt", "fs_savepath", "" ); } int signalFrontend = endSignal - startLoop; int render = endRender - endSignal; int waitForFrontend = endWait - endRender; logFile->Printf( "Backend timing: signal %d - render %d - wait %d | begin %d - end %d\n", signalFrontend, render, waitForFrontend, startLoop, endWait ); } // check for dynamic changes that require some initialization R_CheckCvars(); #ifdef DEBUG // check for errors GL_CheckErrors(); #endif // use the other buffers next frame, because another CPU // may still be rendering into the current buffers R_ToggleSmpFrame(); // we can now release the vertexes used this frame vertexCache.EndFrame(); if ( session->writeDemo ) { session->writeDemo->WriteInt( DS_RENDER ); session->writeDemo->WriteInt( DC_END_FRAME ); if ( r_showDemo.GetBool() ) { common->Printf( "write DC_END_FRAME\n" ); } } // save out timing information if (frontEndMsec) { *frontEndMsec = pc.frontEndMsec; } if (backEndMsec) { *backEndMsec = backEnd.pc.msec; } // print any other statistics and clear all of them R_PerformanceCounters(); } /* ===================== RenderViewToViewport Converts from SCREEN_WIDTH / SCREEN_HEIGHT coordinates to current cropped pixel coordinates ===================== */ void idRenderSystemLocal::RenderViewToViewport( const renderView_t &renderView, idScreenRect &viewport ) { renderCrop_t &rc = renderCrops[currentRenderCrop]; float wRatio = (float) rc.width / SCREEN_WIDTH; float hRatio = (float) rc.height / SCREEN_HEIGHT; viewport.x1 = idMath::Ftoi( rc.x + renderView.x * wRatio ); viewport.x2 = idMath::Ftoi( rc.x + floor( ( renderView.x + renderView.width ) * wRatio + 0.5f ) - 1 ); viewport.y1 = idMath::Ftoi( ( rc.y + rc.height ) - floor( ( renderView.y + renderView.height ) * hRatio + 0.5f ) ); viewport.y2 = idMath::Ftoi( ( rc.y + rc.height ) - floor( renderView.y * hRatio + 0.5f ) - 1 ); } static int RoundDownToPowerOfTwo( int v ) { int i; for ( i = 0 ; i < 20 ; i++ ) { if ( ( 1 << i ) == v ) { return v; } if ( ( 1 << i ) > v ) { return 1 << ( i-1 ); } } return 1<<i; } /* ================ CropRenderSize This automatically halves sizes until it fits in the current window size, so if you specify a power of two size for a texture copy, it may be shrunk down, but still valid. ================ */ void idRenderSystemLocal::CropRenderSize( int width, int height, bool makePowerOfTwo, bool forceDimensions ) { if ( !glConfig.isInitialized ) { return; } // close any gui drawing before changing the size guiModel->EmitFullScreen(); guiModel->Clear(); if ( width < 1 || height < 1 ) { common->Error( "CropRenderSize: bad sizes" ); } if ( session->writeDemo ) { session->writeDemo->WriteInt( DS_RENDER ); session->writeDemo->WriteInt( DC_CROP_RENDER ); session->writeDemo->WriteInt( width ); session->writeDemo->WriteInt( height ); session->writeDemo->WriteInt( makePowerOfTwo ); if ( r_showDemo.GetBool() ) { common->Printf( "write DC_CROP_RENDER\n" ); } } // convert from virtual SCREEN_WIDTH/SCREEN_HEIGHT coordinates to physical OpenGL pixels renderView_t renderView; renderView.x = 0; renderView.y = 0; renderView.width = width; renderView.height = height; idScreenRect r; RenderViewToViewport( renderView, r ); width = r.x2 - r.x1 + 1; height = r.y2 - r.y1 + 1; if ( forceDimensions ) { // just give exactly what we ask for width = renderView.width; height = renderView.height; } // if makePowerOfTwo, drop to next lower power of two after scaling to physical pixels if ( makePowerOfTwo ) { width = RoundDownToPowerOfTwo( width ); height = RoundDownToPowerOfTwo( height ); // FIXME: megascreenshots with offset viewports don't work right with this yet } renderCrop_t *rc = &renderCrops[currentRenderCrop]; // we might want to clip these to the crop window instead while ( width > glConfig.vidWidth ) { width >>= 1; } while ( height > glConfig.vidHeight ) { height >>= 1; } if ( currentRenderCrop == MAX_RENDER_CROPS ) { common->Error( "idRenderSystemLocal::CropRenderSize: currentRenderCrop == MAX_RENDER_CROPS" ); } currentRenderCrop++; rc = &renderCrops[currentRenderCrop]; rc->x = 0; rc->y = 0; rc->width = width; rc->height = height; } void idRenderSystemLocal::GetCurrentRenderCropSize(int& width, int& height) { renderCrop_t* rc = &renderCrops[currentRenderCrop]; width = rc->width; height = rc->height; } /* ================ UnCrop ================ */ void idRenderSystemLocal::UnCrop() { if ( !glConfig.isInitialized ) { return; } if ( currentRenderCrop < 1 ) { common->Error( "idRenderSystemLocal::UnCrop: currentRenderCrop < 1" ); } // close any gui drawing guiModel->EmitFullScreen(); guiModel->Clear(); currentRenderCrop--; if ( session->writeDemo ) { session->writeDemo->WriteInt( DS_RENDER ); session->writeDemo->WriteInt( DC_UNCROP_RENDER ); if ( r_showDemo.GetBool() ) { common->Printf( "write DC_UNCROP\n" ); } } } /* ================ CaptureRenderToImage ================ */ void idRenderSystemLocal::CaptureRenderToImage( const char *imageName ) { if ( !glConfig.isInitialized ) { return; } guiModel->EmitFullScreen(); guiModel->Clear(); if ( session->writeDemo ) { session->writeDemo->WriteInt( DS_RENDER ); session->writeDemo->WriteInt( DC_CAPTURE_RENDER ); session->writeDemo->WriteHashString( imageName ); if ( r_showDemo.GetBool() ) { common->Printf( "write DC_CAPTURE_RENDER: %s\n", imageName ); } } // look up the image before we create the render command, because it // may need to sync to create the image idImage *image = globalImages->ImageFromFile(imageName, TF_DEFAULT, true, TR_REPEAT, TD_DEFAULT); renderCrop_t *rc = &renderCrops[currentRenderCrop]; copyRenderCommand_t *cmd = (copyRenderCommand_t *)R_GetCommandBuffer( sizeof( *cmd ) ); cmd->commandId = RC_COPY_RENDER; cmd->x = rc->x; cmd->y = rc->y; cmd->imageWidth = rc->width; cmd->imageHeight = rc->height; cmd->image = image; guiModel->Clear(); } /* ============== CaptureRenderToFile ============== */ void idRenderSystemLocal::CaptureRenderToFile( const char *fileName, bool fixAlpha ) { if ( !glConfig.isInitialized ) { return; } renderCrop_t *rc = &renderCrops[currentRenderCrop]; guiModel->EmitFullScreen(); guiModel->Clear(); R_IssueRenderCommands( frameData ); if (!r_useFbo.GetBool()) // duzenko #4425: not applicable, raises gl errors qglReadBuffer(GL_BACK); // calculate pitch of buffer that will be returned by qglReadPixels() int alignment; qglGetIntegerv(GL_PACK_ALIGNMENT, &alignment); int pitch = rc->width * 4 + alignment - 1; pitch = pitch - pitch % alignment; byte *data = (byte *)R_StaticAlloc( pitch * rc->height ); // GL_RGBA/GL_UNSIGNED_BYTE seems to be the safest option qglReadPixels( rc->x, rc->y, rc->width, rc->height, GL_RGBA, GL_UNSIGNED_BYTE, data ); byte *data2 = (byte *)R_StaticAlloc( rc->width * rc->height * 4 ); for ( int y = 0 ; y < rc->height ; y++ ) { for ( int x = 0 ; x < rc->width ; x++ ) { int idx = y * pitch + x * 4; int idx2 = (y * rc->width + x) * 4; data2[ idx2 + 0 ] = data[ idx + 0 ]; data2[ idx2 + 1 ] = data[ idx + 1 ]; data2[ idx2 + 2 ] = data[ idx + 2 ]; data2[ idx2 + 3 ] = 0xff; } } R_WriteTGA( fileName, data2, rc->width, rc->height, true ); R_StaticFree( data ); R_StaticFree( data2 ); } void idRenderSystemLocal::CaptureRenderToBuffer(unsigned char* buffer, bool usePbo) { if ( !glConfig.isInitialized ) { return; } renderCrop_t rc = renderCrops[currentRenderCrop]; if ( r_useFbo.GetBool() && !usePbo ) { // 4676 duzenko FIXME usePbo has double function rc.width /= r_fboResolution.GetFloat(); rc.height /= r_fboResolution.GetFloat(); } rc.width = (rc.width + 3) & ~3; //opengl wants width padded to 4x guiModel->EmitFullScreen(); guiModel->Clear(); R_IssueRenderCommands( frameData ); if (cmd.imageWidth * cmd.imageHeight == 0) { //stgatilov #4754: this happens during lightgem calculating in minimized windowed TDM return; //no pixels to be read } int backEndStartTime = Sys_Milliseconds(); if (!r_useFbo.GetBool()) // duzenko #4425: not applicable, raises gl errors qglReadBuffer(GL_BACK); // #4395 Duzenko lightem pixel pack buffer optimization if (usePbo && glConfig.pixelBufferAvailable) { static int pboSize = -1; if (!pbo) { pboSize = rc.width * rc.height * 3; qglGenBuffersARB(1, &pbo); qglBindBufferARB(GL_PIXEL_PACK_BUFFER, pbo); qglBufferDataARB(GL_PIXEL_PACK_BUFFER, pboSize, NULL, GL_STREAM_READ); qglBindBufferARB(GL_PIXEL_PACK_BUFFER, 0); } if (rc.width * rc.height * 3 != pboSize) common->Error( "CaptureRenderToBuffer: wrong PBO size %dx%d/%d", rc.width, rc.height, pboSize ); qglBindBufferARB(GL_PIXEL_PACK_BUFFER, pbo); unsigned char* ptr = (unsigned char*)qglMapBufferARB(GL_PIXEL_PACK_BUFFER, GL_READ_ONLY); if (ptr) { memcpy(buffer, ptr, pboSize); qglUnmapBufferARB(GL_PIXEL_PACK_BUFFER); } else { // #4395 vid_restart ? pbo = 0; } qglReadPixels(rc.x, rc.y, rc.width, rc.height, GL_RGB, GL_UNSIGNED_BYTE, 0); //qglReadPixels(rc->x, rc->y, rc->width, rc->height, GL_RGB, r_fboColorBits.GetInteger() == 15 ? GL_UNSIGNED_SHORT_5_5_5_1 : GL_UNSIGNED_BYTE, 0); qglBindBufferARB(GL_PIXEL_PACK_BUFFER, 0); } else qglReadPixels(rc.x, rc.y, rc.width, rc.height, GL_RGB, GL_UNSIGNED_BYTE, buffer); qglClear(GL_COLOR_BUFFER_BIT); int backEndFinishTime = Sys_Milliseconds(); backEnd.pc.msec += backEndFinishTime - backEndStartTime; } /* ============== AllocRenderWorld ============== */ idRenderWorld *idRenderSystemLocal::AllocRenderWorld() { idRenderWorldLocal *rw; rw = new idRenderWorldLocal; worlds.Append( rw ); return rw; } /* ============== FreeRenderWorld ============== */ void idRenderSystemLocal::FreeRenderWorld( idRenderWorld *rw ) { if ( primaryWorld == rw ) { primaryWorld = NULL; } worlds.Remove( static_cast<idRenderWorldLocal *>(rw) ); delete rw; } /* ============== PrintMemInfo ============== */ void idRenderSystemLocal::PrintMemInfo( MemInfo_t *mi ) { // sum up image totals globalImages->PrintMemInfo( mi ); // sum up model totals renderModelManager->PrintMemInfo( mi ); // compute render totals } /* =============== idRenderSystemLocal::UploadImage =============== */ bool idRenderSystemLocal::UploadImage( const char *imageName, const byte *data, int width, int height ) { idImage *image = globalImages->GetImage( imageName ); if ( !image ) { return false; } image->UploadScratch( data, width, height ); image->SetImageFilterAndRepeat(); return true; } | ||||
related to | 0004612 | resolved | nbohr1more | Attempt to save game -> crash |
Can't reproduce on either 32bit or 64bit | |
Reproduced from the first try. Windows x64, fresh SVN. Just run new game on The Ravine and tried to minimized TDM. Same error message about wrong PBO size. Luckily, the error message gives a very clear information about what exactly happens and where. I suppose Duzenko can fix it, if he doesn't mind?... |
|
I can also reproduce it in Debug x32 (exception is thrown). Also it happens on The New Job mission. Since Bikerdude forgot to attach cfg-file, I have attached mine. |
|
I thought I saw something similar during when I fixed the Lightgem init issues. Might be as easy as forcing pbo = 0 when minimize is invoked? (Not that I was terribly happy with the way I fixed those issues... Duzenko... ?) |
|
You should only be trying to reproduce errors in 2.06 beta, not SVN. | |
Probably we should finally do something with the check itself. Right now it checks if PBO has expected size and crashes if it does not. Maybe we should simply accept that PBO may have different size at this moment and decide how we should handle it? For instance, we can return zero buffer if such case, write a warning (at least once) and continue playing... |
|
I like that... :) | |
Thanks for picking this up chaps, and I have attached my config if its of any use. | |
By the way, does the game still run when TDM is minimized? Because if it does, then returning zero lightgem values from minimized state is not a good idea. Imagine exploit: go to a well-lit place with guard, minimize TDM, wait while guard's steps are gone, restore TDM back to full and continue =) |
|
Caused by empty (zero) idRenderSystemLocal.renderCrops - caused by zero glConfig.vidWidth/Height - caused by empty result of GetClientRect in MainWndProc Basically no rendering is done when a window is minimized currently. I would suggest to ignore zero values returned by GetClientRect. Alternatively, since the engine originally only supported running in exclusive fullscreen, we might want to disable the minimize button. |
|
Fixed in SVN rev 7379. When TDM is minimized, renderview of size 0 x 0 is being captured. I have added a new check: if the renderview contains zero pixels, then the whole reading operation is skipped. This check triggers when TDM is minimized, so the PBO is left with its normal size 64 x 64 without any errors. Additional info for merging into 2.06: This code is located in idRenderSystemLocal::CaptureRenderToBuffer. It must be put into line 936 of RenderSystem.cpp. |
|
I believe this change has caused a new problem. With FBO enabled, if your exit one mission then install another, the screen will be distorted unless you exit Darkmod and restart it. I tried a few things last night to attempt to cure that but thus far have not made progress. One thing I didn't try yet is replacing the "return" break in this fix with FB_Clear(). Since that zero's out the PBO perhaps that would have the same effect? All in all, this problem makes me think that FBO creation should be in RenderSystem_init. |
|
Throwing in the towel... | |
Did you verify that the problem is caused by the fix? Because I do not see how FBO issues can be related to PBO size, especially that my change does not alter behavior if you do NOT minimize windowed TDM at least once. |
|
There were two other render changes that had to do with render diagnostic tools. I was under the impression that they made no changes in FBO handling at all so this is where I focused my efforts. I'll review those to see if something was misleading about their scope. Edit: Screenshot added |
|
Argh. And 7377 changes do alter FBO... |
|
And there it is. The crime was not committed here. Just tested this change prior to revision 7377 and the bug does not happen. |
|
Fixed in rev 7381 | |
Nice works chaps. | |
I don't understand the comment about 7379 needing special merge instructions; the change is a simple addition. Also, the merge instructions don't talk about the correct file involved in 7379. I assume that merging 7379 followed by 7381 achieves the correct fix. |
|
The special issue is probably just due to divergence between SVN and 2.06 in framebuffer.cpp. 7381 is related to 7377. So if you merge 7377 then apply 7381 too. |
|
So I should not merge 7379? 7379's framebufer.cpp has a ton of changes in it and does NOT merge automatically. Nor am I able to do a manual merge, due to the number of changes. |
|
I will attempt a local merge of the diff between 7379 and the previous revision of framebuffer.cpp against a working copy of the 2.06 beta branch tonight. If there's no problem with that I will relay the steps and\or merge it myself if needed. |
|
I see the source of my confusion. I can't merge 7379 because it's a simple change to a larger previous change that is not part of 2.06. So I will NOT be merging 7379. |
|
I get it. The same code exists in both but SVN has it in framebuffer but 2.06 has it in RenderSystem. I guess this get's moved to 2.07 with a note to end-users about minimizing TDM and the risk of crashing? |
|
No clue. I did NOT merge 7379. I hand-merged 7377, followed by 7381. |
|
I have attached the 2.06 compliant RenderSystem.cpp 7379 fix Referred to by stgatilov. That won't help 7377 and 7378 which appear to be irreconcilable to 2.06? |
|
Am I supposed to include the attachment in the next build? I don't understand the relationship between 7377 and 7378. Are you saying they're mutually exclusive? 7377, 7378, and 7381 are in the latest build package. Do the problems they fix still appear? |
|
Yes, please include the RenderSystem.cpp in the next build. 7738 requires 7377 and both require 7381. r_showLightCount was still broken when I tested last night. I will test again tonight. |
|
I've committed the attached RenderSystem.cpp to SVN, and will include it in the next 2.06 package build. | |
I'm sorry that it took so much time to understand why those "special instructions" were there. I have look at the merged cpp file, and found the new code at the correct place (well, according to both my older instructions and a bit of common sense). |
|
Okay, good to hear. Thanks. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
19.03.2018 16:10 |
|
New Issue | |
19.03.2018 16:10 |
|
File Added: Capture.JPG | |
20.03.2018 12:00 | AluminumHaste | Note Added: 0010116 | |
20.03.2018 14:01 | stgatilov | Note Added: 0010119 | |
20.03.2018 14:33 | stgatilov | File Added: Darkmod.cfg | |
20.03.2018 14:34 | stgatilov | Note Added: 0010121 | |
20.03.2018 14:44 | nbohr1more | Note Added: 0010122 | |
20.03.2018 15:12 | AluminumHaste | Note Added: 0010123 | |
20.03.2018 15:23 | stgatilov | Note Added: 0010124 | |
20.03.2018 15:51 | nbohr1more | Note Added: 0010125 | |
20.03.2018 21:59 |
|
File Added: Darkmod_bkd.cfg | |
20.03.2018 22:00 |
|
Note Added: 0010130 | |
20.03.2018 22:01 |
|
Assigned To | => duzenko |
20.03.2018 22:01 |
|
Status | new => assigned |
21.03.2018 02:53 | stgatilov | Note Added: 0010133 | |
25.03.2018 15:15 | duzenko | Note Added: 0010158 | |
25.03.2018 15:20 | duzenko | Note Edited: 0010158 | |
25.03.2018 15:57 | stgatilov | Assigned To | duzenko => stgatilov |
25.03.2018 16:05 | stgatilov | Note Added: 0010159 | |
25.03.2018 16:05 | stgatilov | Status | assigned => resolved |
25.03.2018 16:05 | stgatilov | Fixed in Version | => TDM 2.06 |
25.03.2018 16:05 | stgatilov | Resolution | open => fixed |
09.04.2018 12:40 | nbohr1more | Note Added: 0010352 | |
10.04.2018 01:51 | nbohr1more | Note Added: 0010355 | |
10.04.2018 03:52 | stgatilov | Note Added: 0010356 | |
13.04.2018 03:38 | nbohr1more | Note Added: 0010358 | |
13.04.2018 03:39 | nbohr1more | File Added: thiefsden_2018-04-12_23.33.41.png | |
13.04.2018 03:39 | nbohr1more | Note Edited: 0010358 | |
13.04.2018 03:50 | nbohr1more | Note Added: 0010359 | |
13.04.2018 04:09 | nbohr1more | Note Added: 0010360 | |
13.04.2018 04:43 | nbohr1more | Note Added: 0010363 | |
13.04.2018 09:07 |
|
Note Added: 0010364 | |
16.04.2018 17:54 | grayman | Note Added: 0010367 | |
16.04.2018 18:32 | nbohr1more | Note Added: 0010368 | |
16.04.2018 18:37 | grayman | Note Added: 0010369 | |
16.04.2018 19:17 | nbohr1more | Note Added: 0010370 | |
16.04.2018 19:19 | grayman | Note Added: 0010371 | |
16.04.2018 19:25 | nbohr1more | Note Added: 0010372 | |
16.04.2018 19:38 | grayman | Note Added: 0010373 | |
17.04.2018 03:55 | nbohr1more | File Added: RenderSystem.cpp | |
17.04.2018 03:57 | nbohr1more | Note Added: 0010374 | |
17.04.2018 16:09 | grayman | Note Added: 0010375 | |
17.04.2018 16:13 | nbohr1more | Note Added: 0010376 | |
17.04.2018 16:23 | grayman | Note Added: 0010377 | |
17.04.2018 17:24 | stgatilov | Note Added: 0010378 | |
17.04.2018 17:46 | grayman | Note Added: 0010379 | |
28.06.2018 08:18 | nbohr1more | Relationship added | related to 0004612 |