View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004826 | The Dark Mod | Coding | public | 06.06.2018 03:49 | 30.12.2020 01:17 |
Reporter | stgatilov | Assigned To | stgatilov | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Product Version | TDM 2.06 | ||||
Target Version | TDM 2.08 | Fixed in Version | TDM 2.08 | ||
Summary | 0004826: Remove ID hacks from third-party libraries: minizip and libjpeg | ||||
Description | Right now TDM uses slightly customized minizip (with sources put directly into TDM engine) and a bit customized libjpeg. It would be great to remove these hacks if possible. | ||||
Additional Information | About libjpeg: http://forums.thedarkmod.com/topic/19473-redesign-directory-structure-of-tdm-dependencies/#entry422730 About minizip: http://forums.thedarkmod.com/topic/18758-inefficient-ogg-loading-from-pk4-and-minizip-update/?hl=minizip | ||||
Tags | No tags attached. | ||||
Is the libjpeg hack still there after rev 7620? | |
As a part of related issue 0004822, all the hacks were removed or isolated in svn rev 8158 (branch 3rdparty_4822 merged) and svn rev 8161. Right now we use official version of third party libraries, although we build some libraries using custom conan recipes. Here is how the issue was resolved: * minizip: the custom stuff was extracted into minizip_extra.{c|h} files; custom allocators disabled; * libjpeg: fixed the LoadJPG function in Image_files.cpp, which was asserting that image buffer had 32-bit pixels; JPEG_INTERNALS defines in roq.h to access private stuff; * ogg/vorbis: additional ogg->stream member moved out of structure to oggStream member (I think it is not even used); custom allocators disabled; |
|
Date Modified | Username | Field | Change |
---|---|---|---|
06.06.2018 03:49 | stgatilov | New Issue | |
06.06.2018 03:49 | stgatilov | Status | new => assigned |
06.06.2018 03:49 | stgatilov | Assigned To | => stgatilov |
06.06.2018 03:50 | stgatilov | Relationship added | related to 0004533 |
11.06.2018 09:40 | stgatilov | Target Version | TDM 2.07 => |
15.12.2018 04:21 | nbohr1more | Note Added: 0010923 | |
20.01.2019 07:20 | stgatilov | Target Version | => TDM 2.08 |
09.04.2019 02:42 | stgatilov | Relationship added | related to 0004822 |
09.04.2019 17:27 | stgatilov | Note Added: 0011719 | |
09.04.2019 17:30 | stgatilov | Status | assigned => resolved |
09.04.2019 17:30 | stgatilov | Fixed in Version | => TDM 2.08 |
09.04.2019 17:30 | stgatilov | Resolution | open => fixed |
30.12.2020 01:17 | nbohr1more | Relationship added | parent of 0003267 |