View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004859||DarkRadiant||General||public||10.07.2018 02:13||24.09.2018 12:53|
|Target Version||2.7.0||Fixed in Version||2.7.0|
|Summary||0004859: DR thinks an entity name of the form "Cylinder01" is the same as "Cylinder1"|
|Description||When I have a bunch of entities named like this:|
and I want to make them uniform by changing "Cylinder01" to "Cylinder1", DR tells me "Cylinder1" already exists.
Also, if I try to change "Cylinder2" to "Cylinder02", I get the same response.
DR is ignoring the leading zeros when doing string comparison.
I don't think it should, when dealing with the "name" key.
|Tags||No tags attached.|
I can confirm this. The system as it is working right now also prevents simply renaming an entity from "Carl01" to "Carl1".
DR converts the number postfix of "Carl01" into an integer, and "01" gets mapped to the same integer value 1 as the string "1".
I can try to change the internals to keep the actual string representation of the number as key, and then check if this has any negative impact.
|Commit 749e321c changes the internal postfix format from int to std::string. I tested a few use-cases (copying map parts, renaming back and forth) and it seems to work ok.|
|10.07.2018 02:13||grayman||New Issue|
|12.07.2018 04:03||greebo||Status||new => acknowledged|
|24.09.2018 08:53||greebo||Note Added: 0010771|
|24.09.2018 08:53||greebo||Status||acknowledged => confirmed|
|24.09.2018 09:17||greebo||Assigned To||=> greebo|
|24.09.2018 09:17||greebo||Status||confirmed => assigned|
|24.09.2018 09:17||greebo||Target Version||=> 2.7.0|
|24.09.2018 09:18||greebo||Note Added: 0010772|
|24.09.2018 09:18||greebo||Status||assigned => resolved|
|24.09.2018 09:18||greebo||Fixed in Version||=> 2.7.0|
|24.09.2018 09:18||greebo||Resolution||open => fixed|
|24.09.2018 12:53||grayman||Note Added: 0010775|