View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004900 | DarkRadiant | General | public | 24.11.2018 08:12 | 05.09.2021 18:22 |
| Reporter | EoceneMiacid | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x64 Linux | OS | Kubuntu | ||
| Product Version | 2.5.0 | ||||
| Target Version | 2.11.0 | Fixed in Version | 2.11.0 | ||
| Summary | 0004900: Material parser doesn't recognise materials with no whitespace between name and block | ||||
| Description | DarkRadiant appears to have some parsing inconsistencies. For example, defining a material like this: myMaterial{ ... } causes DarkRadiant to not read the material, unless there is a space or newline inbetween the definition name and the {. So this is fine: myMaterial { } or myMaterial { } Soundshaders have the same problem - however, definition files don't. It took me a while to find the cause because Doom 3 parses this correctly. This is a parsing bug in DarkRadiant. Could you please address it? | ||||
| Steps To Reproduce | define a material like this: myMaterial{ ... } and then check the console in DarkRadiant | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master 2e114d6a 23.01.2021 03:59 Details Diff |
0004900: Add material file with a couple of test materials. The third one is lacking whitespace between name and opening brace. |
Affected Issues 0004900 |
|
| mod - test/Materials.cpp | Diff File | ||
| add - test/resources/tdm/materials/parsing_test.mtr | Diff File | ||
|
DarkRadiant: master c3b560fa 23.01.2021 04:20 Details Diff |
0004900: Start constructing some block tokeniser tests |
Affected Issues 0004900 |
|
| add - test/Parsing.cpp | Diff File | ||
| mod - tools/msvc/Tests/Tests.vcxproj | Diff File | ||
| mod - tools/msvc/Tests/Tests.vcxproj.filters | Diff File | ||
|
DarkRadiant: master 38294b31 23.01.2021 04:38 Details Diff |
0004900: Expand DefBlockTokeniser unit tests |
Affected Issues 0004900 |
|
| mod - test/Parsing.cpp | Diff File | ||
|
DarkRadiant: master 7298941f 23.01.2021 05:43 Details Diff |
0004900: Add some test sound shaders to confirm the parser can deal with various cases |
Affected Issues 0004900 |
|
| mod - test/Parsing.cpp | Diff File | ||
| add - test/resources/tdm/sound/parsing_test.sndshd | Diff File | ||
|
DarkRadiant: master b82e4394 23.01.2021 08:35 Details Diff |
0004900: Def blocks not always have whitespace between the block name and the opening brace, this has been causing parser failures |
Affected Issues 0004900 |
|
| mod - libs/parser/DefBlockTokeniser.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 24.11.2018 08:12 | EoceneMiacid | New Issue | |
| 01.02.2019 11:28 | orbweaver | Status | new => acknowledged |
| 23.01.2021 05:23 | greebo | Status | acknowledged => confirmed |
| 23.01.2021 05:30 | greebo | Summary | material and soundshader parsing problems => Material parser doesn't recognise materials with no whitespace between name and block |
| 23.01.2021 05:30 | greebo | Assigned To | => greebo |
| 23.01.2021 05:30 | greebo | Status | confirmed => assigned |
| 23.01.2021 05:44 | greebo | Changeset attached | => DarkRadiant master c3b560fa |
| 23.01.2021 05:44 | greebo | Changeset attached | => DarkRadiant master 38294b31 |
| 23.01.2021 05:44 | greebo | Changeset attached | => DarkRadiant master 2e114d6a |
| 23.01.2021 05:44 | greebo | Changeset attached | => DarkRadiant master 7298941f |
| 23.01.2021 05:44 | greebo | Target Version | => 2.11.0 |
| 23.01.2021 05:44 | greebo | Status | assigned => resolved |
| 23.01.2021 05:44 | greebo | Resolution | open => fixed |
| 23.01.2021 05:44 | greebo | Fixed in Version | => 2.11.0 |
| 23.01.2021 08:35 | greebo | Changeset attached | => DarkRadiant master b82e4394 |
| 05.09.2021 18:22 | greebo | Status | resolved => closed |
