View Issue Details

IDProjectCategoryView StatusLast Update
0004909The Dark ModGraphicspublic25.12.2018 01:14
Reportergrayman Assigned Tograyman  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionwon't fix 
Product VersionSVN 
Summary0004909: wallpaper_victorian_04 problem
DescriptionThis wallpaper is used in the room across from the starting point of Home Again. It's acting like the diffuse texture is missing: all dark.

The same wallpaper is used in the top room of the tower in In the North, and it's fine there.

Find out what the difference is.
TagsNo tags attached.
Attached Files
Darkmod.cfg (12,652 bytes)

Activities

grayman

grayman

10.12.2018 15:01

viewer   ~0010855

If I build my unreleased version of HA using the latest SVN, the wallpaper is back to normal.

Needs to be tested with the 2.07 release candidates.
grayman

grayman

17.12.2018 02:50

viewer   ~0010951

Immediately after 2.07 branch, the problem is still there.
grayman

grayman

17.12.2018 02:52

viewer   ~0010952

This looks like a shader/rendering/lighting problem, so it needs someone familiar with those areas to examine it.
grayman

grayman

22.12.2018 09:47

viewer   ~0011020

Also occurs with the latest 2.07 beta and the released version of Home Again.
grayman

grayman

22.12.2018 10:03

viewer   ~0011037

Darkmod.cfg attached.
Springheel

Springheel

23.12.2018 14:57

administrator   ~0011075

Last edited: 23.12.2018 15:07

I looked at the issue and can confirm your observations. You have a local copy of that texture in your pk4, which uses the "_flat" normalmap. Could that have something to do with it? That is not used in the default mod texture.

grayman

grayman

23.12.2018 15:08

viewer   ~0011077

No clue.

I see a duzenko commit involving _flat, in the 2.07 branch.

I rebuilt the branch exes and the problem is still there.
grayman

grayman

23.12.2018 15:10

viewer   ~0011078

Originally, the _flat designation was used in In the North, which is where I introduced the texture.

Whoever put the texture into TDM core decided to add a bumpmap (Biker?).

Thus the discrepancy.
Springheel

Springheel

23.12.2018 15:25

administrator   ~0011081

Last edited: 23.12.2018 15:29

Well, this is a bit of a mess. There are two different versions of the shader in the core mod.

There are the core wallpaper material shaders defined in tdm_paint_paper.mtr, where they should be. It looks like you added those ones.

But there is also a tdm_ws1_textures.mtr file in the darkmod/materials folder, that defines textures/darkmod/map_specific/steele/wallpaper_victorian_04. Bikerdude added that one after you had already added them to the core mod, for some reason. It points to textures that don't exist.

Duzenko then made changes to it last year, fixing the path to the normalmap, but not the diffuse. This is what it looks like now:

textures/darkmod/map_specific/steele/wallpaper_victorian_04
{
    wood

    qer_editorimage textures/darkmod/map_specific/steele/wallpaper_victorian_04_ed
    diffusemap textures/darkmod/map_specific/steele/wallpaper_victorian_04
    bumpmap textures/darkmod/paint_paper/wallpaper_victorian_04_local

    {
        if ( parm11 > 0 )
        blend gl_dst_color, gl_one
        map _white
        rgb 0.40 * parm11
    }
    {
        if ( parm11 > 0 )
        blend add
        map textures/darkmod/map_specific/steele/wallpaper_victorian_04
        rgb 0.15 * parm11
    }

    // TDM Ambient Method Related
    {
        if (global5 == 1)
        blend add
        map textures/darkmod/map_specific/steele/wallpaper_victorian_04
        scale 1, 1
        red global2
        green global3
        blue global4
    }
}

That won't work, as it's looking for a diffusemap that doesn't exist. This fits what I observed, as it looked like the surface had a normalmap but not a diffuse. Not sure why your version doesn't override this one though.

duzenko

duzenko

23.12.2018 15:35

developer   ~0011082

How is this related to _flat?
Springheel

Springheel

23.12.2018 15:37

administrator   ~0011083

It's not.
grayman

grayman

23.12.2018 15:52

viewer   ~0011084

_flat is preferred.

It's a flat wallpaper. The added bumpmap should be removed.

Other victorian wallpapers might suffer from the same problem.

Since the wallpapers originated with me, do you want me to straighten this out (remove duplicates, correct bumpmap, etc.)? It would require interrogating existing maps to see which version mappers have used since In the North.
Springheel

Springheel

23.12.2018 16:27

administrator   ~0011086

Last edited: 23.12.2018 16:36

When you added the victorian wallpapers to tdm_paint_paper.mtr, you added them with normalmaps, and that's the texture that's been used by mappers ever since, so I wouldn't change it now. Since that's NOT the one used by your map, it has no impact on this issue.

The version in tdm_ws1_textures.mtr ALSO had a bumpmap when it was first uploaded by Bikerdude. That bumpmap, like all the other stages, pointed to textures that did not exist in the core. That material file should never have been uploaded to the core mod in the first place, since almost none of the textures it references actually exist outside your pk4.

One question I'm still not sure of is why Home Alone is using the texture from tdm_ws1_textures.mtr, instead of the one from your .pk4. Your version of the material shader, in your pk4, does use the _flat bumpmap. But that's not the version the map is actually using, at least in that one location.

edit: Just to be sure, I modified the textures/darkmod/map_specific/steele/wallpaper_victorian_04 shader in tdm_ws1_textures.mtr and loaded up Home Again. The map is definitely using that shader, NOT one from your pk4.

grayman

grayman

24.12.2018 18:51

viewer   ~0011101

I'm royally confused about the history of the victorian textures.

Biker put them into the core, but didn't complete the job, thus subsequent bug reports were needed to make them work. I've no idea why he created tdm_ws1_textures.mtr, but I believe that's the first place where the _flat bumpmaps were replaced with actual _local files. And that wasn't done by me.

When I added the textures to the paint/paper material file, I'm pretty sure I was unaware that the bumpmap designations had changed. I might have just copied them from tdm_ws1_textures.mtr, but none of this makes sense because Biker (in error) kept the map_specific/steele folder names, which never should have been done.

If I ever release HA again (I have a newer version that fixes some bugs), I'll try to straighten it out based on what the material defs look like at that point, or I'll rename the farkin' texture and provide the correct support files in the mission pk4.

So, at this point, I'm going to close this out and HA will have black wallpaper in that room until a new version comes out.

In retrospect, I wish Biker had just asked me to put the textures into the core mod, instead of doing it himself and screwing it up.
Springheel

Springheel

25.12.2018 01:13

administrator   ~0011105

Last edited: 25.12.2018 01:14

I can understand your frustration. Most of the textures in that file can't even be used by anyone because they reference "map_specific/steele".

What I can't understand is why running that mission causes the core mod material shader to be used, even though it has the same name (textures/darkmod/map_specific/steele/wallpaper_victorian_04) as a material shader included in your .pk4. Shouldn't your pk4 material file override the mod one?

Issue History

Date Modified Username Field Change
09.12.2018 10:25 grayman New Issue
09.12.2018 10:25 grayman Status new => assigned
09.12.2018 10:25 grayman Assigned To => grayman
10.12.2018 15:01 grayman Note Added: 0010855
17.12.2018 02:50 grayman Note Added: 0010951
17.12.2018 02:52 grayman Note Added: 0010952
17.12.2018 02:52 grayman Assigned To grayman =>
17.12.2018 02:52 grayman Status assigned => acknowledged
22.12.2018 09:47 grayman Note Added: 0011020
22.12.2018 10:03 grayman File Added: Darkmod.cfg
22.12.2018 10:03 grayman Note Added: 0011037
23.12.2018 14:57 Springheel Note Added: 0011075
23.12.2018 15:07 Springheel Note Edited: 0011075
23.12.2018 15:08 grayman Note Added: 0011077
23.12.2018 15:10 grayman Note Added: 0011078
23.12.2018 15:25 Springheel Note Added: 0011081
23.12.2018 15:25 Springheel Note Edited: 0011081
23.12.2018 15:27 Springheel Note Edited: 0011081
23.12.2018 15:29 Springheel Note Edited: 0011081
23.12.2018 15:35 duzenko Note Added: 0011082
23.12.2018 15:37 Springheel Note Added: 0011083
23.12.2018 15:52 grayman Note Added: 0011084
23.12.2018 16:27 Springheel Note Added: 0011086
23.12.2018 16:28 Springheel Note Edited: 0011086
23.12.2018 16:33 Springheel Note Edited: 0011086
23.12.2018 16:33 Springheel Note Edited: 0011086
23.12.2018 16:34 Springheel Note Edited: 0011086
23.12.2018 16:36 Springheel Note Edited: 0011086
24.12.2018 18:51 grayman Note Added: 0011101
24.12.2018 18:52 grayman Assigned To => grayman
24.12.2018 18:52 grayman Resolution open => won't fix
24.12.2018 18:52 grayman Target Version TDM 2.07 =>
24.12.2018 18:55 grayman Status acknowledged => closed
25.12.2018 01:13 Springheel Note Added: 0011105
25.12.2018 01:14 Springheel Note Edited: 0011105