| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004913 | The Dark Mod | Graphics | public | 14.12.2018 15:34 | 25.12.2019 01:24 |
| Reporter | stgatilov | Assigned To | stgatilov | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| OS | Windows | OS Version | 10 | ||
| Product Version | SVN | ||||
| Target Version | TDM 2.08 | Fixed in Version | TDM 2.08 | ||
| Summary | 0004913: Object proportions depend on aspect ratio | ||||
| Description | With some aspect ratio in Windowed mode I see object heavily stretched vertically. Is this supposed to happen? | ||||
| Steps To Reproduce | Run any mission with 4:3 (5:4) and with 16:9 (Windowed) and look at the same object in both cases. It will look streched on one of the cases. | ||||
| Additional Information | See also attached screenshort of own reflection in the mirror. On 5:4 aspect ratio I look too slim =) | ||||
| Tags | No tags attached. | ||||
 |
It's definitely not intentional. |
 |
I think this needs to be fixed for 2.07. We can't have people play with incorrect aspect ratio. |
 |
On TDM 2.05, this problems does not happen. ... Can anyone reproduce it on current 2.07 version? |
|
|
Ok, I found where aspect ratio is taken into account. It is in idGameLocal::CalcFov. This piece of code stinks. Anyway, the problem is that this function uses r_aspectRatio to learn the resolution proportions. And this one was not updated properly when I bumped into this bug, so the code used wrong aspect ratio for deducing view params. Now the aspect ratio should be fixed, so the problem should not happen. |
|
|
Added 2.08 target: I'll rewrite the code in idGameLocal::CalcFov to use r_customWidth / r_customHeight directly after beta phase ends. If someone manages to bump into the problem during beta, the target will be lowered =) |
|
|
The latest discussion on forum: http://forums.thedarkmod.com/index.php?/topic/20159-delete-r_fovratio/ |
|
|
Finished in svn rev 8404 |
|
|
Restored back old formulas for computing horizontal and vertical FOV from user-set value g_fov --- in svn rev 8452. See also: http://forums.thedarkmod.com/index.php?/topic/20159-delete-r_fovratio/&do=findComment&comment=441977 |
