| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004928 | The Dark Mod | Graphics | public | 24.12.2018 19:54 | 29.12.2018 22:03 |
| Reporter | grayman | Assigned To | Springheel | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | TDM 2.07 | ||||
| Summary | 0004928: Gold texture is wrong | ||||
| Description | Observe the difference between the gold texture in 2.06 and the same texture in 2.07. Map file attached. The only light in the room is ambient_world. This is one of many flat metal textures, so the problem might not be limited to the gold texture. | ||||
| Tags | No tags attached. | ||||
 |
I don't have 2.06 assets on my PC Can you attach a split screen shot please? Looks like a fake reflection to me. |
|
|
Can anybody explain what this is supposed to achieve? blend gl_dst_alpha, gl_one This is the first active stage, so where is gl_dst_alpha initialized? Looks like this material needs some fixing effort. |
 |
Attached |
|
|
Another RGTC artifact |
|
|
Our reflect-cube shader is ARB2. Our options: 1 - port it to GLSL and add RGTC support while on it 2 - remove the bump stage from the material in question Theoretically it's possible to add RGTC support to the existing ARB2 shader but IMHO we'd better off with GLSL replacement |
 |
Doesn't image_useNormalmapCompression 1 use S3TC compression and only Mode 2 enable RGTC? Or has the whole GLSL pipeline been converted to RGTC now? |
|
|
I believe @grayman tested this with image_useNormalmapCompression 2 |
|
|
So I ported most of the ARB2 shader and I can see a problem with the env/gen1 cubemap. Its seams have been sewn incorrectly as shown on the attached screenshot. I modified the material like this locally { //blend gl_dst_alpha, gl_one blend add //maskalpha cubeMap env/gen1 //red sintable[time*0.1] //green sintable[time*0.1] //blue sintable[time*0.1] //texgen reflect texgen skybox } The texgen is to show the seam issue and the rest is my attempt at fixing the material |
|
|
So... It's really cool that you are improving RGTC support but I think we should be clear here. RGTC compression is not yet production ready for 2.07 so players and mappers should not be using it other than to tinker with it and check it out in it's early incarnation. image_useNormalCompression 1 is the default mode and should have been advised as soon as Grayman encountered the first lighting bug where RGTC was discovered as the root cause. As to why Grayman had this value set to 2? 1) WAY back before TDM 1.08, this was the default mode. It was using RXGB compression (swizzled S3TC). When RXGB was broken in 1.08 all textures simply fell back to uncompressed so nobody would've noticed if they left the value at 2? 2) Grayman saw the RGTC development thread and tried testing this out and forgot to change it back to 1? etc. Whatever the case, mode 2 has not worked since 1.07 and should not be used until RGTC is production ready with working glass, water, and reflection shaders (etc). TLDR; use image_useNormalCompression 1 Does this make sense? |
|
|
Probably suggestion 1. |
|
|
Indeed, setting image_useNormalCompression 1 fixes the problem. Since that's the default, this bug can be closed. As for how it got set to 2, it's probably been in my config file for years, and when the setting of "2" became broken, it wasn't advertised loudly enough for me to realize to change it back to 1. |
|
|
Committed shader and C++ changes. Still needs material and cubemap fixes. |
 |
As this was a config problem,I am closing this issue. RGTC fixes and improvements should be tracked under a more meaningful issue name. |
