 |
Just saw that my reproduction steps and the test FM are still written in the original form, when I thought that the problem was with dmap (since deleting dmap files and restarting TDM was what I did to solve it back then - but it would already be sufficient to restart TDM or load another map). Updated repro steps and attachment. |
|
|
|
 |
In fact, we have a cvar (which is even archived) which controls if this "press attack to start" screen shows up at all. If you set "tdm_player_wait_until_ready 0", then you will never see this GUI at all, the map will simply start when it gets loaded. However, if you disable the waiting screen, the game still does not start after error. So the problem is not with the screen itself, but with something else. |
|
|
Ok, the reason game did not start was this condition: if ( m_time2Start && player->WaitUntilReady() ) // grayman 0003763 More precisely, the m_time2Start flag. This flag is raised via idGameLocal::SetTime2Start method, which is called in idSessionLocal::RunGameTic: // grayman 0003763 - allow "Mission Start" gui if the mission uses it if ( ( loadDoneTime > 0 ) && ( Sys_Milliseconds() > loadDoneTime ) ) { game->SetTime2Start(); loadDoneTime = 0; } The loadDoneTime is set in idSessionLocal::PacifierUpdate under event LOAD_KEY_IMAGES_INTERIM: case LOAD_KEY_IMAGES_INTERIM: // loading textures (finer granularity) pct += pct_delta; if ( (pct >= 1.00f) && (loadDoneTime == 0)) { // 5s delay between load bar at 100% and Mission Start gui display loadDoneTime = Sys_Milliseconds() + 5000; } if ( time - lastPacifierTime < 500 ) { return; } break; The thing is: when you reload a map, these image-related pacifier events do not happen. They do not happen either because of this code in idSessionLocal::ExecuteMapChange (or because images are already loaded): // actually purge/load the media if ( !reloadingSameMap ) { renderSystem->EndLevelLoad(); soundSystem->EndLevelLoad( mapString.c_str() ); declManager->EndLevelLoad(); SetBytesNeededForMapLoad( mapString.c_str(), fileSystem->GetReadCount() ); } uiManager->EndLevelLoad(); As you see, the whole stuff about image progress bar happens only if you change to different map. In other words, it does not happen if you restart mission, or reload same map after fixing an error. So the question is: why restarting map usually works, this case does not? Well, the answer is: the m_time2Start flag is never reset back to false! As long as you manage to load any map successfully, it has no effect in the future, even if you load a different FM. And obviously, you cannot "restart FM" or load same map without loading some new/other map first =) My question is: is this system of loadDoneTime even necessary? It makes sure that after progress bar hits 100%, at least 5 seconds pass before game starts (yeah, it waits doing nothing if needed). Note that progress bar hits 100% BEFORE all loading is finished, but by some unpredictable amount of time ( = time for loading last 35 images): // the -35 below guarantees there will be // some time between the loading bar // hitting 100% and the "Mission Loaded / Press Attack" screen pct_delta = (LOAD_KEY_DONE_PROGRESS - LOAD_KEY_IMAGES_START_PROGRESS) / (count - 35); And it actually works only on the very first fresh start of the game. |
|
|
In the linked thread I see: Leave 5s after the loading bar reaches 100% to allow for the reading of any posted tips. However, when I don't see any specific tips after it hits 100%. Are there some specific missions which want badly to show something to player at this moment? Even if there were, it is a bad design, since player can go away and get some coffee during initial load (I think that's the whole point behind "press attack to start" screen). |
|
|
Found some information on forums: https://forums.thedarkmod.com/index.php?/topic/16332-the-mission-loading-process/&do=findComment&comment=348308 https://forums.thedarkmod.com/index.php?/topic/16368-potential-load-bar-changes/ Here are the quotes: Grayman: "I left a couple seconds between arriving at 100% and painting the "Start when ready" screen, in case folks like seeing the "Mission Starting" or "Chill Out" messages." Springheel: "Hmm...I know in my missions, and St. Lucia and possibly others, the loading screen displays a "tip" once it hits 100% (ex: "You can lean into doors to eavesdrop on the next room"). It's probably important to make sure there's a good five seconds minimum for those cases." Grayman: "I had only noticed tips during the loading bar, not tips appearing afterward. I'll check St. Lucia again (it was one of the 10 I gathered data from). (Edit: Yeah, it posts a tip. Rats.) Adjusting up to 5s shouldn't be a problem. That's a long wait, though, if the mission isn't making use of the screen at that time." To be honest, I did not notice anything special displayed in New Job... |
|
|
Yes, there is the tip in Saint Lucia. But despite the obvious 5000 ms in the code, it only displays for one seconds for me, even on fresh load. So the whole system does not work anyway. |
|
|
Discussed here: https://forums.thedarkmod.com/index.php?/topic/16332-the-mission-loading-process/&do=findComment&comment=458233 Removed the pause system in svn rev 9231. I will leave this issue open until I get the opportunity to fix tips in FMs: follow score_to_settle matterofhours Builder's Influence. |
|
|
I'm doing the FMs repacking as the final part of FM database migration (0005551). Here are related commits (to FM database repo): r53 [matterofhours] 0005118. Adjusted mission loading tips. r54 [matterofhours] 0005118. Bumped version. r55 [follow] 0005118. Adjusted displaying tip in loading GUI. r56 [score_to_settle] 0005118. Adjusted time for dispalying tip during mission loading. r58 [builders_influence] 0005118. Adjusted tip in mission loading GUI. In the Matter of Hours, there are two pools of tips, and one tip from each pool is chosen randomly. I have split time 50 : 50 between two tips. In Reputation to Uphold (follow), fixed long text is displayed for the most time, and fixed tip is shown when loaded. After a bit of discussion with Springheel: https://forums.thedarkmod.com/index.php?/topic/16332-the-mission-loading-process/&do=findComment&comment=460494 I split the time 80 : 20 between story text and the tip. In Score to Settle, there is one pool for story text, and one pool for various tips. One random message is shown from each. I have split the time 60 : 40 between story text and tip. It feels fine to me. In Builder's Influence, the long story text is displayed while loading, and tip is displayed when loaded. Both of them are images (supporting localization), and both of them are fixed (no randomness). However, story text has different location, color and style, and the two texts look well together. I have changed it so that story text is displayed always, and tip text shows up after 60% of loading is done. |
|
|
Also adjusted Saint Lucia mission: r16252 [stlucia] 0005118. Adjusted time for displaying tip in Saint Lucia loading screen. The time is split into showing story text and tip in 70 : 30 proportion. |
- Anonymous
