View Issue Details

IDProjectCategoryView StatusLast Update
0005151DarkRadiantGUIpublic09.04.2020 19:14
ReporterDragofer Assigned Togreebo  
PrioritynormalSeveritytweakReproducibilityN/A
Status resolvedResolutionfixed 
Product Version2.7.0 
Target Version2.8.0Fixed in Version2.8.0 
Summary0005151: Targeting projected lights: let the line point to the light source instead of the light volume's midpoint
DescriptionWhen targeting a light, I've noticed that the target line points to the middle of the light's volume. For an omni light this is fine because the light source is at the middle of the volume, but for a projected light it often looks like the target line is pointing into the middle of empty space. It's often hard to see which projected light is being targeted.
See the attached image, where a lamp is targeting 2 windows and their projection lights. I've made the projection lights bright red for this shot so they can be seen better.

I'd like to suggest that the target line points to the light entity's origin, which is where the source is.
TagsNo tags attached.

Activities

Dragofer

Dragofer

12.02.2020 10:05

developer  

target_projected_light.jpg (53,510 bytes)   
target_projected_light.jpg (53,510 bytes)   

Related Changesets

DarkRadiant: master eae81b84

2020-04-09 19:13:01

greebo

Details Diff
Resolve 0005151: Targeting projected lights: let the line point to the light source instead of the light volume's midpoint
I considered introducing a new virtual scene::INode::getObjectCenter() method to be overridden by lights, but I settled to dynamic_cast the target(ed) nodes to fix this.
Affected Issues
0005151
mod - include/ilightnode.h Diff File
mod - include/version.h Diff File
mod - radiant/entity/light/LightNode.cpp Diff File
mod - radiant/entity/light/LightNode.h Diff File
mod - radiant/entity/target/Target.h Diff File
mod - radiant/entity/target/TargetLineNode.cpp Diff File
mod - tools/innosetup/darkradiant.x64.iss Diff File

Issue History

Date Modified Username Field Change
12.02.2020 10:05 Dragofer New Issue
12.02.2020 10:05 Dragofer File Added: target_projected_light.jpg
14.02.2020 04:14 greebo Status new => acknowledged
09.04.2020 16:43 greebo Status acknowledged => confirmed
09.04.2020 19:13 greebo Changeset attached => DarkRadiant master eae81b84
09.04.2020 19:13 greebo Assigned To => greebo
09.04.2020 19:13 greebo Resolution open => fixed
09.04.2020 19:13 greebo Status confirmed => assigned
09.04.2020 19:13 greebo Target Version => 2.8.0
09.04.2020 19:14 greebo Status assigned => resolved
09.04.2020 19:14 greebo Fixed in Version => 2.8.0