View Issue Details

IDProjectCategoryView StatusLast Update
0005229DarkRadiantSaving and loadingpublic26.04.2020 04:19
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.8.0 
Fixed in Version2.8.0 
Summary0005229: Layers information gets duplicated in consecutive save operations
DescriptionThe information saved in the .darkradiant file is getting duplicated when saving a map twice in a row.
See also: https://forums.thedarkmod.com/index.php?/topic/20330-darkradiant-280-pre-release-testing/&do=findComment&comment=446356

DarkRadiant Map Information File Version 2
{
    MapProperties
    {
        KeyValue { "EditTimeInSeconds" "178" }
        KeyValue { "LastCameraAngle" "0 0 0" }
        KeyValue { "LastCameraPosition" "0 0 0" }
        KeyValue { "LastShaderClipboardMaterial" "textures/darkmod/map_specific/church/stone/brick_dark01" }
    }
    *Layers*
    {
        Layer 0 { Default }
        Layer 1 { Archie }
        Layer 2 { Walter }
    }
    *Layers*
    {
        Layer 0 { Default }
        Layer 1 { Archie }
        Layer 2 { Walter }
    }
    NodeToLayerMapping
    {
        ....
Steps To Reproduce1. Create a new map.
2. Add an AI named Archie.
3. Add an AI named Walter.
4. Create layers "Archie" and "Walter".
5. Move Archie and Walter to their respective layers.
6. Save the map as archie.map.
7. Save the map as orville.map.
8. Open the orville.darkradiant file to see the above effect
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master 965dab71

2020-04-26 04:11:36

greebo

Details Diff
0005229: Fix layer and selection set info file sections being written twice to the .darkradiant file in consecutive saves.
Reminder to myself: std::stringstream::clear() doesn't clear its contents, it just clears the state bits.
Affected Issues
0005229
mod - radiant/layers/LayerInfoFileModule.cpp Diff File
mod - radiant/layers/LayerInfoFileModule.h Diff File
mod - radiant/map/MapPropertyInfoFileModule.cpp Diff File
mod - radiant/map/MapPropertyInfoFileModule.h Diff File
mod - radiant/selection/group/SelectionGroupInfoFileModule.cpp Diff File
mod - radiant/selection/group/SelectionGroupInfoFileModule.h Diff File
mod - radiant/selection/selectionset/SelectionSetInfoFileModule.cpp Diff File
mod - radiant/selection/selectionset/SelectionSetInfoFileModule.h Diff File

Issue History

Date Modified Username Field Change
26.04.2020 03:34 greebo New Issue
26.04.2020 03:34 greebo Status new => confirmed
26.04.2020 03:34 greebo Summary Layers information gets duplicated in consecutive save operation => Layers information gets duplicated in consecutive save operations
26.04.2020 04:09 greebo Assigned To => greebo
26.04.2020 04:09 greebo Status confirmed => assigned
26.04.2020 04:09 greebo Steps to Reproduce Updated View Revisions
26.04.2020 04:11 greebo Changeset attached => DarkRadiant master 965dab71
26.04.2020 04:19 greebo Status assigned => resolved
26.04.2020 04:19 greebo Resolution open => fixed
26.04.2020 04:19 greebo Fixed in Version => 2.8.0