 |
I suggest extending keywords to anything of format #str_lockpicking_difficulty I.e. allow any string starting with five characters "#str_" and 1-50 alphanum characters (0-9a-zA-Z_) after that. |
|
|
Also probably review the generation script?... |
|
|
Actually, the game engine works perfectly well with something like "#str_frontend_parallel". The perl script does not let it pass, which can be fixed pretty easily. So... I have no idea why we are stuck with those unreadable numbers. I found something like this on forums: Darkradiant currently does not support the dictionaries, so strings will look like "#str_07118" instead of the "OK". Along with much shit regarding localization framework and process =( Also I see the following test in all.lang: FM specific strings have the ID 20000 .. 89999 and are NOT to be stored in this file. Instead they go into "strings/fm/[language].lang". So I guess there is some convention about ID ranges. Obviously, similar convention must be made for arbitrary strings too. |
|
|
DarkRadiant does not do anything with these #str_ string, it just displays them "as is". It does not care if placeholders is integer or string. So I guess there is no reason to use numbers actually. After 2.09 is over, I'll try to fix the script and use some strings for graphics menu. Obviously, FM-specific strings should start with #str_fm_ to avoid accidental name conflicts. |
|
|
Committed the changes: r9289. Use generic string hash in idLangDict::GetHashKey and don't assert if characters are not digits. The engine code seems to perfectly supports arbitrary string placeholders. Aside from this little hash function, which is suited to #str_ddddd arguments and asserts for digits. r16230. Allow #str_{...} placeholders to have from 5 to 31 alphanumeric characters instead of just five digits. This is a fix in gen_lang script, since previously it only accepted 5 digits in placeholder. r16231. Changed names of two recent strings to use string placeholders. This is done in order to test the new system. Note that it is NOT a good idea to convert all names yet! Better leave it as it is for some time, and see how it goes. |
- Anonymous
