0005263: "Model Scaler" doesn't handle model duplication correctly (or perhaps consistently)

ID	Project	Category	View Status	Date Submitted	Last Update

0005263	DarkRadiant	Map Editing	public	25.05.2020 21:29	05.02.2021 11:29

Reporter	Geep	Assigned To	greebo
Priority	normal	Severity	normal	Reproducibility	sometimes
Status	closed	Resolution	fixed
OS	win10
Product Version	2.8.0
Target Version	2.9.0	Fixed in Version	2.9.0

Summary	0005263: "Model Scaler" doesn't handle model duplication correctly (or perhaps consistently)
Description	If, after using DR's "Model Scaler" functionality to scale a model, you hit the space key to create a duplicate, it creates a new unscaled object, which is really not what you want. This makes it harder to make multiple copies of the same sized item. JackFarmer confirms that problem, but reports that for him, sometimes hitting the space key actually does create a scaled duplicate. So it may be a consistency issue, or maybe it depends on if you scale up or down, or some other aspect of the model or scaling.
Steps To Reproduce	Create a model (e.g., a laundry sheet). Scale it larger with "Model Scaler". Hit space bar to make duplicate. Is the duplicate identical? (desired behavior) or the original size (undesired behavior)?
Additional Information	Workaround: save the resized model as a new model in the mission's model folder.
Tags	No tags attached.

DarkRadiant: master 407bcc4f 11.10.2020 05:13 greebo Details Diff	0005263: Add (failing) unit test covering the faulty behaviour	Affected Issues 0005263
	add - test/ModelScale.cpp	Diff File
	mod - test/algorithm/Scene.h	Diff File
	add - test/resources/tdm/maps/duplicate_scaled_model.map	Diff File
	add - test/resources/tdm/models/moss_patch.ase	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj.filters	Diff File
DarkRadiant: master f7790a65 11.10.2020 05:23 greebo Details Diff	0005263: Apply the same modified scale to the new model after being cloned	Affected Issues 0005263
	mod - radiantcore/entity/EntityNode.cpp	Diff File
	mod - radiantcore/entity/EntityNode.h	Diff File
	mod - radiantcore/entity/doom3group/Doom3GroupNode.cpp	Diff File
	mod - radiantcore/entity/eclassmodel/EclassModelNode.cpp	Diff File
	mod - radiantcore/entity/generic/GenericEntityNode.cpp	Diff File
	mod - radiantcore/entity/light/LightNode.cpp	Diff File
	mod - radiantcore/entity/speaker/SpeakerNode.cpp	Diff File
DarkRadiant: master caa8484e 11.10.2020 16:18 greebo Details Diff	0005263: Build fixes	Affected Issues 0005263
	mod - radiantcore/entity/EntityNode.cpp	Diff File

Date Modified	Username	Field	Change
25.05.2020 21:29	Geep	New Issue
11.10.2020 04:19	greebo	Status	new => confirmed
11.10.2020 05:24	greebo	Changeset attached	=> DarkRadiant master 407bcc4f
11.10.2020 05:24	greebo	Changeset attached	=> DarkRadiant master f7790a65
11.10.2020 05:24	greebo	Assigned To	=> greebo
11.10.2020 05:24	greebo	Status	confirmed => assigned
11.10.2020 05:24	greebo	Target Version	=> 2.9.0
11.10.2020 05:24	greebo	Status	assigned => resolved
11.10.2020 05:24	greebo	Resolution	open => fixed
11.10.2020 05:24	greebo	Fixed in Version	=> 2.9.0
11.10.2020 16:19	greebo	Changeset attached	=> DarkRadiant master caa8484e
05.02.2021 11:29	greebo	Status	resolved => closed