 |
The highlight is generated by InventoryPositiveFeedback window in tdm_inv.gui: windowDef InventoryPositiveFeedback { rect 0, 10*S1, 110*S1, 100*S1 background "guis/assets/hud/inventory_icons/inv_icon_overlay_positive" visible 1 matcolor 1,1,1,0 notime 1 onTime 0 { transition "matcolor" "InventoryPositiveFeedback::matcolor" "1 1 1 0.7" "200"; } onTime 200 { transition "matcolor" "1 1 1 0.7" "1 1 1 0" "500"; } } I have found in debug that its first transition has some garbage instead of InventoryPositiveFeedback::matcolor. The same applies to negative feedback --- no idea why negative is not affected (maybe people just don't see it often). |
|
|
During game start, idWindow::Parse puts the transitions into timeLineEvents in with unparsed parms: - parms [4] { {var=0x000001bbdcb387f0 {data="matcolor" } own=true }, {var=0x000001bbdcb389a0 {data="InventoryPositiveFeedback::matcolor" } own=true }, {var=0x000001bbdcb37290 {data="1 1 1 0.7" } own=true }, {var=0x000001bbdcb37dd0 {data="200" } own=true } } idList<idGSWinVar> + [0] {var=0x000001bbdcb387f0 {data="matcolor" } own=true } idGSWinVar + [1] {var=0x000001bbdcb389a0 {data="InventoryPositiveFeedback::matcolor" } own=true } idGSWinVar + [2] {var=0x000001bbdcb37290 {data="1 1 1 0.7" } own=true } idGSWinVar + [3] {var=0x000001bbdcb37dd0 {data="200" } own=true } idGSWinVar Soon after that, idWindow::FixupParms is started, in turn calling idGuiScript::FixupParms. It seems that in order to use variables in parameters, one has to prepend dollar: // // support variables as parameters int c; for ( c = 1; c < 3; c ++ ) { str = dynamic_cast<idWinStr*>(parms[c].var); idWinVec4 *v4 = new idWinVec4; parms[c].var = v4; parms[c].own = true; drawWin_t* owner; if ( (*str[0]) == '$' ) { dest = win->GetWinVarByName ( (const char*)(*str) + 1, true, &owner ); } else { dest = NULL; } |
|
|
And the credit for missing dollar goes to greebo from 2009 =) In other words, this bug has been present in TDM since lockpicking appeared. |
|
|
Fixed in svn rev 15983: added dollars to these two transitions. |
|
|
In order to avoid such problems in future, I committed a bunch of code changes too: r8902 Make sure all idWinVar objects are initialized with zeros. This should save us from similar reproducibility problems in future. r8903 + r8904 Hardening assignment of values to GUI variables. If we cannot parse value of appropriate type from the string in idWinVar::Set, complain with a warning. Note that rev 8903 and 8904 can potentially break some incorrect GUI scripts. On the other hand, now people will see warnings when they forget a dollar or "gui::". The warnings looks like this: Wrong idWinVec4: "InventoryPositiveFeedback::matcolor" |
- Anonymous
