 |
Do we know if there are any missions that rely on this buggy behavior? It is a little risky to modify this in the middle of 2.09 beta. |
 |
If the FM database could be searched for any missions that contain entities with certain combinations of spawnargs, then it could maybe be narrowed down enough for a mapper to manually check the missions whether they need the curent buggy behaviour. Any of these values for "classname": "trigger_entityname", "trigger_facing", "trigger_multiple", "trigger_presize" + "anyTouch" "1" Any of these values for "classname" might also be interesting on their own, regardless of combination: "trigger_inactivity", "trigger_random" |
|
|
Maps that use "trigger_multiple (thus far): NHAT (anoott) Winter Harvest Business as Usual Patently Dangerous "Prologue" Tears of St Lucia (Strangely, I got 2 different results when grepping my Dev and Beta fms folders... ) |
|
|
Thanks, though there are also variants of trigger_multiple (see previous post) that would be good to check for since they may share code. |
 |
In idAI::Anim_Move I've found this at line 6046: const idVec3& org = physicsObj.GetOrigin(); if (oldorigin != org) { TouchTriggers(); } So it appears this is no bug but the way it was originally intented (probably a leftover from Doom 3). I test what happens if I change this. |
|
|
Yep, that's it. Without hte condition the trigger behaves as desired. Discussed also here: https://forums.thedarkmod.com/index.php?/topic/20475-dragofers-scripting/&_fromLogin=1 |
 |
Could it be that both scenarios are valid, and the mapper could choose the desired behavior with a spawnarg? I was just working on something that was using a trigger multiple. I wanted something to trigger a sound when you walked through it. It worked great, except if you stopped in the middle of it then the sound kept repeating. It was one of those non-solid, translucent 'drapes' that you place over a doorway and I wanted it to make a 'whoosh' sound when you walked through it. So in this case, I wanted it to only work when the player first touches it. It was very thin as well (as was the trigger), so it only made sense to trigger once per 'touch'. |
|
|
Note though that for the player a continuos triggering is the default behaviour, so changing that would also potentially break existing mission. I could add such a spawnarg and set it so that the default spawnargs are different for ai and player, but that is as unintuitive as the current setup. Something like you mention would btw. still be possible, as functions called by triggers passes their activator. So you could track how long ago an entity has triggered the respective trigger the last time to get the desired effect. Triggers are imho not really meant for complex setups, though, that's what stims&response and scripts are meant for. |
|
|
Hmm ok - maybe just checking if the player is moving (or not moving in this case) in the script would be enough. I'll try that - thanks. I realise my comment doesn't really help with fixing the original issue - I just wanted to see if both scenarios could be supported in any upcoming fix... |
|
|
"Maps that use "trigger_multiple (thus far): NHAT (anoott) Winter Harvest Business as Usual Patently Dangerous "Prologue" Tears of St Lucia" I've checked those maps and the triggers do only respond to the player. The only trigger I found that responds to ai is in "A New Job" and it is a trigger_once_entityname to teleport an ai. Commited with rev. 9932. Sidenote: I don't think we need to add additional spawnargs etc. to the triggers as suggested by Frost_Salamander. Triggers can already call scripts and those can check whether whatever additional condition is met. |
 |
trigger_once uses the same spawnclass so perhaps it should be checked as well? |
|
|
Never mind, I see you did check for trigger_once_entityname. Sorry, please ignore. |
 |
I checked: the condition was in the original commit in 2004. Possible issues could be 1) breaking existing map, and 2) bad performance. But both points look very unlikely to me. |
- Anonymous
