View Issue Details

IDProjectCategoryView StatusLast Update
0005322The Dark ModCodingpublic04.08.2020 17:42
Reporterstgatilov Assigned Tostgatilov  
Status resolvedResolutionfixed 
Product VersionTDM 2.08 
Target VersionTDM 2.09Fixed in VersionTDM 2.09 
Summary0005322: Allow paths with hyphens in skins
DescriptionDue to bad convention, all strings in skins were unquoted before 2.08.
Moreover, there is also a convention to name some of the string as "something-nondistinguishable".
This hyphen is recognized as a token by idLexer, which breaks the path.
The subsequent behavior is rather uncertain.

While I normalized all stock skins by 2.08, all the custom skins remain broken.
It would be good to support hyphens in skins.
Steps To Reproduce1) Start Down by the Riverside mission 1.
2) setviewpos 61.24 125.37 84.25 -40.5 -21.5 0.0
Some people report it is black, although I can't confirm it.
But this FM surely contains bad skins, so one can look at wrong tokenization in debugger.
Additional InformationDescribed here:
TagsNo tags attached.




04.08.2020 17:42

administrator   ~0012716

Added LEXFL_ONLYSTRINGS to idLexer in idDeclSkin::Parse in svn rev 8912.
I checked the FM, and the recently added warning about hyphen goes away. Object looks correct, as I hope I have not broken anything.

Issue History

Date Modified Username Field Change
04.08.2020 17:32 stgatilov New Issue
04.08.2020 17:32 stgatilov Status new => assigned
04.08.2020 17:32 stgatilov Assigned To => stgatilov
04.08.2020 17:42 stgatilov Note Added: 0012716
04.08.2020 17:42 stgatilov Status assigned => resolved
04.08.2020 17:42 stgatilov Resolution open => fixed
04.08.2020 17:42 stgatilov Fixed in Version => TDM 2.09