View Issue Details

IDProjectCategoryView StatusLast Update
0005343DarkRadiantDesign/Codingpublic27.09.2020 16:20
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version2.8.1 
Target Version2.8.1Fixed in Version2.8.1 
Summary0005343: Unit Test Infrastructure Phase 2
DescriptionThe radiant core binary can be instantiated independently of the user interface binary now.
Running more than one test keeps running into obstacles now, since the static reference caches in the global module accessors get stale once the first test is shutting down the module registry.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master e5624004

2020-09-27 12:40:49

greebo

Details Diff
0005343: Cleanup the static OutputStreamHolder classes when shutting down a test fixture. Affected Issues
0005343
mod - include/imodule.h Diff File
mod - include/itextstream.h Diff File
mod - radiantcore/rendersystem/SharedOpenGLContextModule.cpp Diff File
mod - test/HeadlessOpenGLContext.cpp Diff File
mod - test/RadiantTest.h Diff File

DarkRadiant: master 32bcde9e

2020-09-27 14:13:01

greebo

Details Diff
0005343: Use a proxy object to cache the reference in the Global*() module accessor wrappers.
When the MODULE_REFERENCES_SUPPORT_INVALIDATION preprocessor symbol is defined, it will check the cached reference for validity on every access.
Affected Issues
0005343
mod - include/iaasfile.h Diff File
mod - include/ibrush.h Diff File
mod - include/icameraview.h Diff File
mod - include/iclipboard.h Diff File
mod - include/iclipper.h Diff File
mod - include/icolourscheme.h Diff File
mod - include/icommandsystem.h Diff File
mod - include/icounter.h Diff File
mod - include/ieclass.h Diff File
mod - include/ieditstopwatch.h Diff File
mod - include/ientity.h Diff File
mod - include/ientityinspector.h Diff File
mod - include/ieventmanager.h Diff File
mod - include/ifilesystem.h Diff File
mod - include/ifiletypes.h Diff File
mod - include/ifilter.h Diff File
mod - include/ifonts.h Diff File
mod - include/igame.h Diff File
mod - include/igl.h Diff File
mod - include/igrid.h Diff File
mod - include/igui.h Diff File
mod - include/iimage.h Diff File
mod - include/ilayer.h Diff File
mod - include/imainframe.h Diff File
mod - include/imainframelayout.h Diff File
mod - include/imap.h Diff File
mod - include/imapformat.h Diff File
mod - include/imapinfofile.h Diff File
mod - include/imapresource.h Diff File
mod - include/imd5anim.h Diff File
mod - include/imediabrowser.h Diff File
mod - include/imodel.h Diff File
mod - include/imodelcache.h Diff File
mod - include/imodule.h Diff File
mod - include/imousetoolmanager.h Diff File
mod - include/imru.h Diff File
mod - include/inamespace.h Diff File
mod - include/iorthocontextmenu.h Diff File
mod - include/iorthoview.h Diff File
mod - include/iparticles.h Diff File
mod - include/ipatch.h Diff File
mod - include/ipreferencesystem.h Diff File
mod - include/iradiant.h Diff File
mod - include/iregion.h Diff File
mod - include/iregistry.h Diff File
mod - include/irender.h Diff File
mod - include/irendersystemfactory.h Diff File
mod - include/iscenegraph.h Diff File
mod - include/iscenegraphfactory.h Diff File
mod - include/iscript.h Diff File
mod - include/iselection.h Diff File
mod - include/iselectiongroup.h Diff File
mod - include/iselectionset.h Diff File
mod - include/ishaderclipboard.h Diff File
mod - include/ishaders.h Diff File
mod - include/isound.h Diff File
mod - include/iuimanager.h Diff File
mod - include/iundo.h Diff File
mod - include/iwxgl.h Diff File
mod - include/modelskin.h Diff File
mod - radiantcore/modulesystem/ModuleRegistry.cpp Diff File
mod - radiantcore/modulesystem/ModuleRegistry.h Diff File

DarkRadiant: master d928b0ec

2020-09-27 14:19:30

greebo

Details Diff
0005343: Enable the MODULE_REFERENCES_SUPPORT_INVALIDATION preprocessor flag to fix the problem with stale module references surviving the module shutdown in between the test runs. Affected Issues
0005343
mod - tools/msvc/properties/Tests.props Diff File

Issue History

Date Modified Username Field Change
27.09.2020 12:37 greebo New Issue
27.09.2020 12:37 greebo Status new => confirmed
27.09.2020 16:19 greebo Changeset attached => DarkRadiant master e5624004
27.09.2020 16:19 greebo Changeset attached => DarkRadiant master 32bcde9e
27.09.2020 16:19 greebo Changeset attached => DarkRadiant master d928b0ec
27.09.2020 16:19 greebo Assigned To => greebo
27.09.2020 16:19 greebo Status confirmed => assigned
27.09.2020 16:20 greebo Target Version => 2.8.1
27.09.2020 16:20 greebo Status assigned => resolved
27.09.2020 16:20 greebo Resolution open => fixed
27.09.2020 16:20 greebo Fixed in Version => 2.8.1