0005347: Crash if pressing backspace while drawing a brush

ID	Project	Category	View Status	Date Submitted	Last Update

0005347	DarkRadiant	Map Editing	public	30.09.2020 12:35	05.02.2021 11:29

Reporter	Dragofer	Assigned To	greebo
Priority	normal	Severity	crash	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	2.8.0
Target Version	2.9.0	Fixed in Version	2.9.0

Summary	0005347: Crash if pressing backspace while drawing a brush
Description	If I'm left-click & dragging to draw a brush, but press backspace before releasing the left mouse button, DR tries to delete the brush but crashes.
Steps To Reproduce	Left-click & drag to create a new brush. Without releasing the LMB, press backspace. The brush is deleted, but you still see the info describing its location and dimensions and DR crashes (stops responding).
Tags	No tags attached.

greebo 30.09.2020 18:30 administrator ~0012786	Confirmed, though I had to try a few times to make it happen. Stacktrace: DarkRadiant.exe!scene::getNodeIndices(const std::shared_ptr<scene::INode> & node) Line 127 C++ > DarkRadiant.exe!ui::EntityInspector::getEntityFromSelectionSystem() Line 1202 C++ DarkRadiant.exe!ui::EntityInspector::updateGUIElements() Line 564 C++ DarkRadiant.exe!ui::EntityInspector::onIdle() Line 598 C++ DarkRadiant.exe!wxutil::SingleIdleCallback::_onIdle(wxIdleEvent & ev) Line 35 C++ wxbase313ud_vc14x_x64.dll!wxAppConsoleBase::HandleEvent(wxEvtHandler * handler, void(wxEvtHandler::*)(wxEvent &) func, wxEvent & event) Line 658 C++

DarkRadiant: master d162f4aa 01.10.2020 04:04 greebo Details Diff	0005347: Fix a crash in scene::getNodeIndices when a primitive without a parent is encountered. Protect the calling EntityInspector code against out_of_range exceptions that might be thrown by getNodeIndices.	Affected Issues 0005347
	mod - libs/scene/SelectionIndex.cpp	Diff File
	mod - radiant/ui/einspector/EntityInspector.cpp	Diff File
DarkRadiant: master 9c6ac119 01.10.2020 04:16 greebo Details Diff	0005347: Harden the BrushCreatorTool against deletions of the drag-created brush in the middle of the operation.	Affected Issues 0005347
	mod - radiant/xyview/tools/BrushCreatorTool.cpp	Diff File

Date Modified	Username	Field	Change
30.09.2020 12:35	Dragofer	New Issue
30.09.2020 12:42	Dragofer	Steps to Reproduce Updated
30.09.2020 18:30	greebo	Status	new => confirmed
30.09.2020 18:30	greebo	Note Added: 0012786
01.10.2020 04:04	greebo	Target Version	=> 2.9.0
01.10.2020 04:04	greebo	Assigned To	=> greebo
01.10.2020 04:04	greebo	Status	confirmed => assigned
01.10.2020 04:16	greebo	Changeset attached	=> DarkRadiant master d162f4aa
01.10.2020 04:16	greebo	Changeset attached	=> DarkRadiant master 9c6ac119
01.10.2020 04:16	greebo	Status	assigned => resolved
01.10.2020 04:16	greebo	Resolution	open => fixed
01.10.2020 04:16	greebo	Fixed in Version	=> 2.9.0
05.02.2021 11:29	greebo	Status	resolved => closed