0005371: [Surface Inspector] Fit Texture does not work if either Horiz. or Vert. scale are set to 0

ID	Project	Category	View Status	Date Submitted	Last Update

0005371	DarkRadiant	Map Editing	public	29.10.2020 08:41	05.02.2021 11:29

Reporter	Spooks	Assigned To	greebo
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	2.8.0
Target Version	2.9.0	Fixed in Version	2.9.0

Summary	0005371: [Surface Inspector] Fit Texture does not work if either Horiz. or Vert. scale are set to 0
Description	Obscure, I know. The Fit Texture button doesn't fix 0 scale textures and if, say, horizontal scale is set to 1 but vertical scale is set to 0, pressing the button will reset both to 0.000... The workaround is to press the Modify Texture: Natural first, which resets the scale values to the default scale.
Tags	No tags attached.

DarkRadiant: 2.9.0 69ff32c5 15.11.2020 05:50 greebo Details Diff	0005371: Sanity-check the texture projection before running the fit algorithm	Affected Issues 0005371
	mod - radiantcore/brush/TextureMatrix.cpp	Diff File
	mod - radiantcore/brush/TextureMatrix.h	Diff File
	mod - radiantcore/brush/TextureProjection.cpp	Diff File
DarkRadiant: 2.9.0 939f7966 15.11.2020 07:04 greebo Details Diff	0005371: Add unit test checking the fit texture algorithm after the recent fix	Affected Issues 0005371
	add - test/Face.cpp	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj.filters	Diff File

Date Modified	Username	Field	Change
29.10.2020 08:41	Spooks	New Issue
29.10.2020 16:27	greebo	Status	new => confirmed
29.10.2020 16:28	greebo	Note Added: 0012849
29.10.2020 16:29	greebo	Category	GUI => Map Editing
15.11.2020 07:04	greebo	Changeset attached	=> DarkRadiant 2.9.0 69ff32c5
15.11.2020 07:04	greebo	Changeset attached	=> DarkRadiant 2.9.0 939f7966
15.11.2020 07:05	greebo	Assigned To	=> greebo
15.11.2020 07:05	greebo	Status	confirmed => assigned
15.11.2020 07:05	greebo	Status	assigned => resolved
15.11.2020 07:05	greebo	Resolution	open => fixed
15.11.2020 07:05	greebo	Fixed in Version	=> 2.9.0
15.11.2020 07:05	greebo	Target Version	=> 2.9.0
05.02.2021 11:29	greebo	Status	resolved => closed

greebo 29.10.2020 16:28 administrator ~0012849	Confirmed. I'll change the code to replace the 0 scale value with a very small one, like 0.00001, and then proceed with the regular Fit algorithm.