View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005401||DarkRadiant||GUI||public||13.11.2020 11:07||05.02.2021 11:29|
|Fixed in Version||2.9.0|
|Summary||0005401: DR not always remembering window size and position between sessions|
|Description||In the past DR would take a few open/close actions to remember its window size/locations, but this doesn't appear to be the case anymore.|
Even nuking the DR user config folder and going through several close/open cycles doesn't help. I suspect Windows 10 isnt helping here.
My current work around is to force size/position via a 3rd party app (http://www.desksoft.com/WindowManager.htm)
|Tags||No tags attached.|
I need more specifics. Is there a multi-monitor setup involved? What is the state of DarkRadiant's windows that is supposed to be memorised? (A screenshot would be enough, then I can see whether the windows are placed on different monitors, their maximised state, etc.)
And if the position is not remembered, what happens instead?
- I do run dual screen normally, but atm I am running single screen.
- The size and position of the main window and the child windows should be memorized, but atm I am only having an issue with the main window.
- I have created a small video that hopefully explains the issue well enough, hopefully I dont sound too confusing.
|Can't view the video, it's "private"|
|Oops, forgot to make it as unlisted, try now.|
Thanks for the video. I can see the window shifting downwards after each startup, something it shouldn't do.
I can also observe that it completely forgets the position and moves it to towards the lower right, as it did in your video. I think this might be related to the window's dimensions extending below some screen boundary, but I have to check it out.
|Oh man, I thought I was going nuts. Im glad (and not glad, coz you have to fix it) you were able to reproduce it.|
|Added a fix, let's see if this improves things a bit|
|Greebo, your a little star!|
DarkRadiant: 2.9.0 9537e9e2
2020-11-14 17:33:29Details Diff
|0005401: Remove the code trying to fix the bottom left window coordinate if it's supposedly off-screen, we only care about the upper left corner.
Use GetScreenPosition to read the actual window position after moving, the wxMoveEvent delivers some offsets. The values returned by GetScreenPosition can be negative (on my Win10) machine, but this obviously is not a problem when trying to restore these values.
|mod - libs/wxutil/WindowPosition.cpp||Diff File|
|13.11.2020 11:07||Bikerdude||New Issue|
|14.11.2020 08:48||greebo||Note Added: 0012923|
|14.11.2020 08:48||greebo||Status||new => feedback|
|14.11.2020 10:17||Bikerdude||Note Added: 0012925|
|14.11.2020 10:17||Bikerdude||Status||feedback => new|
|14.11.2020 13:22||greebo||Note Added: 0012927|
|14.11.2020 13:42||Bikerdude||Note Added: 0012930|
|14.11.2020 14:18||greebo||Note Added: 0012933|
|14.11.2020 14:18||greebo||Status||new => confirmed|
|14.11.2020 14:28||Bikerdude||Note Added: 0012935|
|14.11.2020 17:33||greebo||Changeset attached||=> DarkRadiant 2.9.0 9537e9e2|
|14.11.2020 17:39||greebo||Assigned To||=> greebo|
|14.11.2020 17:39||greebo||Status||confirmed => assigned|
|14.11.2020 17:40||greebo||Status||assigned => resolved|
|14.11.2020 17:40||greebo||Resolution||open => fixed|
|14.11.2020 17:40||greebo||Fixed in Version||=> 2.9.0|
|14.11.2020 17:40||greebo||Note Added: 0012939|
|14.11.2020 23:15||Bikerdude||Note Added: 0012942|
|15.11.2020 11:43||greebo||Summary||Window size and position, DR 2.9pre2 => DR not always remembering window size and position between sessions|
|05.02.2021 11:29||greebo||Status||resolved => closed|