View Issue Details

IDProjectCategoryView StatusLast Update
0005426DarkRadiantCompilation/Buildpublic23.11.2020 11:50
ReporterAdrianMay Assigned Togreebo  
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
PlatformpcOSarch linuxOS Versionrolling, now.
Product Version2.9.1 
Target Version2.9.2Fixed in Version2.9.2 
Summary0005426: Can't build Radiant on current arch due to pybind breaking change
Description
/home/ad/build/darkradiant/DarkRadiant/plugins/script/../../include/iscript.h|7 col 28| error: using typedef-name ‘using module = class pybind11::module_’ after ‘class’
|| 7 | namespace pybind11 { class module; class dict; }
|| | ^~~~~~
|| In file included from ScriptingSystem.h:5,
/usr/include/pybind11/pybind11.h|1017 col 7| note: ‘using module = class pybind11::module_’ has a previous declaration here
|| 1017 | using module = module_;
|| | ^~~~~~

Because: https://pybind11.readthedocs.io/en/stable/upgrade.html .... for pybind 2.6 ...

py::module has been renamed py::module_, but a backward compatible typedef has been included.

Steps To ReproduceBuild Radiant on arch linux from source or from the AUR. I guess any system with pybind 2.6 will do.

TagsNo tags attached.

Activities

AdrianMay

AdrianMay

23.11.2020 11:50

reporter   ~0013013

Blimey that was fast. On a Sunday too. Thanks!

Related Changesets

DarkRadiant: master 3e480afc

2020-11-22 12:59:36

greebo

Details Diff
0005426: Fix compilation against pybind11 2.6+ Affected Issues
0005426
mod - include/iscript.h Diff File
add - include/iscriptinterface.h Diff File
mod - plugins/script/ScriptingSystem.h Diff File
mod - plugins/script/interfaces/BrushInterface.h Diff File
mod - plugins/script/interfaces/CameraInterface.h Diff File
mod - plugins/script/interfaces/CommandSystemInterface.h Diff File
mod - plugins/script/interfaces/DialogInterface.h Diff File
mod - plugins/script/interfaces/EClassInterface.h Diff File
mod - plugins/script/interfaces/EntityInterface.h Diff File
mod - plugins/script/interfaces/FileSystemInterface.h Diff File
mod - plugins/script/interfaces/GameInterface.h Diff File
mod - plugins/script/interfaces/GridInterface.h Diff File
mod - plugins/script/interfaces/MapInterface.h Diff File
mod - plugins/script/interfaces/MathInterface.h Diff File
mod - plugins/script/interfaces/ModelInterface.h Diff File
mod - plugins/script/interfaces/PatchInterface.h Diff File
mod - plugins/script/interfaces/RadiantInterface.h Diff File
mod - plugins/script/interfaces/RegistryInterface.h Diff File
mod - plugins/script/interfaces/SceneGraphInterface.h Diff File
mod - plugins/script/interfaces/SelectionGroupInterface.h Diff File
mod - plugins/script/interfaces/SelectionInterface.h Diff File
mod - plugins/script/interfaces/SelectionSetInterface.h Diff File
mod - plugins/script/interfaces/ShaderSystemInterface.h Diff File
mod - plugins/script/interfaces/SkinInterface.h Diff File
mod - plugins/script/interfaces/SoundInterface.h Diff File
mod - radiant/ui/script/ScriptMenu.cpp Diff File

Issue History

Date Modified Username Field Change
22.11.2020 07:14 AdrianMay New Issue
22.11.2020 07:24 greebo Status new => confirmed
22.11.2020 07:32 greebo Category Map Editing => Compilation/Build
22.11.2020 12:59 greebo Changeset attached => DarkRadiant master 3e480afc
22.11.2020 13:03 greebo Assigned To => greebo
22.11.2020 13:03 greebo Status confirmed => assigned
22.11.2020 13:05 greebo Target Version => 2.9.2
22.11.2020 13:22 greebo Status assigned => resolved
22.11.2020 13:22 greebo Resolution open => fixed
22.11.2020 13:22 greebo Fixed in Version => 2.9.2
23.11.2020 11:50 AdrianMay Note Added: 0013013