View Issue Details

IDProjectCategoryView StatusLast Update
0005454DarkRadiantGUIpublic29.12.2020 02:22
Reporterjonri Assigned Tojonri  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux 
Product Version2.9.1 
Target Version2.11.0Fixed in Version2.11.0 
Summary0005454: Script dialogs don't scale when window is resized
DescriptionWhen using dialogs from the python scripts, expanding the dialog horizontally (ex. to make more of a file path in a text box visible) will increase the width of the window but the GUI elements are not anchored to the right side so they do not expand with the window.

Steps To Reproduce1. Go to Scripts -> Export ASE
2. Grab the right side of the window and make it wider.
3. Note that the GUI elements do not expand with the window
Additional InformationThis was a one-line fix, see attached patch.
TagsNo tags attached.

Activities

jonri

jonri

23.12.2020 03:39

developer  

dialog.patch (466 bytes)   
diff --git a/libs/wxutil/dialog/Dialog.cpp b/libs/wxutil/dialog/Dialog.cpp
index ae11bbded..2e4dcfffd 100644
--- a/libs/wxutil/dialog/Dialog.cpp
+++ b/libs/wxutil/dialog/Dialog.cpp
@@ -19,6 +19,7 @@ Dialog::Dialog(const std::string& title, wxWindow* parent) :
 	_highestUsedHandle(0),
     _focusWidget(0)
 {
+	_elementsTable->AddGrowableCol(1);
 	_dialog->SetSizer(new wxBoxSizer(wxVERTICAL));
 
 	_dialog->GetSizer()->Add(_elementsTable, 1, wxEXPAND | wxALL, 12);
dialog.patch (466 bytes)   
greebo

greebo

23.12.2020 09:21

administrator   ~0013177

Nice, thanks. :)
You do have a Github account, am I right? I can give you contributor access to DarkRadiant, if you're planning to stick around?
jonri

jonri

23.12.2020 13:42

developer   ~0013180

Yes, I'm at least planning to at least fix things up as I come across them. Maybe some bigger things too if I'm motivated.
greebo

greebo

23.12.2020 15:03

administrator   ~0013181

Looking forward to it! We usually discuss larger things in the forums, so just ask me and OrbWeaver if you're unsure whether something fits into DR's design or not.
Bikerdude

Bikerdude

24.12.2020 11:47

reporter   ~0013184

Nice to have another DR dev :-)

Related Changesets

DarkRadiant: master 7127ccbb

2020-12-28 18:19:47

jonri

Details Diff
0005454: Improve resizing behavior of script dialogs Affected Issues
0005454
mod - libs/wxutil/dialog/Dialog.cpp Diff File

Issue History

Date Modified Username Field Change
23.12.2020 03:39 jonri New Issue
23.12.2020 03:39 jonri File Added: dialog.patch
23.12.2020 09:21 greebo Note Added: 0013177
23.12.2020 09:21 greebo Status new => confirmed
23.12.2020 13:42 jonri Note Added: 0013180
23.12.2020 15:03 greebo Note Added: 0013181
24.12.2020 08:42 greebo Assigned To => jonri
24.12.2020 08:42 greebo Status confirmed => assigned
24.12.2020 11:47 Bikerdude Note Added: 0013184
28.12.2020 18:20 jonri Changeset attached => DarkRadiant master 7127ccbb
28.12.2020 18:23 jonri Status assigned => resolved
28.12.2020 18:23 jonri Resolution open => fixed
28.12.2020 18:23 jonri Fixed in Version => 2.11.0
29.12.2020 02:22 greebo Target Version => 2.11.0