View Issue Details

IDProjectCategoryView StatusLast Update
0005456DarkRadiantMap Editingpublic27.11.2021 09:21
ReporterDragofer Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityN/A
Status closedResolutionfixed 
Product Version2.9.1 
Target Version2.11.0Fixed in Version2.11.0 
Summary0005456: Imported prefabs should be created at cursor
DescriptionSome prefabs are far off-center, possibly because they were created by somebody going through their map and exporting things wherever they were as prefabs, instead of moving them to the map origin first.

This means when a mapper imports such a prefab, it'll be created far away from where the mapper right-clicked in orthoview. If this behaviour is desired, it'd be better to export & import as a .map than as a prefab.

Maybe it would be possible to ensure prefabs are created close to the cursor? This would also mean we won't need to export prefabs at 0,0,0 anymore.

A possible risk might be that the prefab loses grid-alignment, so maybe not the true centre should be used, but rather a centre point that's snapped to the current grid size.
TagsNo tags attached.

Relationships

related to 0005620 closedgreebo Prefabs importing miles away 

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master 408fa404

2021-01-22 13:14:00

greebo

Details Diff
0005456: Some refactoring to be able to re-use the prefab bounds code during insertion. Snap the prefab center to grid and translate it to the point the user actually clicked. Affected Issues
0005456
mod - libs/scene/PrefabBoundsAccumulator.h Diff File
mod - radiant/ui/common/MapPreview.cpp Diff File
mod - radiantcore/map/Map.cpp Diff File

DarkRadiant: master c0d0fd07

2021-01-22 17:53:48

greebo

Details Diff
0005456: Basic unit tests checking the things that got implemented in this feature request. Affected Issues
0005456
mod - test/CMakeLists.txt Diff File
add - test/Prefabs.cpp Diff File
add - test/resources/tdm/def/speaker.def Diff File
add - test/resources/tdm/prefabs/large_bounds.pfbx Diff File
mod - tools/msvc/Tests/Tests.vcxproj Diff File
mod - tools/msvc/Tests/Tests.vcxproj.filters Diff File

DarkRadiant: master a1f25000

2021-01-23 02:46:36

greebo

Details Diff
0005456: Tweak view position Affected Issues
0005456
mod - include/version.h Diff File
mod - radiant/ui/common/MapPreview.cpp Diff File

DarkRadiant: master 6eba35a9

2021-01-23 03:00:02

greebo

Details Diff
0005456: Insert func_animate if a modelDef was chosen in the ModelSelector. Affected Issues
0005456
mod - radiant/ui/ortho/OrthoContextMenu.cpp Diff File

Issue History

Date Modified Username Field Change
24.12.2020 13:18 Dragofer New Issue
24.12.2020 13:19 Dragofer Description Updated
24.12.2020 18:02 greebo Status new => acknowledged
22.01.2021 12:10 greebo Status acknowledged => confirmed
22.01.2021 13:14 greebo Assigned To => greebo
22.01.2021 13:14 greebo Status confirmed => assigned
22.01.2021 13:14 greebo Target Version => 2.11.0
22.01.2021 17:54 greebo Changeset attached => DarkRadiant master 408fa404
22.01.2021 17:54 greebo Changeset attached => DarkRadiant master c0d0fd07
22.01.2021 18:02 greebo Status assigned => resolved
22.01.2021 18:02 greebo Resolution open => fixed
22.01.2021 18:02 greebo Fixed in Version => 2.11.0
23.01.2021 03:00 greebo Changeset attached => DarkRadiant master a1f25000
23.01.2021 03:00 greebo Changeset attached => DarkRadiant master 6eba35a9
21.05.2021 18:02 greebo Relationship added related to 0005620
27.11.2021 09:21 greebo Status resolved => closed