 |
Just pushed a fix. Is it working better now? In my Arch VM this is not crashing, neither at startup nor shutdown. |
 |
Yes, I confirmed this fixed it for me. I found the specific "something" that wasn't happening in time. The `initialize_interpreter()` pybind11 function has this comment: Initialize the Python interpreter. No other pybind11 or CPython API functions can be called before this is done; with the exception of `PYBIND11_EMBEDDED_MODULE`. We don't call `initialize_interpreter()` until `PythonModule::initialise()` gets called, so anything that calls into python before that point (i.e. the py::dict constructor) is prone to failure. I'm guessing the py::module member is fine to leave alone since they left an exception for the PYBIND11_EMBEDDED_MODULE macro. I think we can put this one to bed. |
|
|
Nice, thanks for the confirmation and the research. |
- Anonymous
