View Issue Details

IDProjectCategoryView StatusLast Update
0005482DarkRadiantGUIpublic22.01.2021 11:44
ReporterDragofer Assigned Togreebo  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionreopened 
Product Version2.10.0 
Target Version2.11.0Fixed in Version2.11.0 
Summary0005482: List model definitions in Model Chooser
DescriptionMost animated models can only be used if they're part of a model definition that provides important information about which animations and channels are used by the model. Entities' "model" spawnargs refer to model definitions, not the models themselves.

Currently, DR doesn't seem to list available model definitons anywhere. For regular mapping with stock assets this doesn't matter too much because the safest way to switch to another AI model is to switch the classname. However, for mappers working with custom AIs and devs doing maintenance, it'd be quite useful to see which model definitions are available. It'd probably make most sense to list them in the model chooser.

For example, for 0005332, it'd be useful to know whether the model definition exists and is misconfigured (also, in which file it's defined), or it doesn't exist at all.
TagsNo tags attached.

Relationships

related to 0005332 resolvedDragofer The Dark Mod Dice thrower model missing 
related to 0005221 closedDragofer DarkRadiant 'Choose model...' on AIs opens model chooser without any model selected 

Activities

greebo

greebo

05.01.2021 07:19

administrator   ~0013368

modeldefs.png (164,551 bytes)   
modeldefs.png (164,551 bytes)   
Dragofer

Dragofer

05.01.2021 10:14

developer   ~0013372

Last edited: 05.01.2021 10:54

View 4 revisions

Thanks! I think the base assets should be retrofitted with some "editor_displayFolder" entries by TDM devs to organise this list - assuming it works the same way as with entityDefs.
Edit: doesn't look like this will work without updating TDM's source, as it crashes to menu if it finds unknown tokens in modelDefs. I suppose the only available option is to make them use the same folder structure as their .md5meshes.

So it looks like there's a new top-level now - might be good to let the model chooser start with "models" expanded and "Model Definitions" collapsed, since the former will be used more frequently.

What bugs me a little is that Model Definitons is in upper-case while models is in lower-case. Definitely trivial.
Dragofer

Dragofer

16.01.2021 09:59

developer   ~0013459

Just setting this back to feedback because it contains some of my feedback for the new model definition listing in DR 2.11pre1.
greebo

greebo

17.01.2021 06:06

administrator   ~0013471

So, you want to have the "Model Definitions" renamed to "modelDefs"? And to have it collapsed at startup?
Dragofer

Dragofer

17.01.2021 11:38

developer   ~0013474

Yes, that covers 2 of the points. For the 3rd point, I think in an ideal world the modelDefs would mirror the folder structure of their parent .md5's so that there's some more structure in the list, but what we've got so far already more than enough covers what's needed.

Related Changesets

DarkRadiant: master 7962a673

2021-01-04 17:35:09

greebo

Details Diff
0005482: Add forEachModelDef() overload accepting function objects Affected Issues
0005482
mod - include/ieclass.h Diff File
mod - radiantcore/eclass/EClassManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.h Diff File

DarkRadiant: master b1340f3d

2021-01-05 03:24:56

greebo

Details Diff
0005482: Add separate folder in ModelSelector containing the modelDef declarations Affected Issues
0005482
mod - radiant/ui/modelselector/ModelDataInserter.h Diff File
mod - radiant/ui/modelselector/ModelPopulator.h Diff File

DarkRadiant: master 86d6a97c

2021-01-05 04:46:00

greebo

Details Diff
0005482: Refactor MediaBrowserTreeView sort algorithm, which now extends the folder comparison function only, re-using the rest of the SortModelFoldersFirst algorithm. Affected Issues
0005482
mod - libs/wxutil/dataview/TreeModel.cpp Diff File
mod - libs/wxutil/dataview/TreeModel.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File

DarkRadiant: master 192c9b8c

2021-01-05 04:51:15

greebo

Details Diff
0005482: Implement special sorting for the "Model Definitions" folder in the ModelSelector Affected Issues
0005482
mod - radiant/ui/modelselector/ModelDataInserter.h Diff File
mod - radiant/ui/modelselector/ModelPopulator.h Diff File
mod - radiant/ui/modelselector/ModelTreeView.h Diff File

DarkRadiant: master 81bc118c

2021-01-05 07:06:29

greebo

Details Diff
0005482: Extend IModelDef interface by an additional defFilename property Affected Issues
0005482
mod - include/ieclass.h Diff File
mod - radiantcore/eclass/Doom3ModelDef.h Diff File
mod - radiantcore/eclass/EClassManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.h Diff File

DarkRadiant: master 84965611

2021-01-05 07:13:17

greebo

Details Diff
0005482: Display the .def filename the modelDef is declared in Affected Issues
0005482
mod - radiant/ui/modelselector/ModelSelector.cpp Diff File
mod - radiantcore/eclass/Doom3ModelDef.h Diff File

DarkRadiant: master d1544f3b

2021-01-05 12:01:34

greebo

Details Diff
0005482: Linux build fixes Affected Issues
0005482
mod - radiant/ui/modelselector/ModelSelector.cpp Diff File

DarkRadiant: master 8232148f

2021-01-22 11:43:20

greebo

Details Diff
0005482: Rename "Model Definitions" to "modelDefs". Collapse the modelDefs folder after population is finished. Affected Issues
0005482
mod - radiant/ui/modelselector/ModelPopulator.h Diff File
mod - radiant/ui/modelselector/ModelSelector.cpp Diff File
mod - radiant/ui/modelselector/ModelTreeView.cpp Diff File
mod - radiant/ui/modelselector/ModelTreeView.h Diff File

Issue History

Date Modified Username Field Change
03.01.2021 15:47 Dragofer New Issue
03.01.2021 15:53 Dragofer Relationship added related to 0005221
03.01.2021 17:30 greebo Relationship added related to 0005332
03.01.2021 17:30 greebo Status new => acknowledged
05.01.2021 07:14 greebo Assigned To => greebo
05.01.2021 07:14 greebo Status acknowledged => assigned
05.01.2021 07:14 greebo Target Version => 2.11.0
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master 7962a673
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master b1340f3d
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master 86d6a97c
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master 192c9b8c
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master 81bc118c
05.01.2021 07:15 greebo Changeset attached => DarkRadiant master 84965611
05.01.2021 07:15 greebo Status assigned => resolved
05.01.2021 07:15 greebo Resolution open => fixed
05.01.2021 07:15 greebo Fixed in Version => 2.11.0
05.01.2021 07:19 greebo Note Added: 0013368
05.01.2021 07:19 greebo File Added: modeldefs.png
05.01.2021 10:14 Dragofer Note Added: 0013372
05.01.2021 10:15 Dragofer Note View State: 0013372: private
05.01.2021 10:15 Dragofer Note View State: 0013372: public
05.01.2021 10:16 Dragofer Note Edited: 0013372 View Revisions
05.01.2021 10:18 Dragofer Note Edited: 0013372 View Revisions
05.01.2021 10:54 Dragofer Note Edited: 0013372 View Revisions
05.01.2021 12:01 greebo Changeset attached => DarkRadiant master d1544f3b
16.01.2021 09:59 Dragofer Status resolved => feedback
16.01.2021 09:59 Dragofer Resolution fixed => reopened
16.01.2021 09:59 Dragofer Note Added: 0013459
17.01.2021 06:06 greebo Note Added: 0013471
17.01.2021 11:38 Dragofer Note Added: 0013474
17.01.2021 11:38 Dragofer Status feedback => assigned
22.01.2021 11:44 greebo Changeset attached => DarkRadiant master 8232148f
22.01.2021 11:44 greebo Status assigned => resolved