View Issue Details

IDProjectCategoryView StatusLast Update
0005504DarkRadiantShader Systempublic31.07.2022 08:54
ReporterDragofer Assigned Togreebo  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.0 
Target Version3.1.0Fixed in Version3.1.0 
Summary0005504: Reload Defs is not sufficient for reloading modelDefs
DescriptionIn order to reload modelDefs successfully, one has to perform both "Reload Defs" and "Reload Models", in that order. It doesn't really make sense to have to reload models too, since a modelDef only points to a model file, similar to an entityDef.
TagsNo tags attached.

Relationships

related to 0005977 resolvedgreebo Improve Declaration Block Parsing 
related to 0006035 resolvedgreebo Models are reset to origin after reloadDecls 
related to 0006036 resolvedgreebo Entities referring to modelDefs should use the "idle" pose where possible 

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: declmanager 51dcf7c3

2022-07-22 08:47:26

greebo

Details Diff
0005504: ModelCache refactoring Affected Issues
0005504
mod - radiantcore/model/ModelCache.cpp Diff File

DarkRadiant: master cdb928e0

2022-07-31 05:48:21

greebo

Details Diff
0005504: Add a couple of unit tests covering the child model nodes of entities with a certain model key. Affected Issues
0005504
mod - test/MaterialExport.cpp Diff File
mod - test/Models.cpp Diff File
mod - test/algorithm/FileUtils.h Diff File
mod - test/resources/tdm/def/entity_with_model.def Diff File
add - test/resources/tdm/models/md5/flag01.md5mesh Diff File
mod - test/testutil/TemporaryFile.h Diff File

DarkRadiant: master 849a1e91

2022-07-31 07:04:43

greebo

Details Diff
0005504: The entity ModelKey is now resolving modelDefs on its own instead of relying that the ModelCache is doing the job for it.
ModelKey is subscribing to modelDef changes and refreshes the model node on change.
Affected Issues
0005504
mod - radiantcore/entity/ModelKey.cpp Diff File
mod - radiantcore/entity/ModelKey.h Diff File

DarkRadiant: master ccb7e3e7

2022-07-31 07:10:48

greebo

Details Diff
0005504: Add another test checking that the ModelKey is reacting to a modelDef syntax block change Affected Issues
0005504
mod - test/Models.cpp Diff File

DarkRadiant: master fae7d835

2022-07-31 07:27:19

greebo

Details Diff
0005504: Unit test checking that the modelDef is monitored for changes after an undo operation Affected Issues
0005504
mod - test/Models.cpp Diff File

DarkRadiant: master 9c712b60

2022-07-31 08:53:45

greebo

Details Diff
0006035: Add unit test covering the regression introduced in 0005504 Affected Issues
0005504, 0006035
mod - test/Models.cpp Diff File
mod - test/algorithm/Scene.h Diff File

Issue History

Date Modified Username Field Change
24.01.2021 17:53 Dragofer New Issue
24.01.2021 18:13 greebo Status new => acknowledged
07.07.2022 07:47 greebo Relationship added related to 0005977
22.07.2022 08:37 greebo Assigned To => greebo
22.07.2022 08:37 greebo Status acknowledged => assigned
22.07.2022 08:37 greebo Target Version => 3.1.0
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager 51dcf7c3
31.07.2022 08:18 greebo Changeset attached => DarkRadiant master cdb928e0
31.07.2022 08:18 greebo Changeset attached => DarkRadiant master 849a1e91
31.07.2022 08:18 greebo Changeset attached => DarkRadiant master ccb7e3e7
31.07.2022 08:18 greebo Changeset attached => DarkRadiant master fae7d835
31.07.2022 08:24 greebo Status assigned => resolved
31.07.2022 08:24 greebo Resolution open => fixed
31.07.2022 08:24 greebo Fixed in Version => 3.1.0
31.07.2022 08:29 greebo Relationship added related to 0006035
31.07.2022 08:34 greebo Relationship added related to 0006036
31.07.2022 08:54 greebo Changeset attached => DarkRadiant master 9c712b60