View Issue Details

IDProjectCategoryView StatusLast Update
0005571DarkRadiantRendererpublic27.11.2021 09:20
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status closedResolutionfixed 
Product Version2.11.0 
Target Version2.12.0Fixed in Version2.12.0 
Summary0005571: Table lookup evaluation is not producing the same results as in the engine
DescriptionIt can be seen when assigning the material "textures/darkmod/nature/foliage/dry_brush_01", the slow time-based rotate expression is causing weird projections half of the time.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master d068f28b

2021-03-22 18:07:06

greebo

Details Diff
0005571: Add unit test checking a specific sinTable lookup I happened to debug Affected Issues
0005571
mod - test/Materials.cpp Diff File
mod - test/resources/tdm/materials/parsertest.mtr Diff File

DarkRadiant: master 11d8e0cd

2021-03-23 04:06:04

greebo

Details Diff
0005571: Add two failing unit tests due to a problem with tables using negative lookup expressions Affected Issues
0005571
mod - test/Materials.cpp Diff File
mod - test/resources/tdm/materials/parsertest.mtr Diff File

DarkRadiant: master d7161cbe

2021-03-23 04:36:40

greebo

Details Diff
0005571: Add ITableDefinition interface for table decls to make them unit-testable. Add more test coverage (tests are failing). Affected Issues
0005571
mod - include/ishaders.h Diff File
mod - radiantcore/shaders/Doom3ShaderSystem.cpp Diff File
mod - radiantcore/shaders/Doom3ShaderSystem.h Diff File
mod - radiantcore/shaders/ShaderExpression.cpp Diff File
mod - radiantcore/shaders/ShaderExpression.h Diff File
mod - radiantcore/shaders/ShaderLibrary.cpp Diff File
mod - radiantcore/shaders/ShaderLibrary.h Diff File
mod - radiantcore/shaders/TableDefinition.h Diff File
mod - radiantcore/shaders/TextureMatrix.cpp Diff File
mod - test/Materials.cpp Diff File

DarkRadiant: master e2523b84

2021-03-23 05:53:46

greebo

Details Diff
0005571: Fix table lookup implementation (non-snapped) Affected Issues
0005571
mod - radiantcore/shaders/TableDefinition.cpp Diff File

DarkRadiant: master 5924fa78

2021-03-23 06:11:27

greebo

Details Diff
0005571: Fix table lookup implementation (clamped) Affected Issues
0005571
mod - radiantcore/shaders/TableDefinition.cpp Diff File
mod - test/Materials.cpp Diff File
mod - test/resources/tdm/materials/tables.mtr Diff File

DarkRadiant: master 67f0169f

2021-03-23 06:20:09

greebo

Details Diff
0005571: Fix table lookup implementation (snapped) Affected Issues
0005571
mod - radiantcore/shaders/TableDefinition.cpp Diff File
mod - test/Materials.cpp Diff File
mod - test/resources/tdm/materials/tables.mtr Diff File

Issue History

Date Modified Username Field Change
23.03.2021 05:52 greebo New Issue
23.03.2021 05:52 greebo Assigned To => greebo
23.03.2021 05:52 greebo Status new => assigned
23.03.2021 05:54 greebo Changeset attached => DarkRadiant master d068f28b
23.03.2021 05:54 greebo Changeset attached => DarkRadiant master 11d8e0cd
23.03.2021 05:54 greebo Changeset attached => DarkRadiant master d7161cbe
23.03.2021 05:54 greebo Changeset attached => DarkRadiant master e2523b84
23.03.2021 06:21 greebo Changeset attached => DarkRadiant master 5924fa78
23.03.2021 06:21 greebo Changeset attached => DarkRadiant master 67f0169f
23.03.2021 06:22 greebo Status assigned => resolved
23.03.2021 06:22 greebo Resolution open => fixed
23.03.2021 06:22 greebo Fixed in Version => 2.12.0
27.11.2021 09:20 greebo Status resolved => closed