View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005700 | DarkRadiant | GUI | public | 09.08.2021 15:04 | 13.01.2024 05:34 |
Reporter | Dragofer | Assigned To | greebo | ||
Priority | normal | Severity | normal | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.12.0 | ||||
Target Version | 3.7.0 | Fixed in Version | 3.7.0 | ||
Summary | 0005700: Entity inspector spawnarg fields not always updated by UI windows such as Model Chooser | ||||
Description | There are a variety of pop-up UIs that help to set values for spawnargs, such as the colour chooser for "_color" and the model chooser for "model". Clicking "OK" in these UIs sets a new value for the spawnarg on that entity. The problem is that if the UI was accessed from a different entity, the Entity Inspector fails to update the field where mappers can manually enter a value. The mapper might not realise this and unintentionally use the checkmark to apply this outdated value to further entities. It's the same kind of energy as 0005092, where these UIs would apply their values to the entity where the UI was accessed from instead of the currently selected entity. | ||||
Steps To Reproduce | 1) Create 2 models of type barrel01.lwo and place them side by side. 2) Assign spawnarg "_color" "1 1 1" to the left barrel. Click on this spawnarg in the Entity Inspector and open the "Colour" UI. 3) Under "Basic colours", click on a tile with a red pre-made colour and click OK. The left barrel's _color spawnarg is now "1.000 0.000 0.000", and so is the value in the field next to the checkmark where a value can be entered manually. 4) Use Shift + Alt + LMB to switch your selection to the right barrel. 5) Open the "Colour" UI again, click on a tile with a green pre-made colour and click OK. The right barrel's _color spawnarg is now "0.000 1.000 0.000", but the field for manual entry still has the old value of "1.000 0.000 0.000". If the mapper clicks the checkmark to apply the _color spawnarg to further entities, he'd be applying the old, red value. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
In fact, the 'Entity Chooser' doesn't ever seem to update the field for manual entry. Repro is even simpler here: 1) Create a func_static model: barrel01.lwo 2) Select the barrel, click on the "classname" spawnarg in the Entity Inspector and click on "Choose entity class..." 3) Select a different class from the list, i.e. func_fx, and click OK. The selected entity's classname has changed correctly, but the field for manual entry still says "func_static". |
|
DarkRadiant: master 0b7c6019 13.11.2022 06:00 Details Diff |
0005700: Change IEntitySelection::foreachEntity signature to hand out the IEntityNodes instead of the contained Entity |
Affected Issues 0005700 |
|
mod - include/ientity.h | Diff File | ||
mod - libs/selection/EntitySelection.h | Diff File | ||
mod - plugins/dm.editing/AIHeadPropertyEditor.cpp | Diff File | ||
mod - plugins/dm.editing/AIVocalSetPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/EntityInspector.cpp | Diff File | ||
mod - radiant/ui/einspector/PropertyEditor.cpp | Diff File | ||
DarkRadiant: master 2236a9e5 13.11.2022 06:00 Details Diff |
0005700: Use the IEntitySelection interface in ModelPropertyEditor to set the "model" key on the selection |
Affected Issues 0005700 |
|
mod - radiant/ui/einspector/ModelPropertyEditor.cpp | Diff File | ||
DarkRadiant: master b6a9a927 13.11.2022 06:15 Details Diff |
0005700: Add a feedback signal to the IPropertyEditor interface to get notified when key values have been set |
Affected Issues 0005700 |
|
mod - include/ui/ientityinspector.h | Diff File | ||
mod - plugins/dm.editing/AIHeadPropertyEditor.cpp | Diff File | ||
mod - plugins/dm.editing/AIHeadPropertyEditor.h | Diff File | ||
mod - plugins/dm.editing/AIVocalSetPropertyEditor.cpp | Diff File | ||
mod - plugins/dm.editing/AIVocalSetPropertyEditor.h | Diff File | ||
mod - radiant/ui/einspector/PropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/PropertyEditor.h | Diff File | ||
DarkRadiant: master e0ce5a13 13.11.2022 06:22 Details Diff |
0005700: Rename the PropertyEditor base method for clarity |
Affected Issues 0005700 |
|
mod - radiant/ui/einspector/AnglePropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/BooleanPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/ColourPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/EntityPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/FloatPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/ModelPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/PropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/PropertyEditor.h | Diff File | ||
mod - radiant/ui/einspector/SkinPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/SoundPropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/TexturePropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/Vector3PropertyEditor.cpp | Diff File | ||
DarkRadiant: master 7a3b4a0b 13.11.2022 07:01 Details Diff |
0005700: Connect to the IPropertyEditor's signal to get notified on value changes |
Affected Issues 0005700 |
|
mod - radiant/ui/einspector/EntityInspector.cpp | Diff File | ||
mod - radiant/ui/einspector/EntityInspector.h | Diff File | ||
DarkRadiant: master be59fb2d 13.11.2022 07:11 Details Diff |
0005700: Sync the value in the entry box when a property editor is applying a matching key |
Affected Issues 0005700 |
|
mod - radiant/ui/einspector/ClassnamePropertyEditor.cpp | Diff File | ||
mod - radiant/ui/einspector/EntityInspector.cpp | Diff File | ||
DarkRadiant: master 44c2e196 13.11.2022 07:12 Details Diff |
0005700: FX Property Editor fires the applied key value signal |
Affected Issues 0005700 |
|
mod - radiant/ui/einspector/FxPropertyEditor.cpp | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
09.08.2021 15:04 | Dragofer | New Issue | |
09.08.2021 15:04 | Dragofer | File Added: image.png | |
09.08.2021 15:06 | Dragofer | Summary | Entity inspector spawnargs not always updated by UI windows such as Model Chooser => Entity inspector spawnarg fields not always updated by UI windows such as Model Chooser |
09.08.2021 15:06 | Dragofer | Description Updated | |
09.08.2021 15:06 | Dragofer | Relationship added | related to 0005092 |
09.08.2021 15:07 | greebo | Status | new => acknowledged |
09.08.2021 15:09 | Dragofer | Steps to Reproduce Updated | |
09.08.2021 19:38 | greebo | Status | acknowledged => confirmed |
10.08.2021 13:07 | Dragofer | Note Added: 0014276 | |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master 0b7c6019 |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master 2236a9e5 |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master b6a9a927 |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master e0ce5a13 |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master 7a3b4a0b |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master be59fb2d |
13.11.2022 07:12 | greebo | Changeset attached | => DarkRadiant master 44c2e196 |
13.11.2022 07:13 | greebo | Assigned To | => greebo |
13.11.2022 07:13 | greebo | Status | confirmed => assigned |
13.11.2022 07:13 | greebo | Target Version | => 3.7.0 |
13.11.2022 07:13 | greebo | Status | assigned => resolved |
13.11.2022 07:13 | greebo | Resolution | open => fixed |
13.11.2022 07:13 | greebo | Fixed in Version | => 3.7.0 |
13.01.2024 05:34 | greebo | Status | resolved => closed |