View Issue Details

IDProjectCategoryView StatusLast Update
0005780DarkRadiantDesign/Codingpublic14.10.2021 10:17
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version2.13.0 
Target Version2.14.0Fixed in Version2.14.0 
Summary0005780: Remove IDialogManager references from Map module
DescriptionThere's a reference to the GlobalDialogManager in the core map module. Accessing UI classes from core modules should not happen directly, instead messages or requests should be sent through the MessageBus.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

DarkRadiant: master d5021f0f

2021-10-14 03:49:02

greebo

Details Diff
0005780: Define new message type Affected Issues
0005780
mod - include/imessagebus.h Diff File
add - libs/messages/FileSaveConfirmation.h Diff File
mod - tools/msvc/libs.vcxproj Diff File
mod - tools/msvc/libs.vcxproj.filters Diff File

DarkRadiant: master 2776128a

2021-10-14 09:10:41

greebo

Details Diff
0005780: Set up a couple of unit tests against the NewMap command and the confirmation message to save/discard/cancel Affected Issues
0005780
mod - test/MapSavingLoading.cpp Diff File
mod - test/algorithm/Primitives.h Diff File

DarkRadiant: master 3d77e54b

2021-10-14 09:21:46

greebo

Details Diff
0005780: Add FileSaveConfirmationHandler to UI module. Map module is now sending the FileSaveConfirmation to query the user's intent, remove the corresponding UI references from Map.cpp. Affected Issues
0005780
add - radiant/ui/FileSaveConfirmationHandler.h Diff File
mod - radiant/ui/UserInterfaceModule.cpp Diff File
mod - radiant/ui/UserInterfaceModule.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - tools/msvc/DarkRadiant.vcxproj Diff File
mod - tools/msvc/DarkRadiant.vcxproj.filters Diff File

DarkRadiant: master fd81b0df

2021-10-14 09:45:44

greebo

Details Diff
0005780: Refactoring Affected Issues
0005780
mod - test/MapSavingLoading.cpp Diff File

DarkRadiant: master 25748d0a

2021-10-14 09:57:28

greebo

Details Diff
0005780: Expand unit tests to the "OpenMap" command Affected Issues
0005780
mod - test/MapSavingLoading.cpp Diff File

DarkRadiant: master 7ac37265

2021-10-14 10:01:45

greebo

Details Diff
0005780: Expand unit tests to the "OpenMapFromArchive" command Affected Issues
0005780
mod - test/MapSavingLoading.cpp Diff File

DarkRadiant: master bb62960f

2021-10-14 10:13:02

greebo

Details Diff
0005780: Simulate the radiant app shutdown scenario in the unit tests. The Map module should ask for saving and deny the shutdown request on cancel. Affected Issues
0005780
mod - test/MapSavingLoading.cpp Diff File

DarkRadiant: master b5eaa87c

2021-10-14 10:15:59

greebo

Details Diff
0005780: Unsubscribe the FileSaveConfirmationHandler on shutdown Affected Issues
0005780
mod - radiant/ui/UserInterfaceModule.cpp Diff File

Issue History

Date Modified Username Field Change
14.10.2021 03:47 greebo New Issue
14.10.2021 03:48 greebo Assigned To => greebo
14.10.2021 03:48 greebo Status new => assigned
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master d5021f0f
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master 2776128a
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master 3d77e54b
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master fd81b0df
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master 25748d0a
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master 7ac37265
14.10.2021 10:13 greebo Changeset attached => DarkRadiant master bb62960f
14.10.2021 10:16 greebo Changeset attached => DarkRadiant master b5eaa87c
14.10.2021 10:17 greebo Target Version => 2.14.0
14.10.2021 10:17 greebo Status assigned => resolved
14.10.2021 10:17 greebo Resolution open => fixed
14.10.2021 10:17 greebo Fixed in Version => 2.14.0