View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005827DarkRadiantGUIpublic29.11.2021 16:3613.01.2024 05:34
ReporterDragofer Assigned Toorbweaver  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version2.14.0 
Fixed in Version3.8.0 
Summary0005827: Better distinction between inherited and regular spawnargs
DescriptionInherited spawnargs look quite similar to regular spawnargs now, with the only difference being that inherited spawnargs are written in a cursive font. There's a chance the mapper might accidentally be working with the wrong type of spawnarg.

Maybe inherited spawnargs' text could be drawn in a lighter font and/or their icons drawn in grayscale?

An alternative, hiding the inherited spawnargs when a regular version of that spawnarg is present, would probably not be very robust since the mapper may sometimes need to see what the inherited value for the spawnarg was.
TagsNo tags attached.

Activities

orbweaver

orbweaver

12.12.2021 20:54

developer   ~0014587

We used to change the colour but this turned out to be problematic, because forced colours don't work well with GUI themes. One option would be to use additional textual changes, e.g. listing the keys as "[inherit]", "[spawnclass]" or something similar. Another option would be to have an extra column with a specific icon for inherited properties.
Dragofer

Dragofer

19.12.2021 12:51

developer   ~0014601

Maybe it'd be least likely to cause confusion if inherited properties were shown in a pop-up version of the entity inspector, thereby keeping them physically separate from the other spawnargs. It sounds like a good amount of work to code and polish, though.

Putting inherited properties in brackets could also be a viable option, but would have to make sure that these brackets don't end up in the spawnarg fields for manual entry when clicking on such a spawnarg.

An icon for inherited spawnargs could work, but at least for me the entity inspector is already quite cramped - particularly in the vertical direction if "Show help" is enabled.
orbweaver

orbweaver

06.12.2022 20:24

developer   ~0015512

Hopefully this is now fixed in a way which will work regardless of desktop theme. Inherited spawnargs are grey again, but the grey colour comes from theme colours rather than a hard-coded RGB value. I've tested with both the light and dark Ubuntu themes and the grey spawnargs are readable in both.

Related Changesets

DarkRadiant: master 032dc98c

19.10.2022 19:40

orbweaver


Details Diff		 0005827: EntityInspector members initialised with inline assignment Affected Issues
0005827
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

DarkRadiant: master fdb7f85c

19.10.2022 20:08

orbweaver


Details Diff		 0005827: ItemValueProxy uses a setAttr() method to set style attributes

Although overloading allows it, "assigning" twice to the same object
to perform two different operations yields very confusing code, and
violates the expectation that an overloaded operator should do something
similar to what the operator would do for a primitive type.		 Affected Issues
0005827
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/dataview/KeyValueTable.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ThreadedDeclarationTreePopulator.h Diff File
mod - libs/wxutil/dataview/TreeModel.h Diff File
mod - plugins/dm.difficulty/DifficultySettings.cpp Diff File
mod - plugins/dm.stimresponse/SREntity.cpp Diff File
mod - radiant/ui/eclasstree/EClassTree.cpp Diff File
mod - radiant/ui/einspector/AddPropertyDialog.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/filters/editor/FilterDialog.cpp Diff File
mod - radiant/ui/layers/LayerControlDialog.cpp Diff File
mod - radiant/ui/materials/editor/MaterialEditor.cpp Diff File
mod - radiant/ui/modelselector/ModelDataInserter.h Diff File
mod - radiant/ui/particles/ParticleEditor.cpp Diff File

DarkRadiant: master bfd015bb

25.10.2022 19:00

orbweaver


Details Diff		 0005827: fix inconsistent tabs/spaces in EntityInspector.h Affected Issues
0005827
mod - radiant/ui/einspector/EntityInspector.h Diff File

DarkRadiant: master 2e2aa177

25.10.2022 19:18

orbweaver


Details Diff		 0005827: move data view columns into a nested struct

Make a clearer distinction between the columns in the TreeModel
(_modelCols) and those used in the display widget (_viewCols).		 Affected Issues
0005827
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

DarkRadiant: master 8f327dca

25.10.2022 19:38

orbweaver


Details Diff		 0005827: use wxSYS_COLOUR_GRAYTEXT for inherited properties

Second attempt at using a different colour for inherited properties.
Instead of using a hard-coded colour (which fails due to the variability
of GTK themes), we now use wxSystemSettings::GetColour() to look up the
colour associated with disabled text (wxSYS_COLOUR_GRAYTEXT).

Testing with both light and dark themes supplied with Ubuntu gives
promising results. Hopefully wxWidgets will supply a valid colour which
is appropriate for the active theme on all systems (including Windows),
but this will need more widespread testing.		 Affected Issues
0005827
mod - libs/wxutil/dataview/TreeViewItemStyle.h Diff File

DarkRadiant: master 4c02bee6

25.10.2022 19:53

orbweaver


Details Diff		 0005827: cleanup inconsistent tabs/spaces in PropertyEditorFactory.cpp Affected Issues
0005827
mod - radiant/ui/einspector/PropertyEditorFactory.cpp Diff File

DarkRadiant: master d7bff980

26.10.2022 19:31

orbweaver


Details Diff		 0005827: thicken and monochromise Vector3 property icon Affected Issues
0005827
mod - install/bitmaps/icon_vector3.png Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File

DarkRadiant: master 40e8a08c

26.10.2022 19:36

orbweaver


Details Diff		 0005827: replace Bool property icon

Hopefully this looks something like a switch. No obvious ideal way to
represent a binary choice iconically, other than using a checkbox which
would be very confusing since we already have an actual checkbox column.		 Affected Issues
0005827
mod - install/bitmaps/icon_bool.png Diff File

DarkRadiant: master c8fe728a

26.10.2022 19:44

orbweaver


Details Diff		 0005827: chunkify and de-serif the Text property icon Affected Issues
0005827
mod - install/bitmaps/icon_text.png Diff File

DarkRadiant: master fc9eb792

26.10.2022 19:54

orbweaver


Details Diff		 0005827: clarify Classname property icon Affected Issues
0005827
mod - install/bitmaps/icon_classname.png Diff File

Issue History

Date Modified Username Field Change
29.11.2021 16:36 Dragofer New Issue
12.12.2021 20:54 orbweaver Assigned To => orbweaver
12.12.2021 20:54 orbweaver Status new => acknowledged
12.12.2021 20:54 orbweaver Note Added: 0014587
19.12.2021 12:51 Dragofer Note Added: 0014601
19.10.2022 19:14 orbweaver Status acknowledged => assigned
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master 032dc98c
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master fdb7f85c
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master bfd015bb
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master 2e2aa177
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master 8f327dca
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master 4c02bee6
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master d7bff980
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master 40e8a08c
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master c8fe728a
11.11.2022 04:25 orbweaver Changeset attached => DarkRadiant master fc9eb792
06.12.2022 20:24 orbweaver Status assigned => resolved
06.12.2022 20:24 orbweaver Resolution open => fixed
06.12.2022 20:24 orbweaver Fixed in Version => 3.8.0
06.12.2022 20:24 orbweaver Note Added: 0015512
13.01.2024 05:34 greebo Status resolved => closed