 |
This is caused by mismatch in num == bodies.Num() in idPhysics_AF::Restore. There is some hack called "m_NumOrigBodies" added back in 2007 by @ishtvan (rev 1421): /** * TDM: Number of _original_ bodies from the loaded AF file * We need this to implement a hack where added bodies aren't saved/loaded, * because they will be added again from scratch on restore. * We must do this because Id chose to re-load the AFs instead of restore them **/ int m_NumOrigBodies; /** * Number of original constraints loaded from this entity's AF file **/ int m_NumOrigConstraints; Which is supposedly reference here: https://forums.thedarkmod.com/index.php?/topic/6248-saving-and-loading/&do=findComment&comment=127049 I'd say that his workaround should better be removed, and we should try to solve the problem properly. |
|
|
Ok, the problem happens because idAF::Load fails to restore with the following console warning: idAF::Load: articulated figure '%s' for entity '%s' at (%s) has no or defaulted modelDef '%s' Of course, nobody has seen it because the execution continues and crashes shortly after that. This happens because animator->ModelDef() is NULL after restoring. So, when game is saved, its animator saves null modelDef. ModelDef is NULL because it is reset when elemental dies. Since it has "model_death" spawnarg, idAI::Killed calls SetModel with some particle model as argument. idAnimator::SetModel clears the old modelDef, and but does not set a new one because particle model (modelname = "imp_explosion_blue.prt") is not a valid modelDef: modelDef = static_cast<const idDeclModelDef *>( declManager->FindType( DECL_MODELDEF, modelname, false ) ); if ( !modelDef ) { return NULL; } It seems that for animated entity, one can only SetModel a modelDef. |
|
|
I guess this is not so easy to fix. First of all, I'd like to apply the provided patch: it forbids changing model of animated entity to something which is not a modelDef. However, before doing this: 1) One has to reimplement death animation of elemental. I'd say it should die immediately, spawning a particle entity to be removed a few seconds after. My attempt was blocked by a dangling thread "rand_osc", which survives after its light is dead (not sure how it is supposed to be terminated). 2) There are two missions which have forked elemental defs, and they must be updated too. AnimatedSetModelModelDef.patch (1,238 bytes) |
 |
Reimplemented death animation by emitting the particle in the world, independently of the elemental entity. Rev 16488. The fix for FMs with forked elemental defs is still pending as laid out here: https://forums.thedarkmod.com/index.php?/topic/21425-5845-elemental-death-animation/&do=findComment&comment=473898 |
|
|
I applied the patch to SVN (rev 9931). Also, I see now that there are three missions with custom elemental def: Black Mage (defined ai_elemental_special is not used, both blue and fire elementals are core ones) Painter's Wife By Any Other Name (can't find any usage of elemental def) |
|
|
Bikerdude wrote: --------------------------------------- 1) removing the blue elemental .def file 2) bumping the "Required version" in darkmod.txt to 2.09 The blue elementals works as expected. --------------------------------------- So I'm closing this. |
|
|
It seems that two missions now get the error, trying to setModel something different from modelDef on animated entity: antr ch1_eaton In antr, there is e.g. func_static_1266: { "classname" "atdm:ambient_head_3" "name" "func_static_1266" "model" "models/md5/chars/heads/npcs/female01_shaggy.md5mesh" "origin" "6329.55 -1615.39 -1194.89" "rotation" "-1.11022e-16 -1 1.11022e-16 -1 1.11022e-16 1.11022e-16 -1.11022e-16 -1.11022e-16 -1" "snd_bounce" "tdm_impact_fish" } This is a scene where woman has no head... When I look at the woman, I get per-frame spam of warnings related to dynamic model... In ch1_eaton, there is e.g. fog1: { "classname" "func_animate" "name" "fog1" "angle" "1.066956" "model" "ea001_etherfog_low.prt" "origin" "2524.77 1097.17 -460" "wait" "5" } No idea what it means: in-game I don't see anything special except for animated trees ta this position. |
|
|
Ok, I committed a fix in svn rev 10061. I limited the condition for error. Now the error happens if both conditions are true: 1) new model is not a modelDef 2) there was a modelDef previously attached Now the two mentioned missions load fine, because p.2 is false there. But if I uncomment model_death on elemental, it still catches the error. |
- Anonymous
