 |
reproduceable in your test map on windows 10 |
|
|
Fixed with revision 9970 |
 |
You also added new script functions. Are you sure it should be called "isPeakLeaning" and not "isPeekLeaning"? Peak leaning is... when you lean by maximum allowed angle?... I see that there is so-called "peek entity", so I suppose it should be "peek". |
|
|
Also, I think it is a bad practice to add script events just because "why not? maybe they'd be useful". In this particular case, getSecondaryListenerLoc event is just wrong: it returns coordinates in meters. The reason this value is in meters is that sound system works in meters, but everything else works in doom units. If you have such and event, it should return coordinates in doom units too. |
|
|
To honest, I think the best fix would be to convert m_SecondaryListenerLoc member to doom units. It is totally wrong to store coordinates in gameplay code in meters. Then, you need to find all usages and remove meters-to-doom or add doom-to-meters conversion at each usage. |
|
|
Regarding the peak vs. peek thing you are obviously right. Mixed them up and will correct that. Regarding the script event: The return distance should indeed be in doom units. It actually didn't came to my mind that they could use meters here (I know they use it for some scalar values, although I have no clue why). Will fix that either. The main reason for adding the event was for simple debugging. So I didn't add it because "why not?", but haven't removed it afterwards because "why?". ;) But as we are at it, why is it a bad practise? Having the player to peek at a door could easely be a mission objective, and this function gives the mapper the required information. We also have script functions for other stuff rarely used, if ever. |
|
|
Fixed with rev 9986. |
|
|
To be honest, I think "second listener pos" is internal value. For instance, there is no event for "primary listener pos", because it is not a gameplay value. Speaking of gameplay, there is player's origin, player's head position, etc. I wonder if there is better value for the case of peeking too. Like e.g. GetListenLoc... |
- Anonymous
