0005934: Selection overlay is z-fighting on patches

ID	Project	Category	View Status	Date Submitted	Last Update

0005934	DarkRadiant	Renderer	public	08.04.2022 15:02	28.10.2022 05:52

Reporter	greebo	Assigned To	greebo
Priority	normal	Severity	normal	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	3.0.0
Target Version	3.0.0	Fixed in Version	3.0.0

Summary	0005934: Selection overlay is z-fighting on patches
Description	A selected curved patch surface is not consistently rendering the red selection overlay
Tags	No tags attached.

greebo

08.04.2022 15:04

administrator ~0014798

grafik.png (87,020 bytes)

zfighting.mapx (3,713 bytes)

<?xml version="1.0" encoding="utf-8"?>
<map version="1" format="portable">
  <layers>
    <layer id="0" name="Default"/>
  </layers>
  <selectionGroups/>
  <selectionSets/>
  <properties>
    <property key="EditTimeInSeconds" value="106"/>
    <property key="LastCameraAngle" value="-30.3 274.5 0"/>
    <property key="LastCameraPosition" value="172.667 482.056 168.76"/>
  </properties>
  <entity number="0">
    <primitives>
      <patch number="0" width="5" height="5" fixedSubdivisions="false">
        <material name="_default"/>
        <controlVertices>
          <controlVertex row="0" column="0" x="-32.000000" y="-80.000000" z="0" u="0" v="0"/>
          <controlVertex row="1" column="0" x="-32.000000" y="16.000000" z="0" u="0" v="-1.000000"/>
          <controlVertex row="2" column="0" x="-32.000000" y="112.000000" z="0" u="0" v="-2.000000"/>
          <controlVertex row="3" column="0" x="-32.000000" y="208.000000" z="0" u="0" v="-3.000000"/>
          <controlVertex row="4" column="0" x="-32.000000" y="304.000000" z="0" u="0" v="-4.000000"/>
          <controlVertex row="0" column="1" x="84.000000" y="-80.000000" z="0" u="1.000000" v="0"/>
          <controlVertex row="1" column="1" x="84.000000" y="16.000000" z="176.000000" u="1.000000" v="-1.000000"/>
          <controlVertex row="2" column="1" x="84.000000" y="112.000000" z="176.000000" u="1.000000" v="-2.000000"/>
          <controlVertex row="3" column="1" x="84.000000" y="208.000000" z="176.000000" u="1.000000" v="-3.000000"/>
          <controlVertex row="4" column="1" x="84.000000" y="304.000000" z="0" u="1.000000" v="-4.000000"/>
          <controlVertex row="0" column="2" x="200.000000" y="-80.000000" z="0" u="2.000000" v="0"/>
          <controlVertex row="1" column="2" x="200.000000" y="16.000000" z="176.000000" u="2.000000" v="-1.000000"/>
          <controlVertex row="2" column="2" x="200.000000" y="112.000000" z="192.000000" u="2.000000" v="-2.000000"/>
          <controlVertex row="3" column="2" x="200.000000" y="208.000000" z="176.000000" u="2.000000" v="-3.000000"/>
          <controlVertex row="4" column="2" x="200.000000" y="304.000000" z="0" u="2.000000" v="-4.000000"/>
          <controlVertex row="0" column="3" x="316.000000" y="-80.000000" z="0" u="3.000000" v="0"/>
          <controlVertex row="1" column="3" x="316.000000" y="16.000000" z="176.000000" u="3.000000" v="-1.000000"/>
          <controlVertex row="2" column="3" x="316.000000" y="112.000000" z="176.000000" u="3.000000" v="-2.000000"/>
          <controlVertex row="3" column="3" x="316.000000" y="208.000000" z="176.000000" u="3.000000" v="-3.000000"/>
          <controlVertex row="4" column="3" x="316.000000" y="304.000000" z="0" u="3.000000" v="-4.000000"/>
          <controlVertex row="0" column="4" x="432.000000" y="-80.000000" z="0" u="4.000000" v="0"/>
          <controlVertex row="1" column="4" x="432.000000" y="16.000000" z="0" u="4.000000" v="-1.000000"/>
          <controlVertex row="2" column="4" x="432.000000" y="112.000000" z="0" u="4.000000" v="-2.000000"/>
          <controlVertex row="3" column="4" x="432.000000" y="208.000000" z="0" u="4.000000" v="-3.000000"/>
          <controlVertex row="4" column="4" x="432.000000" y="304.000000" z="0" u="4.000000" v="-4.000000"/>
        </controlVertices>
        <layers>
          <layer id="0"/>
        </layers>
        <selectionGroups/>
        <selectionSets/>
      </patch>
    </primitives>
    <keyValues>
      <keyValue key="classname" value="worldspawn"/>
    </keyValues>
    <layers>
      <layer id="0"/>
    </layers>
    <selectionGroups/>
    <selectionSets/>
  </entity>
</map>

zfighting.mapx (3,713 bytes)

DarkRadiant: master 4d37b11d 08.04.2022 14:59 greebo Details Diff	0005934: Merge constructNormalShader() method into the call site	Affected Issues 0005934
	mod - radiantcore/rendersystem/backend/OpenGLShader.cpp	Diff File
	mod - radiantcore/rendersystem/backend/OpenGLShader.h	Diff File
DarkRadiant: master 136a90ba 09.04.2022 05:08 greebo Details Diff	0005934: Separate renderables for selection colour overlay and outline overlay. Use the triangulated mesh to render the colour overlay to fix z-fighting. Rendering the quadrangulated surface on top of the triangulated one made the overlay spotty on a curved mesh.	Affected Issues 0005934
	mod - radiantcore/patch/PatchNode.cpp	Diff File

Date Modified	Username	Field	Change
08.04.2022 15:02	greebo	New Issue
08.04.2022 15:04	greebo	Note Added: 0014798
08.04.2022 15:04	greebo	File Added: grafik.png
08.04.2022 15:04	greebo	File Added: zfighting.mapx
08.04.2022 15:05	greebo	Status	new => confirmed
09.04.2022 05:06	greebo	Assigned To	=> greebo
09.04.2022 05:06	greebo	Status	confirmed => assigned
09.04.2022 05:09	greebo	Changeset attached	=> DarkRadiant master 4d37b11d
09.04.2022 05:09	greebo	Changeset attached	=> DarkRadiant master 136a90ba
09.04.2022 05:09	greebo	Status	assigned => resolved
09.04.2022 05:09	greebo	Resolution	open => fixed
09.04.2022 05:09	greebo	Fixed in Version	=> 3.0.0
28.10.2022 05:52	greebo	Status	resolved => closed

View Issue Details

Activities

Related Changesets

Issue History