View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005950 | DarkRadiant | Renderer | public | 01.05.2022 02:59 | 05.01.2023 16:25 |
| Reporter | greebo | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0.0 | ||||
| Fixed in Version | 3.0.0 | ||||
| Summary | 0005950: Visibility checks are slowing down front-end render pass | ||||
| Description | This method checks to see if any of the face components are selected, which turns out to be an expensive call (around 7% of the front-end render pass). Since all component selection changes are sent to the BrushNode anyway, it might as well keep track of the number of selected components itself. On top of that, some PatchNode::onPreRender checks are superfluous and can be removed too. | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master aeb7d546 30.04.2022 18:40 Details Diff |
0005950: Remove dead code |
Affected Issues 0005950 |
|
| mod - radiantcore/rendersystem/backend/FullBrightRenderer.cpp | Diff File | ||
|
DarkRadiant: master 8fd6b44b 30.04.2022 18:54 Details Diff |
0005950: Remove visibility check from PatchNode::onPreRender. Node visibility is already checked by the front end walker, Material visibility is checked by the backend renderer. |
Affected Issues 0005950 |
|
| mod - radiantcore/patch/PatchNode.cpp | Diff File | ||
|
DarkRadiant: master a1504794 30.04.2022 19:13 Details Diff |
0005950: BrushNode keeps track of selected components to avoid iterating over all face instances every time. This part of the front-end pass took 7% of the frame time in a medium-sized map. |
Affected Issues 0005950 |
|
| mod - radiantcore/brush/BrushNode.cpp | Diff File | ||
| mod - radiantcore/brush/BrushNode.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 01.05.2022 02:59 | greebo | New Issue | |
| 01.05.2022 02:59 | greebo | Assigned To | => greebo |
| 01.05.2022 02:59 | greebo | Status | new => assigned |
| 01.05.2022 03:01 | greebo | Summary | BrushNode::getHighlightFlags is slowing down front-end render pass => Visibility checks are slowing down front-end render pass |
| 01.05.2022 03:01 | greebo | Description Updated | |
| 01.05.2022 05:02 | greebo | Changeset attached | => DarkRadiant master aeb7d546 |
| 01.05.2022 05:02 | greebo | Changeset attached | => DarkRadiant master 8fd6b44b |
| 01.05.2022 05:02 | greebo | Changeset attached | => DarkRadiant master a1504794 |
| 01.05.2022 06:03 | greebo | Status | assigned => resolved |
| 01.05.2022 06:03 | greebo | Resolution | open => fixed |
| 01.05.2022 06:03 | greebo | Fixed in Version | => 3.0.0 |
| 05.01.2023 16:25 | greebo | Status | resolved => closed |
