View Issue Details

IDProjectCategoryView StatusLast Update
0006002DarkRadiantGUIpublic22.07.2022 10:17
ReporterDragofer Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.0.0 
Target Version3.1.0Fixed in Version3.1.0 
Summary0006002: Remove comments about particle generator in .prt files
DescriptionEach particle definition generated by DR comes with the following message:

/*
    Generated by the Particle Editor.
    To use the particle editor, launch the game and type 'editParticles' on the console.
*/

This message is outdated as DR's Particle Editor is far superior to the ingame version, and I don't think such a message is necessary anyway. It'd probably make sense to stop adding this message in order to clear up .prt files.
TagsNo tags attached.

Relationships

related to 0005977 resolvedgreebo Improve Declaration Block Parsing 

Activities

greebo

greebo

10.07.2022 05:13

administrator   ~0015002

Last edited: 10.07.2022 05:13

The message has not been generated by DR, its comment text is like this: "Generated by DarkRadiant's Particle Editor"
I assume the message is attached to a particle block that has been created earlier.

But I agree we can change the code to not leave any comment leading in new particle blocks.

Related Changesets

DarkRadiant: declmanager fc33ff61

2022-07-10 15:33:23

greebo

Details Diff
0006002: Replace the old ParticlesManager::saveParticleDef algorithm with a call to IDeclarationManager::saveDeclaration. This also resolves the request to remove the comments above the particle declarations. Affected Issues
0006002
mod - include/iparticles.h Diff File
mod - radiantcore/particles/ParticlesManager.cpp Diff File

Issue History

Date Modified Username Field Change
09.07.2022 17:33 Dragofer New Issue
10.07.2022 05:10 greebo Status new => acknowledged
10.07.2022 05:13 greebo Note Added: 0015002
10.07.2022 05:13 greebo Note Edited: 0015002
10.07.2022 15:29 greebo Relationship added related to 0005977
10.07.2022 15:29 greebo Assigned To => greebo
10.07.2022 15:29 greebo Status acknowledged => assigned
10.07.2022 15:35 greebo Changeset attached => DarkRadiant declmanager fc33ff61
22.07.2022 10:17 greebo Target Version => 3.1.0
22.07.2022 10:17 greebo Status assigned => resolved
22.07.2022 10:17 greebo Resolution open => fixed
22.07.2022 10:17 greebo Fixed in Version => 3.1.0