View Issue Details

IDProjectCategoryView StatusLast Update
0006003DarkRadiantGUIpublic22.07.2022 10:16
ReporterDragofer Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.0.0 
Target Version3.1.0Fixed in Version3.1.0 
Summary0006003: "Reload Defs" doesn't remove entities that have been commented out
DescriptionIf "Reload Defs" is used after an entityDef has been commented out in a .def file, the entity will still be shown in the Entity Chooser. Only restarting DR will clear that entity from the list.
Steps To Reproduce1) Open the Entity Chooser and find an entity that you want to comment out (i.e. atdm:nature_pine).
2) In the .def file where it's defined, comment it out with /* and */.
3) In DR, click "Reload Defs" and open the Entity Chooser again. The entity is still available.
TagsNo tags attached.

Relationships

related to 0005977 resolvedgreebo Improve Declaration Block Parsing 

Activities

greebo

greebo

10.07.2022 05:15

administrator   ~0015003

Yes, entityDef declarations are never really removed from memory to leave references intact, even after they disappear from the source files. What I can do though is to change the parser to hide these declarations from the tree views - in fact I think in the declmanager branch this might already be the case. I'll have a unit test added to ensure this issue is resolved.

Related Changesets

DarkRadiant: declmanager add7a9d3

2022-07-22 09:49:14

greebo

Details Diff
0006003: Add unit test checking that a declaration that is removed in the course of reloadDecls has its visibility set to hidden Affected Issues
0006003
mod - test/DeclManager.cpp Diff File

DarkRadiant: declmanager 06623764

2022-07-22 09:55:00

greebo

Details Diff
0006003: EntityClass visibility is reporting as hidden if the declaration is defined in a hidden VFS file. Otherwise rely on the information in the key/value pairs Affected Issues
0006003
mod - radiantcore/eclass/EntityClass.cpp Diff File

DarkRadiant: declmanager a27f342d

2022-07-22 09:58:28

greebo

Details Diff
0006003: Reset the lazy-evaluated visibility once the entity class is finished parsing its contents Affected Issues
0006003
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File

DarkRadiant: declmanager f05a410d

2022-07-22 10:05:29

greebo

Details Diff
0006003: One more test checking the IEntityClass:getVisibility() method result Affected Issues
0006003
mod - test/EntityClass.cpp Diff File

DarkRadiant: declmanager 3439ef31

2022-07-22 10:10:17

greebo

Details Diff
0006003: Add test checking that changing the editor_visibility is reevaluated after reloadDecls. Affected Issues
0006003
mod - test/EntityClass.cpp Diff File

DarkRadiant: declmanager f9f8f6bc

2022-07-22 10:15:18

greebo

Details Diff
0006003: Ensure that the def is parsed before evaluating the visibility Affected Issues
0006003
mod - radiantcore/eclass/EntityClass.cpp Diff File

Issue History

Date Modified Username Field Change
09.07.2022 19:35 Dragofer New Issue
10.07.2022 05:15 greebo Status new => acknowledged
10.07.2022 05:15 greebo Note Added: 0015003
10.07.2022 05:15 greebo Relationship added related to 0005977
22.07.2022 08:53 greebo Assigned To => greebo
22.07.2022 08:53 greebo Status acknowledged => assigned
22.07.2022 08:53 greebo Target Version => 3.1.0
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager add7a9d3
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager 06623764
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager a27f342d
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager f05a410d
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager 3439ef31
22.07.2022 10:15 greebo Changeset attached => DarkRadiant declmanager f9f8f6bc
22.07.2022 10:16 greebo Status assigned => resolved
22.07.2022 10:16 greebo Resolution open => fixed
22.07.2022 10:16 greebo Fixed in Version => 3.1.0