View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006003 | DarkRadiant | GUI | public | 09.07.2022 19:35 | 13.01.2024 05:31 |
| Reporter | Dragofer | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0.0 | ||||
| Target Version | 3.1.0 | Fixed in Version | 3.1.0 | ||
| Summary | 0006003: "Reload Defs" doesn't remove entities that have been commented out | ||||
| Description | If "Reload Defs" is used after an entityDef has been commented out in a .def file, the entity will still be shown in the Entity Chooser. Only restarting DR will clear that entity from the list. | ||||
| Steps To Reproduce | 1) Open the Entity Chooser and find an entity that you want to comment out (i.e. atdm:nature_pine). 2) In the .def file where it's defined, comment it out with /* and */. 3) In DR, click "Reload Defs" and open the Entity Chooser again. The entity is still available. | ||||
| Tags | No tags attached. | ||||
 |
Yes, entityDef declarations are never really removed from memory to leave references intact, even after they disappear from the source files. What I can do though is to change the parser to hide these declarations from the tree views - in fact I think in the declmanager branch this might already be the case. I'll have a unit test added to ensure this issue is resolved. |
|
DarkRadiant: declmanager add7a9d3 22.07.2022 09:49 Details Diff |
0006003: Add unit test checking that a declaration that is removed in the course of reloadDecls has its visibility set to hidden |
Affected Issues 0006003 |
|
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: declmanager 06623764 22.07.2022 09:55 Details Diff |
0006003: EntityClass visibility is reporting as hidden if the declaration is defined in a hidden VFS file. Otherwise rely on the information in the key/value pairs |
Affected Issues 0006003 |
|
| mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
|
DarkRadiant: declmanager a27f342d 22.07.2022 09:58 Details Diff |
0006003: Reset the lazy-evaluated visibility once the entity class is finished parsing its contents |
Affected Issues 0006003 |
|
| mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
| mod - radiantcore/eclass/EntityClass.h | Diff File | ||
|
DarkRadiant: declmanager f05a410d 22.07.2022 10:05 Details Diff |
0006003: One more test checking the IEntityClass:getVisibility() method result |
Affected Issues 0006003 |
|
| mod - test/EntityClass.cpp | Diff File | ||
|
DarkRadiant: declmanager 3439ef31 22.07.2022 10:10 Details Diff |
0006003: Add test checking that changing the editor_visibility is reevaluated after reloadDecls. |
Affected Issues 0006003 |
|
| mod - test/EntityClass.cpp | Diff File | ||
|
DarkRadiant: declmanager f9f8f6bc 22.07.2022 10:15 Details Diff |
0006003: Ensure that the def is parsed before evaluating the visibility |
Affected Issues 0006003 |
|
| mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 09.07.2022 19:35 | Dragofer | New Issue | |
| 10.07.2022 05:15 | greebo | Status | new => acknowledged |
| 10.07.2022 05:15 | greebo | Note Added: 0015003 | |
| 10.07.2022 05:15 | greebo | Relationship added | related to 0005977 |
| 22.07.2022 08:53 | greebo | Assigned To | => greebo |
| 22.07.2022 08:53 | greebo | Status | acknowledged => assigned |
| 22.07.2022 08:53 | greebo | Target Version | => 3.1.0 |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager add7a9d3 |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager 06623764 |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager a27f342d |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager f05a410d |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager 3439ef31 |
| 22.07.2022 10:15 | greebo | Changeset attached | => DarkRadiant declmanager f9f8f6bc |
| 22.07.2022 10:16 | greebo | Status | assigned => resolved |
| 22.07.2022 10:16 | greebo | Resolution | open => fixed |
| 22.07.2022 10:16 | greebo | Fixed in Version | => 3.1.0 |
| 13.01.2024 05:31 | greebo | Status | resolved => closed |
